Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760207AbYA3QqC (ORCPT ); Wed, 30 Jan 2008 11:46:02 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751544AbYA3Qpx (ORCPT ); Wed, 30 Jan 2008 11:45:53 -0500 Received: from mail.atmel.fr ([81.80.104.162]:51097 "EHLO atmel-es2.atmel.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbYA3Qpw (ORCPT ); Wed, 30 Jan 2008 11:45:52 -0500 Message-ID: <47A0A9BC.7090705@atmel.com> Date: Wed, 30 Jan 2008 17:45:48 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Pierre Ossman CC: Marc Pignat , Andrew Victor , ARM Linux Mailing List , Linux Kernel list Subject: [PATCH] at91_mci: minor cleanup References: <200801151444.21140.marc.pignat@hevs.ch> In-Reply-To: <200801151444.21140.marc.pignat@hevs.ch> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 44 From: Marc Pignat MMC_POWER_ON is a noop, no need to set the power pin again. Signed-off-by: Marc Pignat Signed-off-by: Nicolas Ferre --- MMC_POWER_OFF/MMC_POWER_UP turn the power OFF/ON, there is nothing to change when ios->power_mode==MMC_POWER_ON. Also changed indentation for the switch (CodingStyle), because there is no other switch statement in this driver. --- a/drivers/mmc/host/at91_mci.c +++ b/drivers/mmc/host/at91_mci.c @@ -658,13 +658,14 @@ static void at91_mci_set_ios(struct mmc_ /* maybe switch power to the card */ if (host->board->vcc_pin) { switch (ios->power_mode) { - case MMC_POWER_OFF: - at91_set_gpio_value(host->board->vcc_pin, 0); - break; - case MMC_POWER_UP: - case MMC_POWER_ON: - at91_set_gpio_value(host->board->vcc_pin, 1); - break; + case MMC_POWER_OFF: + at91_set_gpio_value(host->board->vcc_pin, 0); + break; + case MMC_POWER_UP: + at91_set_gpio_value(host->board->vcc_pin, 1); + break; + default: + break; } } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/