Received-SPF: pass (google.com: domain of linux-kernel+bounces-175061-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Singh, Krishneil K" <krishneil.k.singh@intel.com>
To: Simon Horman <horms@kernel.org>, "Lobakin, Aleksander"
	<aleksander.lobakin@intel.com>
CC: "Drewek, Wojciech" <wojciech.drewek@intel.com>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Eric Dumazet <edumazet@google.com>, "Kubiak,
 Michal" <michal.kubiak@intel.com>, "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>, NEX SW NCIS OSDT ITP Upstreaming
	<nex.sw.ncis.osdt.itp.upstreaming@intel.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, "David S. Miller"
	<davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl] idpf: don't enable NAPI and
 interrupts prior to allocating Rx buffers
Thread-Topic: [Intel-wired-lan] [PATCH iwl] idpf: don't enable NAPI and
 interrupts prior to allocating Rx buffers
Thread-Index: AQHal+hNhMcZHvVF2kSeEm3ZM1H/ILF/OdQAgBBgYsA=
Date: Thu, 9 May 2024 23:03:27 +0000
Message-ID: <MW4PR11MB591159578D0D2AFDB0CB8917BAE62@MW4PR11MB5911.namprd11.prod.outlook.com>
References: <20240426144408.1353962-1-aleksander.lobakin@intel.com>
 <20240429125742.GX516117@kernel.org>
In-Reply-To: <20240429125742.GX516117@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RBxKIZyKYZgj7WBYb6gR1F97sYK6B5Gmd6FzgCFlxnah8rykhfAO34uZoRpG?=
 =?us-ascii?Q?RntwQXR9mSNzaaxYenICAlvjf3Ysi8+3t5Q4lLvKvFvVYU5UnbrFBVTFeGGq?=
 =?us-ascii?Q?2Y+ede1wBy2Wr+x2UR2OFXS9F/tn8tPWtOB21diAOiu9OP+nmoWlfloT0P6N?=
 =?us-ascii?Q?V712fL7j32t8hkRcTjPR/6K+OJNXhVx9nibLlprCafgqF5fGfrJOrKs1IBOR?=
 =?us-ascii?Q?pmnmhoDyb3tqwROwfVvrKfMq+fw5uM4sXO/XTrO77kYY0yVSdgt5OLqsro8a?=
 =?us-ascii?Q?WkI+PEfLOWTe2H3aN7t35pbJ1c5D1vyo71COTgZ72m+QUifSuNnxWdaduxuz?=
 =?us-ascii?Q?0jW0BlKfK0vPDinikRFVvYV/04vLYGY8Zzw9fe2sIZPbftfuBRHktqUgFvUB?=
 =?us-ascii?Q?RbHfWApePUW6Y3Ag24kYo4x1VoKDWwACcz0s9ybL2pxHLhZV2T+z1r1oo0SO?=
 =?us-ascii?Q?Wvzyev1xq5v7rD2F64ph30n99Gbxv7MTVW3VP7kNKnYCZfEJWrNux/h6Ygf9?=
 =?us-ascii?Q?jQjOxjgK8mHbF7nqwCz37aqX28e3sqgDLpYfraswQfg5jRMYpE4VV6mEp9rG?=
 =?us-ascii?Q?rNWt6zokRR3fsFwC3+E0EzHAzwwQC/xeVxX4PVQjkEchVN4e/Ua4Q+TqBgVR?=
 =?us-ascii?Q?r7czvHCKfDPBnbfUsKD3cOBS4jQbSeERN57/hI+trXjx9Q24FDvGpacDDQ5l?=
 =?us-ascii?Q?EnheDLku1gPpcI6aHucKKwB7hiHO1VJaeRiFjpkkTISIL4a7nk4OJLOjHXjr?=
 =?us-ascii?Q?dMfnW7kuOF+9FQDdNM3bd8D1HMPAZDyjqirbVAlPQKDC+GO6yIqBj0ucrNnq?=
 =?us-ascii?Q?vTOU+nohse/uZIQ1z75GXq3a6qPAZPBu2RMg9ytJcFEwO8FukbqXDT4Qa8UF?=
 =?us-ascii?Q?iZq5ZuCY+iMajz9My47l01NNB4PGbqzYF3ghY/J9Jejp/k9NDnwmST1jUN6Q?=
 =?us-ascii?Q?SqHNm8BcpKJrEeae147LOOW3zigpKjhiX0UAcgII4QDUq/fWASKCs47i4p+p?=
 =?us-ascii?Q?FFebsmnDTlFEAvMpG84+h1/BsWpgMhs/EkYLJ46gU71XrUqzKxQqcLZ9uluN?=
 =?us-ascii?Q?uwmEQ9HgDR+lxGN3jkaoE1b9sO9MIaWYleXTnEtm0RjDNBSmxMc0BS9Vokna?=
 =?us-ascii?Q?bDTL7ddUtuiUtpkVjCgQmq/vCJ0m16/95d4zUVOyW5AK3B7y5fkp9jTXrEJw?=
 =?us-ascii?Q?ij1ToOMqBzGloV2bdSCK6AyO+9WrVkjy2o7vPxBTGwUF6ASgb83fXu7W8ZmZ?=
 =?us-ascii?Q?7jIPv2lkxJwb6zuRMXB0AwBDHgEYQbW7LmIQu5iIWTkzKbhdp7ADJaUT4uX/?=
 =?us-ascii?Q?jfTXJFTk5ETvJWDAJ5U72/elTyWunGe1b6QmYK++d2Mn2PUWO1CLhqLcIuuW?=
 =?us-ascii?Q?YOaeCCeqNY9a3Dqukri6eZDj4UY+Y+rClOuwnNiRimFo3bzBMI/kb2uRUL3g?=
 =?us-ascii?Q?8gtS5bUBt7KuKV+x7zWgxx37WjSVAN9nx6D6ZMz/rqCViR6t/E07h8IIDj3y?=
 =?us-ascii?Q?hl15jvcjOR6/00YknKbja2fpBEOKrGzE9p4tFsPGbwoRXw2ZA2Qd34MxJi7Q?=
 =?us-ascii?Q?NhJGiB/VMfE+5q8vZRBPEvKgyrj2thkIOHxyBG9Znc5m+hSJSCjf6GYAAfo1?=
 =?us-ascii?Q?Cg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e71a554c-7041-4592-eabe-08dc707c3cd2
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2024 23:03:27.8081
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: axHfGpAbhsNdUoElfTahel5KHJBbmL5yKqK+enKq9VF2aDxT/Sm7LiXgi1FtjlnQf/q6StpFLzMRgUFlVdl0v3jhMGZAJVNYfl5vUhAv/N8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4706
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Simon Horman
> Sent: Monday, April 29, 2024 5:58 AM
> To: Lobakin, Aleksander <aleksander.lobakin@intel.com>
> Cc: Drewek, Wojciech <wojciech.drewek@intel.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Eric Dumazet
> <edumazet@google.com>; Kubiak, Michal <michal.kubiak@intel.com>; intel-
> wired-lan@lists.osuosl.org; NEX SW NCIS OSDT ITP Upstreaming
> <nex.sw.ncis.osdt.itp.upstreaming@intel.com>; Jakub Kicinski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller
> <davem@davemloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH iwl] idpf: don't enable NAPI and
> interrupts prior to allocating Rx buffers
>=20
> On Fri, Apr 26, 2024 at 04:44:08PM +0200, Alexander Lobakin wrote:
> > Currently, idpf enables NAPI and interrupts prior to allocating Rx
> > buffers.
> > This may lead to frame loss (there are no buffers to place incoming
> > frames) and even crashes on quick ifup-ifdown. Interrupts must be
> > enabled only after all the resources are here and available.
> > Split interrupt init into two phases: initialization and enabling,
> > and perform the second only after the queues are fully initialized.
> > Note that we can't just move interrupt initialization down the init
> > process, as the queues must have correct a ::q_vector pointer set
> > and NAPI already added in order to allocate buffers correctly.
> > Also, during the deinit process, disable HW interrupts first and
> > only then disable NAPI. Otherwise, there can be a HW event leading
> > to napi_schedule(), but the NAPI will already be unavailable.
> >
> > Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
> > Reported-by: Michal Kubiak <michal.kubiak@intel.com>
> > Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> > Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
>=20
> Reviewed-by: Simon Horman <horms@kernel.org>

Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>