Received-SPF: pass (google.com: domain of linux-kernel+bounces-175071-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 9 May 2024 16:26:24 -0700
From: Deepak Gupta <debug@rivosinc.com>
To: Conor Dooley <conor@kernel.org>
Cc: Rob Herring <robh@kernel.org>, paul.walmsley@sifive.com,
	rick.p.edgecombe@intel.com, broonie@kernel.org,
	Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org,
	ajones@ventanamicro.com, conor.dooley@microchip.com,
	cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr,
	bjorn@rivosinc.com, alexghiti@rivosinc.com,
	samuel.holland@sifive.com, linux-doc@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-mm@kvack.org,
	linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org,
	corbet@lwn.net, palmer@dabbelt.com, aou@eecs.berkeley.edu,
	krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com,
	akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com,
	Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com,
	shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com,
	jerry.shih@sifive.com, hankuan.chen@sifive.com,
	greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com,
	charlie@rivosinc.com, apatel@ventanamicro.com,
	mchitale@ventanamicro.com, dbarboza@ventanamicro.com,
	sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org,
	vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com,
	songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de,
	bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name,
	maskray@google.com, ancientmodern4@gmail.com,
	mathis.salmen@matsal.de, cuiyunhui@bytedance.com,
	bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il,
	alx@kernel.org, david@redhat.com, catalin.marinas@arm.com,
	revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io,
	deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org,
	jhubbard@nvidia.com
Subject: Re: [PATCH v3 04/29] riscv: zicfilp / zicfiss in dt-bindings
 (extensions.yaml)
Message-ID: <Zj1boEJG4ijcdNi0@debug.ba.rivosinc.com>
References: <20240403234054.2020347-1-debug@rivosinc.com>
 <20240403234054.2020347-5-debug@rivosinc.com>
 <20240410115806.GA4044117-robh@kernel.org>
 <CAKC1njSsZ6wfvJtXkp4J4J6wXFtU92W9JGca-atKxBy8UvUwRg@mail.gmail.com>
 <20240415194105.GA94432-robh@kernel.org>
 <Zh6c0FH2OvrfDLje@debug.ba.rivosinc.com>
 <20240509-cornflake-foyer-e6589c2bc364@spud>
 <Zj0aAiZiTrt9ACjj@debug.ba.rivosinc.com>
 <20240509-clatter-crewmate-9755669b9452@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240509-clatter-crewmate-9755669b9452@spud>

On Thu, May 09, 2024 at 09:32:49PM +0100, Conor Dooley wrote:
>On Thu, May 09, 2024 at 11:46:26AM -0700, Deepak Gupta wrote:
>> On Thu, May 09, 2024 at 07:14:26PM +0100, Conor Dooley wrote:
>> > On Tue, Apr 16, 2024 at 08:44:16AM -0700, Deepak Gupta wrote:
>> > > On Mon, Apr 15, 2024 at 02:41:05PM -0500, Rob Herring wrote:
>> > > > On Wed, Apr 10, 2024 at 02:37:21PM -0700, Deepak Gupta wrote:
>> > > > > On Wed, Apr 10, 2024 at 4:58 AM Rob Herring <robh@kernel.org> wrote:
>> > > > > >
>> > > > > > On Wed, Apr 03, 2024 at 04:34:52PM -0700, Deepak Gupta wrote:
>> > > > > > > Make an entry for cfi extensions in extensions.yaml.
>> > > > > > >
>> > > > > > > Signed-off-by: Deepak Gupta <debug@rivosinc.com>
>> > > > > > > ---
>> > > > > > >  .../devicetree/bindings/riscv/extensions.yaml          | 10 ++++++++++
>> > > > > > >  1 file changed, 10 insertions(+)
>> > > > > > >
>> > > > > > > diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml
>> > > > > > > index 63d81dc895e5..45b87ad6cc1c 100644
>> > > > > > > --- a/Documentation/devicetree/bindings/riscv/extensions.yaml
>> > > > > > > +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml
>> > > > > > > @@ -317,6 +317,16 @@ properties:
>> > > > > > >              The standard Zicboz extension for cache-block zeroing as ratified
>> > > > > > >              in commit 3dd606f ("Create cmobase-v1.0.pdf") of riscv-CMOs.
>> > > > > > >
>> > > > > > > +        - const: zicfilp
>> > > > > > > +          description:
>> > > > > > > +            The standard Zicfilp extension for enforcing forward edge control-flow
>> > > > > > > +            integrity in commit 3a20dc9 of riscv-cfi and is in public review.
>> > > > > >
>> > > > > > Does in public review mean the commit sha is going to change?
>> > > > > >
>> > > > >
>> > > > > Less likely. Next step after public review is to gather comments from
>> > > > > public review.
>> > > > > If something is really pressing and needs to be addressed, then yes
>> > > > > this will change.
>> > > > > Else this gets ratified as it is.
>> > > >
>> > > > If the commit sha can change, then it is useless. What's the guarantee
>> > > > someone is going to remember to update it if it changes?
>> > >
>> > > Sorry for late reply.
>> > >
>> > > I was following existing wordings and patterns for messaging in this file.
>> > > You would rather have me remove sha and only mention that spec is in public
>> > > review?
>> >
>> > Nope, having a commit sha is desired. None of this is mergeable until at
>> > least the spec becomes frozen, so the sha can be updated at that point
>> > to the freeze state - or better yet to the ratified state. Being in
>> > public review is not sufficient.
>>
>> Spec is frozen.
>> As per RVI spec lifecycle, spec freeze is a prior step to public review.
>> Public review concluded on 25th April
>> https://lists.riscv.org/g/tech-ss-lp-cfi/message/91
>>
>> Next step is ratification whenever board meets.
>
>Ah, I did the "silly" thing of looking on the RVI website at extension
>status (because I never know the order of things) and these two
>extensions were marked on there as being in the inception phase, so I
>incorrectly assumed that "public review" came before freeze.
>Freeze is the standard that we have been applying so far, but if
>ratification is imminent, and nothing has changed in the review period,
>then it seems sane to just pick the freeze point for the definition.

Yeah I don't think wiki is that regularly updated.
But take a look at Ratification-Ready list of specs here
https://wiki.riscv.org/display/HOME/RISC-V+Specification+Status

>
>Cheers,
>Conor.