Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp177946lqo; Thu, 9 May 2024 17:04:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWU0w2F+WRm6vwsgeinNyaGp/T4F98HprAF1rxA0kqnJU3Jpzu5Afv7QwCHbc/NNILSJdfoohuGsO3VlmZ/eDz95evqKkoYPpMf+7D/zg== X-Google-Smtp-Source: AGHT+IHJ+LqJc8M/tMuGh7Z6clu/BPbdKLeQBhGpkfVHlm+h21mMoqIjpPs3MnUA4u/3kOSjErav X-Received: by 2002:a05:622a:4b06:b0:43a:cfc5:f0a6 with SMTP id d75a77b69052e-43dfda8cdf9mr10879301cf.13.1715299494040; Thu, 09 May 2024 17:04:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715299494; cv=pass; d=google.com; s=arc-20160816; b=SwAwJliTZ4lLT0Gn4pzvACI9m5niRiJNxiSs0irZWE4rtPPogNlJ6yZuz9mQqYIAe5 KU/m0fEMDorjCe0xa/eBhva5RqCUuS8q2hXtYwomcnEvczZM3q6o3siBdRoCydzw7qV1 +Vw0c6a6GI5wPNdFVQQYPesqW1GoN107HhNvM3FUyhhxW+IcNZxKNVPv0ra1zwGxZBFS iyko38YRejOugRlGrrrwlAKmlkAKBAZlkIWZ2Yyc/XiiA3AcAcMPPrzlJK87Ma3s/bI/ D+R0DJW30ID4KZ0rqYN/2f8OSClXRm80QBqeBfu6Q80vbDkqZctsS7SNxOMCfwZAqrbe CFfw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=KsXgX09HbxfaPwZ+3SFqjny56qIvrC2+5M1uaVWSUvY=; fh=GDcNCADtsYOCUoTbfP/DwBCAvqdIix20sW1Uqs4ud5w=; b=UejoVOfroHfklf20qgBL/NxJSxJMPkmQCVgWVdqvjL/egMTeAWXH7Z6+RJQHDZfJWq 8nUPt+XDLWpFbcCz+snJc7WOUFHoeaou+l59zcXRa5qHnGon8Zr+ScyuOsQX9cLoN0ce cNyun1mQZ755HjuQRj18IozsMTrz6p9sDBN6IBlpuGDrGDB691EB+oKzcnCaNrj2t9sN drUL9owHEz5yt4r63otIm+AtQhQ8CJUoT+9gRxIja4NBT+t2sLw/8xgfzBmADoaP3jFB 7/HkSALApwuuc6LsRizXQumqht74qxU6NzGvWut8U5nvrmgtNgHCn0MNk2CfYCyE7sH0 l4qQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=a6c3xcOv; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-175088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175088-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-43df56af8ffsi23529871cf.558.2024.05.09.17.04.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 17:04:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-175088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=a6c3xcOv; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-175088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175088-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 770C81C2163C for ; Fri, 10 May 2024 00:04:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D84915BB; Fri, 10 May 2024 00:04:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="a6c3xcOv" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A911E7F for ; Fri, 10 May 2024 00:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715299488; cv=none; b=nCjEuMqmNTHj2B13VhAHdIb0jg1sjM/yQrBgWb45ZEQ4I+HxwmRayF1SR1MSPvERTpbho7SBonm+Qt0H0qyM21+X5zjiGGw5wFKKWPBXdzdJyCLP43AfPoypT9Rxjc+yj+6Pnv/41aZf91IJIHhe/4dOoobIbACYk7AfK3ph4vU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715299488; c=relaxed/simple; bh=vd1gR45j5R2k7R82LUMZNLF6BhI9AiNrobEkZYG6OFg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rFj7OGm1zhyx/iTU5VXqPuodNrgShkYJ6K8aJx7e5TanQdN0jUzZeFwmsXplkoNE3zEZlIzKbTb0YuNJJgY+/lgZMz+SUPUvOJjQbilhYQGh6YdOzGIK1/n/uxDufr5zUMSYVgFO/RlnqUlK7icOwHnqOYDaZm/xIBZM3BJQCRI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=a6c3xcOv; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715299487; x=1746835487; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vd1gR45j5R2k7R82LUMZNLF6BhI9AiNrobEkZYG6OFg=; b=a6c3xcOvkJrQMu4WENkHEkHw6edXeFTtzXHJAZ6a/iw9c6B1ut/EfgiP G2NejCXLupByoYuHay+v4MLPGkf7i7Yk+HuGFbpC740S+a+BEdPadg/CA um0mZ/EqVMbyibw7FpfEnE+8AbhYXv0o02rj709j7p4pJsLjOxe80LC4x +9r/NS0/cIu6vbDpR7LSvblZT2xAuTnhad4izcgO4LD3TL8kT+heuzPrm s+sOZ98Ba3warJUbVOIcu7D5wB4/ySHf4Zthb3ouRbfPK9NNtpuWj3tBh aA+hORYwh0ob2cxMaH/c5n8iYVoMDE8RHjlg06L/5Z8mx+qRNBdez+U5S g==; X-CSE-ConnectionGUID: GIv6gytxR0SdnVSYBmlVxg== X-CSE-MsgGUID: i9exh7tVQ76j+yDWq+5FBg== X-IronPort-AV: E=McAfee;i="6600,9927,11068"; a="11117625" X-IronPort-AV: E=Sophos;i="6.08,149,1712646000"; d="scan'208";a="11117625" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 17:04:38 -0700 X-CSE-ConnectionGUID: xPj8nEPvSy+k+tFEejAmDQ== X-CSE-MsgGUID: T7GrQcT7RYW7Zu8g6GPi0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,149,1712646000"; d="scan'208";a="33869947" Received: from epinckar-mobl.amr.corp.intel.com (HELO [10.209.98.74]) ([10.209.98.74]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 17:04:37 -0700 Message-ID: Date: Thu, 9 May 2024 17:04:36 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/entry_32: Move CLEAR_CPU_BUFFERS before CR3 switch To: Pawan Gupta Cc: Borislav Petkov , Dave Hansen , linux-kernel@vger.kernel.org, x86@kernel.org, Robert Gill , "Linux regression tracking (Thorsten Leemhuis)" , antonio.gomez.iglesias@linux.intel.com, daniel.sneddon@linux.intel.com References: <20240426-fix-dosemu-vm86-v1-1-88c826a3f378@linux.intel.com> <5b5e597d-7620-4a5a-9bfa-bae26f0b0fa3@intel.com> <20240509221425.zcl6c45thb7wxyza@desk> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240509221425.zcl6c45thb7wxyza@desk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/9/24 15:17, Pawan Gupta wrote: > It probably can go right before the SWITCH_TO_USER_CR3. I didn't have > 32-bit setup with dosemu to experiment with. I will attach a debug patch to > the bugzilla and request the reporter to test it. There's an enter_from_vm86.c in the kernel selftests. That will at least exercise this path.