Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp178230lqo; Thu, 9 May 2024 17:05:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVHJgMWBv+5I8uhexI8XaENIxXYGJsbopTWjDAWzxlT7aF2uw4kftV719QtTYkQBKCuWn3yWjJ39Yws/532eO0/flQMedixf4j37Yf2rg== X-Google-Smtp-Source: AGHT+IGs+6/+Cf4iamWEudanVcsRUx0Nq+DKNiwh9R/z0V4rnSh6SFKcbgeoPTaOcdrg1J83RmQG X-Received: by 2002:ac8:5741:0:b0:43a:6226:db5 with SMTP id d75a77b69052e-43dfdaab1b8mr12211421cf.13.1715299527403; Thu, 09 May 2024 17:05:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715299527; cv=pass; d=google.com; s=arc-20160816; b=US400W94+Y3SD0YoeJUVP2miYKpclT//TVcv6Ro2iiGyMUVEd1swOKkLMc2d8nCLsg ufatQgF/t5ZjSJV42B1BkOxFtRfoo4gApwo3oqKSutNihPRF8W7iHZa9WRCrGy6e9URh VdXMzBcbXQ3WTxGBxqTj1hUYkgmKu4BkZjowXlfmNM8gS4OZz477mYKfpYpSgwf5zWut SGciOGMqnuQ6BUl4/FOGOePm+FSOaLcJRErWyFqKT/k8dIyk13fVkr6ZzlkSmC+7pWqL cp3M1Xzh4SEBiGY1tl9MvB5lyCvOduRWZkhglkFnEbgqGn5BiDfJEh6B+fLYg1Biuejy 3fMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=ZJDvHxVDamFulMq6bCsnACysSO0ggfMo1ZnPMiLHLuw=; fh=29DW7vArk/1D9vc082T29i8htU+lgzrfkcgDK5Kz0wo=; b=U9zhznqPZSEcaPVtBfphFUqArm32pUBjFoZGzY16WlwTU5avXKuIdP1UAop8it5jIx VoP00s2yuKPiEaBWSxm1YY3Hq7Foz9yau71fOzt6OPS28OY9ssPd/Wj8pbbAUJznHZ9i ULteztL9zt0xbRLnTY38bT/kKprLf6Ai4p2aXqClbViQ8ZuOKYQlLI0kEdvu7ohEJx8K n/BEu9nrN8DGuQQMVbSTiQPhfXa822+gWhlWGBfpCnEBCkNmCubjB0e7S+Tt+qzDQ3/A K9bS5qkyRfe7rtzRbSSEx1Iqp72zS+tWNUbQqliJR9d4yGYTYPWZx7ZHCt4zJzVUrP2+ IhiQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qQcLfqtU; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-175090-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175090-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-43df56e9fdcsi21886081cf.775.2024.05.09.17.05.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 17:05:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-175090-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qQcLfqtU; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-175090-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175090-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 26ACA1C2318F for ; Fri, 10 May 2024 00:05:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D9E3E1391; Fri, 10 May 2024 00:05:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qQcLfqtU" Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56BF01396 for ; Fri, 10 May 2024 00:05:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715299509; cv=none; b=k2P9umf/M1Ul/Yq5fPkci9I8o1o4fIor04HRsXIakclkgts0BLy8MPTk9vfCr0sktY++Pp4xvsNf7w0O4zTOrlH1IzWBAkpbsbTS3FW0F9u6urNcLe53NEmygQik3RMgLTQDWg5/a9q8tMm43AQHIDFyHUtMHvs3VT9YYGVGAkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715299509; c=relaxed/simple; bh=E0lmq8MX+4Jk/oyYQbE2kOJ5yJ6GrU9UxEZJ7muUZBw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f3FS4rXq0V/Rruhx4Riv8L2ojaDq8rBluAN80f99H53LFr3h+JxisecuXz7xFPkYuqTh4ajbgY/aL59d00VwtINAmzV6f72fr5BphCSuOT6oRcjoIQljWbKymUg/GmBgYBud/OhZVn0aJIBg0x5sF7wJ2e+6G9ZnowyLlnPDn8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qQcLfqtU; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3504ad82a64so297436f8f.3 for ; Thu, 09 May 2024 17:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715299505; x=1715904305; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZJDvHxVDamFulMq6bCsnACysSO0ggfMo1ZnPMiLHLuw=; b=qQcLfqtUUIqjU8fledlVGfAuSC5VqHup0NMuSDiYxHZ1YoP8oYPgt7CEEoQEAilTMt 0F6nJSTHT1Z2v4u53KALrEey+amxdvpz/KCbmyJ+fmYYGOeO7SO+YpYCKqH5wWL84Yu1 L5zgXDNpjQNGn/QoIS5Tl4bNQ6ovgcKapy3aPtIiumSrEmtJGZva7CIm3dwxpgq6Edwn lNeYljIn+WPQFZqEa3GN6Hd3ZH+yX2pqVi+nhnh89qyjZepd3Yv+G4jBwDW8RoJYw6S5 F8WaPbXLKybQQMSV4dsvtwMAW/iTQXhqH055e8KLsbcXpWpvvEDu6FOfIyIG8GYlVDPY rujA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715299505; x=1715904305; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZJDvHxVDamFulMq6bCsnACysSO0ggfMo1ZnPMiLHLuw=; b=olQk8UCGfnuReS9SK49u9ZVIFY83YPWoQ8tY3sWQfAbBs6b8tHXutCcWFYS5Dq4owc ydwVz6mQuDx1mQNdpdUxkEq/mVWBM9a1FehkGFCkA3v6X5sZrgFhuYJInT01Cd4qRsGj Sa7YolkSOpaGGP+aCaU8KV2eLxqD0lCmwAaw7fnre8f2G7kAyjRD2HKQvS+my7EjQVyf XBAKo5NrQxIyNt8G+snsKnyA2Dlwgqizlh/u9E6pKYg6oiy/te0MGcBp54ZKOiNgeIit O1pVDP20O7gVcp1+WMMr6Jv8NX8qrWbeVyDpWsyPw0AyEonhd3trBzdT05lKLBtK7Rn9 of6g== X-Forwarded-Encrypted: i=1; AJvYcCV2hPBBfmaSMtnuAcl4OSmhuOtPV0vIFWQc/jA4dVQuEcYOg2LPuoT6PomVL1UWq99rt7j3qjKfM/rvQBx6zBhA5RyOxoZPwos4jvse X-Gm-Message-State: AOJu0Yxsx83ZipA81W2TQSZScaQfJ1GEWb8YLyYn2ohQX3AaHsE7/WLf MogIohNSxP2CPetFGExTTzA62/2zA4kcHR2jpM9tN1mbQDV8VhqK/uP7kXs+NGQ= X-Received: by 2002:a05:6000:cc6:b0:343:7cef:993d with SMTP id ffacd0b85a97d-3504a96a111mr747947f8f.61.1715299505664; Thu, 09 May 2024 17:05:05 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3502baad1f0sm2955412f8f.89.2024.05.09.17.05.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 May 2024 17:05:05 -0700 (PDT) Message-ID: Date: Fri, 10 May 2024 01:05:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 16/18] media: venus: Refactor hfi_sys_get_property_pkt To: Ricardo Ribalda , Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil References: <20240507-cocci-flexarray-v2-0-7aea262cf065@chromium.org> <20240507-cocci-flexarray-v2-16-7aea262cf065@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240507-cocci-flexarray-v2-16-7aea262cf065@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/05/2024 17:27, Ricardo Ribalda wrote: > -struct hfi_sys_get_property_pkt { > +struct hfi_sys_get_version_pkt { > struct hfi_pkt_hdr hdr; > - u32 num_properties; Disagree with the structure name change - the structure describes the packet which in this case is a get property packet. The data field identifies the packet to the firmware. If I were to end up reading kernel code and firmware code it is easier on the programmer to match both ends of the protocol with a common namespace. Please retain the name of the packet `hfi_sys_get_property_pkt` and the existing `num_countsathing` in this driver keeping `num_properites` --- bod