Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp190030lqo; Thu, 9 May 2024 17:36:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWaZxE24ho5G1T7vezLeVgv7PUqJxDJy947NxmVCbtCgFTvFRSrhYP1Njmt1tzOYlMVDVgBa/a07Abn68ndWNVrzEUpXsL/jasvwL6VTQ== X-Google-Smtp-Source: AGHT+IHeLf3nbw4d7e9xBMhCQ6GmnIQx1HA7DSmHAt8D5XLq5cL8YEBEY3zG+1RrT/mXYiqYSri3 X-Received: by 2002:a05:6512:245:b0:519:2c84:2405 with SMTP id 2adb3069b0e04-5220fe78a2emr585307e87.44.1715301395592; Thu, 09 May 2024 17:36:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715301395; cv=pass; d=google.com; s=arc-20160816; b=FEgwcUD8/uWH3B7KpCGofJwTd4A1sRqRO7crKJdnvBjiiqARGsQ0PIxmo/ByMwJmDF 53iZcljzmtkszka1kZ+1aEYRopVynE38QfRgIM9fpYfL5wmJiv+xRlIO5nlImnKLIa7L NALLUDIl+9j+yNmz4Go0moUapoZskQ6RzWBp9PMUFiCzPa5lj9cDlX7iuDVTqBN9VZau 464A7w36gIFzdQBQupM1hHfOkoWhjMiGy0neHsyPK1KASe5xqkyb3oswLdJ8e7/1Ok4F +V5Onab7Ghdz0q75AemJJSzpK6tTE0i7ybjIFAqn9ioIdLSiFRJPV87ROcyOVJL/0Qzg avIQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=lxHOfwVSyKJ/q4p7DPvmWkPRcJtMXHGpCfEpW6GyR+E=; fh=PZb+ooOGSCqCUloynqkrUmUsAWA2utOP8ySkHUYMqjY=; b=iVQ199RdswMVE/Xwqg53FrJVG/sFMNe0NXHVsLPALPn/VDwF3UP598c6NJU83h8wD/ PanfmzqwUYvNEba98rZMmWSzSgwbbIDdHZLms1MCkSNULcSejYmh8qbOidtjx8IbWuxe YFmXcIx/X7LfP3Ct9+FkITXgXYOq/IRAqCWOFXCvPz7yqGek4TXN725AU8ORab3pfSVe y544SH0xOTAi54hOvXG/SmlmJOZPghmcC8k4J4liwGEmTlUHnyH4chCZeGW8BHQgyEsr b0iLU19D1XRCQ0dcFOBqsM3RwEeIq1ejkxkaJ0kkYtVD5kOXTFhS7b7SbNUVDYrUf3Pt 4tOA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=h+m6vBKu; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-175169-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175169-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17be67a5si129283366b.845.2024.05.09.17.36.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 17:36:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-175169-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=h+m6vBKu; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-175169-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175169-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2B0F41F2182B for ; Fri, 10 May 2024 00:36:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C5E46134DE; Fri, 10 May 2024 00:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="h+m6vBKu" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA24514A81 for ; Fri, 10 May 2024 00:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715300434; cv=none; b=SLYUZP/L+YX0XORLHpQtOCneEtXpJaqWBW5sc4C2LmQuiS7wpckOlofxiJ5y/ccrErD34nYDrRsJJUyo4v77R0AmAqh2quOCh7V80FIhmo0jVxl2GGRWSs9QtBtBf8C/4L0WhG9cMDOOTl+wsNR2BQH/Zo19dY6YTApTgMGegVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715300434; c=relaxed/simple; bh=vCUy5Dvd4hAT0nyZjb4oARqXhkGR5imJb5Q5T45ImGc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sn7FjStxgcFXFd+wj+DDXdC9QZCfPumiz1tj/qHu5TcTKmirBs6Mewg38jV0V/jF0vIqfzOv3nIvw7c1sSBxb7XOjZWj1EV0XT95IVQ/hJjjZn0gtEGVknW6VHlV3yQjcvj7HP3K9AuZbjiiuYU/CvL5ZdsPl3YG4ZvmdXrUxVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=h+m6vBKu; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715300433; x=1746836433; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vCUy5Dvd4hAT0nyZjb4oARqXhkGR5imJb5Q5T45ImGc=; b=h+m6vBKudEu4AiodX37ZqZ7iIGzVD8ECeYdTp8u2l0971aZNRPPS06J+ Ml5M9mVBGxNxqkjJj3MuUuihOKP9e2hoE5xieBfh6FK0eXDscriwHP9N3 zQbydf5dwuUP9Yn0oJtkDG5N0mwzfc7LdYVLHX1bqoYvHq+ZmRg20UbAK OKSVLRyB64d97LIiTjHnmCsXs5N4rN+hv5wpeAXFKcGxjUmeIejSasgMC lQQwYaEF2hBF/CR5O0fw4NCKDRVL62mVpQ+Mfs/pLFmod4ZDP+UA7Cdpu 1m1w5WpcTAQa+Ng6/qs99RlT27wHTF2Jfm5vugUGmkLFGRaqMI0BRhQGy g==; X-CSE-ConnectionGUID: 2gG6VbmJTcWM3ZxO5fyuFQ== X-CSE-MsgGUID: zxqYyxItQkitvD2qz+SD7g== X-IronPort-AV: E=McAfee;i="6600,9927,11068"; a="11137384" X-IronPort-AV: E=Sophos;i="6.08,149,1712646000"; d="scan'208";a="11137384" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 17:20:32 -0700 X-CSE-ConnectionGUID: 0gl70xbKRFWoypd5pPtyMw== X-CSE-MsgGUID: 16LG+qDzQIO/V9jDb1M1og== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,149,1712646000"; d="scan'208";a="34281785" Received: from epinckar-mobl.amr.corp.intel.com (HELO [10.209.98.74]) ([10.209.98.74]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 17:20:32 -0700 Message-ID: <5b9a2cef-7b4f-41c3-9f64-4fea4d007cdf@intel.com> Date: Thu, 9 May 2024 17:20:31 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/entry_32: Move CLEAR_CPU_BUFFERS before CR3 switch To: Pawan Gupta , Borislav Petkov , Dave Hansen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Robert Gill , "Linux regression tracking (Thorsten Leemhuis)" , antonio.gomez.iglesias@linux.intel.com, daniel.sneddon@linux.intel.com References: <20240426-fix-dosemu-vm86-v1-1-88c826a3f378@linux.intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240426-fix-dosemu-vm86-v1-1-88c826a3f378@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/26/24 16:48, Pawan Gupta wrote: > Move the VERW before the CR3 switch for 32-bit kernels as a workaround. I look at the 32-bit code so rarely, I seem to forget have to re-learn this gunk every time I look at it. Take a look at RESTORE_INT_REGS. On 32-bit, we actually restore %ds: popl %ds So even doing this: > + CLEAR_CPU_BUFFERS > /* Restore user state */ > RESTORE_REGS pop=4 # skip orig_eax/error_code > - CLEAR_CPU_BUFFERS > .Lirq_return: fixes the issue. Moving it above the CR3 switch also works of course, but I don't think this has anything to do with CR3. It's just that userspace sets a funky %ds value and CLEAR_CPU_BUFFERS uses ds:. I don't think any of the segment registers can have secrets in them, can they? I mean, it's possible, but in practice I can't imagine. So why not just do the CLEAR_CPU_BUFFERS in RESTORE_REGS but after RESTORE_INT_REGS? You might be able to do it universally, or you could pass in a macro argument to do it conditionally. P.S. Can we remove 32-bit support yet? Please? :)