Received-SPF: pass (google.com: domain of linux-kernel+bounces-175170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <ed56e9bd-383e-eba8-874c-e4f0a0a5b9d8@amd.com>
Date: Thu, 9 May 2024 19:23:58 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH v3 04/17] x86/resctrl: Introduce
 resctrl_file_fflags_init
Content-Language: en-US
To: Reinette Chatre <reinette.chatre@intel.com>, babu.moger@amd.com,
 corbet@lwn.net, fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com,
 bp@alien8.de, dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, paulmck@kernel.org, rdunlap@infradead.org,
 tj@kernel.org, peterz@infradead.org, yanjiewtw@gmail.com,
 kim.phillips@amd.com, lukas.bulwahn@gmail.com, seanjc@google.com,
 jmattson@google.com, leitao@debian.org, jpoimboe@kernel.org,
 rick.p.edgecombe@intel.com, kirill.shutemov@linux.intel.com,
 jithu.joseph@intel.com, kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, peternewman@google.com,
 maciej.wieczor-retman@intel.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, eranian@google.com, james.morse@arm.com
References: <cover.1711674410.git.babu.moger@amd.com>
 <363c14eeeac99eb0453ac3429f9e7bd446b2acdb.1711674410.git.babu.moger@amd.com>
 <55fa3189-b5da-494f-8ec2-7f0ab4b8d33e@intel.com>
 <119fbe0f-9688-4382-9263-220f69caa718@amd.com>
 <3f4d2c09-3158-477a-ba9b-f8f809d1999b@intel.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <3f4d2c09-3158-477a-ba9b-f8f809d1999b@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SEZ2VFFKRXBWcDMybVFrMUVFYzVWRUl1WW14d2RleThZUktYQ29YOEJ5bWwx?=
 =?utf-8?B?U2w1Q3E0cjE3R2g4Yk1aTk1MOE9VbHFvL2xwM0dhbVpNZTNtTDQvM25hZXVR?=
 =?utf-8?B?UWNGaUl3NXA2d282MkxPN0VYSlR6WVFHYlRXYkowZFNKc0p4L3V3Zmh6NERs?=
 =?utf-8?B?a0xOWk11aFN1aVdLU1d1K3ZyUmRINnFyU0RSVnlXWmRzSmh2ZHJCODZFZ3pu?=
 =?utf-8?B?NTlwTDZoQWZxK2F4Tm1kMDRzRHBYSEE5bnU0MDR3VG9TM0dOVjMxbjcvMUh2?=
 =?utf-8?B?eWVBZGdwUFZBSjNwYStJTmtFR25QR1dFNHNRcGxJdGhvWHJnK1NaQU1RN0FE?=
 =?utf-8?B?RndTUk40Y29qQmEzdVp0dVNIT3VCR3Q3di9IY2RQYW9jY1R3bW5MWVJkeFdE?=
 =?utf-8?B?MEl3RUUzTjRMVnJyb2FRaDd3RXlBbGFMRDlzMmc3V2FRQlFvYjlURGI5clM0?=
 =?utf-8?B?Tnhkamx6NDJuYzdTTExWaS9VTGlXWERsczdiZGlaRjAveFhPMDJHS0syS0Nv?=
 =?utf-8?B?NzFxMVdGcTA3eG5kcDl3Qlh2YWJMQjVySW5hM0E3TXZ6NjdIdEtYWnA4TEJY?=
 =?utf-8?B?Wnl1WVByZWNBTVA4UkM0R1Rwc1NBRlRZMDV1cTVJVzZXV2R6WnNmdG12eXYv?=
 =?utf-8?B?RjlVTFRqdG9jTDNIVFJ0RjE0RTM1QVFZNjJ4a0dycmZSc2NQWWRnS1RlRlZr?=
 =?utf-8?B?cG5lYUozRGJ6dVExaGhVV2YwNG55VUt5NXBCOEoxMklyaE4xakVMYml3U3da?=
 =?utf-8?B?d0VoYUR1aC9ZSm1GbTdsdktQTEtjSEdrbWNzd21pc3hzOXc3UHhUZG1RMnQz?=
 =?utf-8?B?MldEbERnRDUzZlJJN2dGMTYwdjJaZkQ0TnBMWDZZcnJNSmkvNEhTdXpKMHRB?=
 =?utf-8?B?ZEltRUs4akJSdERHUmtDZjh3YVN4SEJ2ZEVabWtrNHRQVGdkYzl0dEZxLzF0?=
 =?utf-8?B?a3BidW1HT3ZVN2h5MDJxWHlLNHFoWFMzbW9hbEdhdE0rQVVGM3c0UVA5QTBJ?=
 =?utf-8?B?UDNhKzdtT0RJb2N2WTJySmFBQ0ZoQXpHczcxWW1IZjQ4amY2R1FoZzQxajhD?=
 =?utf-8?B?ZW1hTmtKNzBDeFRrbWR0bVdEVU10WWtHODFIYWdPaDdUUHBpUTJ3WUhjZEhO?=
 =?utf-8?B?UHZlVWtpdEIzNlRCejZsK0lyczc2U3RzLzVJaDVUREJGbUJta0R5a1lQR2lG?=
 =?utf-8?B?b00wWXU1bFpzb2dYRm9jR0Z1bVBlL3RocFVFK1JyNXovaWFjYWtBa0U2WXQ0?=
 =?utf-8?B?OFVFdVF1SDhBbGp6bGl4SUs0TU8wajhvUDIzRVhwUTlaa2JlRnZ2VWFIZUV5?=
 =?utf-8?B?YnZKWHVxTlBuL2dEVjc3OU95Q3BCeXpHVG04SGdrVVF6T3dpcUtaLzFlVHhG?=
 =?utf-8?B?Z3FVMkF0UE1vMDBXVWNWY0djN0JXaVFlSTdCdmtibnFsWGhWZlBTRGl6MFJy?=
 =?utf-8?B?ejlQRTV6OStidENYakNycmZjMHI4RHg1UjZySXBwNWhYejBqK2dqM2JwajAx?=
 =?utf-8?B?aFU5bFFDcU1SZjBaMm9RVlNSOS9YWC8wdmMrd3dHdEkyTFJQSWd4b1hUWFQ4?=
 =?utf-8?B?K05HNnRiYlpDdWkzQ2F3USt1cnlXMHVLK3dpUCszd1poc0NTVEdiUXpnN3ls?=
 =?utf-8?B?SUtYa1pBNHlLd1NGa0d3dzZVb2FScDBRbTRzOU9lbks0dzBsdmtkMVA5YnRL?=
 =?utf-8?B?YlpvOVdCYjY3OUNTdktoU2VyVnZhRTl4T0JHV25KQUhpUVpZeTNlZVN2Smpt?=
 =?utf-8?B?R2lCUm91Y3oxOVZuVW5LMjh3S08yVkV6eklXSFozbTlKckJlUk1xdHNjWTZV?=
 =?utf-8?B?U29ZM1drNEo5RlV3QTVWU1B0Wmg2UHVxVXFVaXJ3MjdPZlE3RTdBYUZoVGdi?=
 =?utf-8?B?VFVGbCs2aTZ3VkZ3NHljOHlLcmtha0VSRTd3Tm9EVFY3Z0VsaVBsUEo5cldS?=
 =?utf-8?B?cXFhcUpBYkMybHhjRll1MUxUODI0b3AveDZ4YWdCcTdKaEpoNmNYcUY0eFJD?=
 =?utf-8?B?ejQ3V09DdHR6TE1jVXV2T2tBeklONHc1T0hiSFV6b2FRS3gzMW5LeThVS3M4?=
 =?utf-8?B?R0VzamE4OTdWR0l5Tm10UWxVWW14NHlvUG1nQ1BwN0xHS2FqVnZCblA3REJp?=
 =?utf-8?Q?pBog6rzesxpkH3/JVHRSycvGb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1321658a-781e-4d15-4d86-08dc70877f7d
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 00:24:04.3620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QMuhhrRMNJbSdTTjQFq7lUgd8O7ppu5lBAeAwMymMQ4dkGHMEiGeptyN3VacBbcl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7134

Hi Reinette,

On 5/7/2024 3:27 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> On 5/6/2024 1:23 PM, Moger, Babu wrote:
>> On 5/3/24 18:26, Reinette Chatre wrote:
>>> Hi Babu,
>>>
>>> In shortlog, please use () to indicate function:
>>> resctrl_file_fflags_init().
>>>
>>> On 3/28/2024 6:06 PM, Babu Moger wrote:
>>>> Consolidate multiple fflags initialization into one function.
>>>>
>>>> Remove thread_throttle_mode_init, mbm_config_rftype_init and
>>>> consolidate them into resctrl_file_fflags_init.
>>>
>>> This changelog has no context and only describes what the code does,
>>> which can be learned from reading the patch. Could you please
>>> update changelog with context and motivation for this change?
>> How about this?
>>
>> Consolidate multiple fflags initialization into one function.
>>
>> The functions thread_throttle_mode_init() and mbm_config_rftype_init()
>> both initialize fflags for resctrl files. This can be simplified into one
>> function passing the file name and flags to be initialized. It also helps
>> code simplification of new flags initialized for ABMC feature.
> 
> I am not sure what you intend here. Is this the entire intended changelog?
> I expected it to reflect x86 requirements as per
> Documentation/process/maintainer-tip.rst. Under "Changelog":
> 
> "It's also useful to structure the changelog into several paragraphs and not
> lump everything together into a single one. A good structure is to explain
> the context, the problem and the solution in separate paragraphs and this
> order."

I will try to elaborate this in next version.
Thanks
- Babu Moger