Received-SPF: pass (google.com: domain of linux-kernel+bounces-175255-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a67948c7-6268-4c25-990d-8946814c7c4e@kernel.org>
Date: Fri, 10 May 2024 11:36:54 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [f2fs-dev] [PATCH 2/3] f2fs: fix to add missing iput() in
 gc_data_segment()
From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
References: <20240506103313.773503-1-chao@kernel.org>
 <20240506103313.773503-2-chao@kernel.org> <Zjwc5QGJfm6XXzOX@google.com>
 <32e097e6-67f1-4f06-bad0-0c7b3afb46f0@kernel.org>
Content-Language: en-US
In-Reply-To: <32e097e6-67f1-4f06-bad0-0c7b3afb46f0@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2024/5/9 10:49, Chao Yu wrote:
> On 2024/5/9 8:46, Jaegeuk Kim wrote:
>> On 05/06, Chao Yu wrote:
>>> During gc_data_segment(), if inode state is abnormal, it missed to call
>>> iput(), fix it.
>>>
>>> Fixes: 132e3209789c ("f2fs: remove false alarm on iget failure during GC")

Oh, this line should be replaced w/ below one, let me revise the patch.

Fixes: b73e52824c89 ("f2fs: reposition unlock_new_inode to prevent accessing invalid inode").

Thanks,

>>> Fixes: 9056d6489f5a ("f2fs: fix to do sanity check on inode type during garbage collection")
>>> Signed-off-by: Chao Yu <chao@kernel.org>
>>> ---
>>>   fs/f2fs/gc.c | 9 +++++++--
>>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
>>> index 8852814dab7f..e86c7f01539a 100644
>>> --- a/fs/f2fs/gc.c
>>> +++ b/fs/f2fs/gc.c
>>> @@ -1554,10 +1554,15 @@ static int gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
>>>               int err;
>>>               inode = f2fs_iget(sb, dni.ino);
>>> -            if (IS_ERR(inode) || is_bad_inode(inode) ||
>>> -                    special_file(inode->i_mode))
>>> +            if (IS_ERR(inode))
>>>                   continue;
>>> +            if (is_bad_inode(inode) ||
>>> +                    special_file(inode->i_mode)) {
>>> +                iput(inode);
>>
>> iget_failed() called iput()?
> 
> It looks the bad inode was referenced in this context, it needs to be iput()ed
> here.
> 
> The bad inode was made in other thread, please check description in commit
> b73e52824c89 ("f2fs: reposition unlock_new_inode to prevent accessing invalid
> inode").
> 
> Thanks,
> 
>>
>>
>>> +                continue;
>>> +            }
>>> +
>>>               err = f2fs_gc_pinned_control(inode, gc_type, segno);
>>>               if (err == -EAGAIN) {
>>>                   iput(inode);
>>> -- 
>>> 2.40.1
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel