Received-SPF: pass (google.com: domain of linux-kernel+bounces-175307-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 10 May 2024 07:11:27 +0100
From: Mark Brown <broonie@kernel.org>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: andriy.shevchenko@linux.intel.com, lgirdwood@gmail.com, perex@perex.cz,
	pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	liam.r.girdwood@intel.com, bard.liao@intel.com,
	yung-chuan.liao@linux.intel.com, kevin-lu@ti.com,
	cameron.berkenpas@gmail.com, tiwai@suse.de, baojun.xu@ti.com,
	soyer@irl.hu, Baojun.Xu@fpt.com
Subject: Re: [PATCH v4 1/3] ALSA: ASoc/tas2781: Fix wrong loading calibrated
 data sequence
Message-ID: <Zj26j5CrWA9PZI3l@finisterre.sirena.org.uk>
References: <20240510034123.1181-1-shenghao-ding@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="IBGLJYrAp7PURpSa"
Content-Disposition: inline
In-Reply-To: <20240510034123.1181-1-shenghao-ding@ti.com>


--IBGLJYrAp7PURpSa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 10, 2024 at 11:41:19AM +0800, Shenghao Ding wrote:

> Calibrated data will be set to default after loading DSP config params,
> which will cause speaker protection work abnormally. Reload calibrated
> data after loading DSP config params.

This changelog...

> -#ifndef __TASDEVICE_DSP_H__
> -#define __TASDEVICE_DSP_H__
> +#ifndef __TAS2781_DSP_H__
> +#define __TAS2781_DSP_H__
> =20
>  #define MAIN_ALL_DEVICES			0x0d
>  #define MAIN_DEVICE_A				0x01
> @@ -180,7 +180,6 @@ void tasdevice_calbin_remove(void *context);
>  int tasdevice_select_tuningprm_cfg(void *context, int prm,
>  	int cfg_no, int rca_conf_no);
>  int tasdevice_prmg_load(void *context, int prm_no);
> -int tasdevice_prmg_calibdata_load(void *context, int prm_no);
>  void tasdevice_tuning_switch(void *context, int state);
>  int tas2781_load_calibration(void *context, char *file_name,
>  	unsigned short i);

=2E..doesn't seem to have much relationship with the change?

--IBGLJYrAp7PURpSa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY9uo4ACgkQJNaLcl1U
h9D4agf+I0bZ1B3cEZzcn8kwAbokayZK3bWdqamWTuNLb3Vcx2uhyC4/bvRK5qQn
J6hS0j9LlmPaTipkl0Y7ztNShtj4T1VRNBY9RN3zRg9WuGh6ruQNGjFZO5gLMlr6
pg6e0ZfZ1Ja76r2kTsr4VzmBuhuoaDSpemsDCbCHHj3ibiHVobR7k2T0YnBoOGyQ
je4perE+5AwpAYiUrQUJklo14YYepi+ofoALKisnmpHva6wKFeq6L3l3IacPFBvM
cmODN8eF+LcZWc9GEd7SRIkmW9esFWti/G84NItQC2V6v9JaIDG4APXcFYPAWn1N
9s0AEBIhbb8SzQnWR1ajUfJH6zQR3A==
=r0T+
-----END PGP SIGNATURE-----

--IBGLJYrAp7PURpSa--