Received-SPF: pass (google.com: domain of linux-kernel+bounces-175338-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 May 2024 08:39:41 +0200
Message-Id: <D15RBIV5HF6S.2FFLSGU60X1UB@fairphone.com>
Subject: Re: [RFT PATCH v2 01/48] drm/panel: raydium-rm692e5: Stop tracking
 prepared
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Douglas Anderson" <dianders@chromium.org>,
 <dri-devel@lists.freedesktop.org>, "Maxime Ripard" <mripard@kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>, "Chris Morgan"
 <macromorgan@hotmail.com>, "Yuran Pereira" <yuran.pereira@hotmail.com>,
 "Neil Armstrong" <neil.armstrong@linaro.org>, "Konrad Dybcio"
 <konrad.dybcio@linaro.org>, "Daniel Vetter" <daniel@ffwll.ch>, "David
 Airlie" <airlied@gmail.com>, "Jessica Zhang" <quic_jesszhan@quicinc.com>,
 "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>, "Sam Ravnborg"
 <sam@ravnborg.org>, "Thomas Zimmermann" <tzimmermann@suse.de>,
 <linux-kernel@vger.kernel.org>
References: <20240503213441.177109-1-dianders@chromium.org>
 <20240503143327.RFT.v2.1.I784238de4810658212a5786b219f128460562a37@changeid>
In-Reply-To: <20240503143327.RFT.v2.1.I784238de4810658212a5786b219f128460562a37@changeid>

On Fri May 3, 2024 at 11:32 PM CEST, Douglas Anderson wrote:
> As talked about in commit d2aacaf07395 ("drm/panel: Check for already
> prepared/enabled in drm_panel"), we want to remove needless code from
> panel drivers that was storing and double-checking the
> prepared/enabled state. Even if someone was relying on the
> double-check before, that double-check is now in the core and not
> needed in individual drivers.
>
> Cc: Luca Weiss <luca.weiss@fairphone.com>
> Cc: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Seems to match with the changes I did for another (generated) panel
driver I upstreamed - see also:
https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator/c=
ommit/74c104440dfd828aa94194fd279c0c505ab55854

Functionally also seems to be fine, I don't see any problems. Thanks!

Tested-by: Luca Weiss <luca.weiss@fairphone.com>

Regards
Luca

> ---
>
> Changes in v2:
> - New
>
>  drivers/gpu/drm/panel/panel-raydium-rm692e5.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-raydium-rm692e5.c b/drivers/gpu/=
drm/panel/panel-raydium-rm692e5.c
> index a613ba5b816c..21d97f6b8a2f 100644
> --- a/drivers/gpu/drm/panel/panel-raydium-rm692e5.c
> +++ b/drivers/gpu/drm/panel/panel-raydium-rm692e5.c
> @@ -23,7 +23,6 @@ struct rm692e5_panel {
>  	struct drm_dsc_config dsc;
>  	struct regulator_bulk_data supplies[3];
>  	struct gpio_desc *reset_gpio;
> -	bool prepared;
>  };
> =20
>  static inline struct rm692e5_panel *to_rm692e5_panel(struct drm_panel *p=
anel)
> @@ -171,9 +170,6 @@ static int rm692e5_prepare(struct drm_panel *panel)
>  	struct device *dev =3D &ctx->dsi->dev;
>  	int ret;
> =20
> -	if (ctx->prepared)
> -		return 0;
> -
>  	ret =3D regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies)=
;
>  	if (ret < 0) {
>  		dev_err(dev, "Failed to enable regulators: %d\n", ret);
> @@ -213,8 +209,6 @@ static int rm692e5_prepare(struct drm_panel *panel)
> =20
>  	mipi_dsi_generic_write_seq(ctx->dsi, 0xfe, 0x00);
> =20
> -	ctx->prepared =3D true;
> -
>  	return 0;
>  }
> =20
> @@ -222,13 +216,9 @@ static int rm692e5_unprepare(struct drm_panel *panel=
)
>  {
>  	struct rm692e5_panel *ctx =3D to_rm692e5_panel(panel);
> =20
> -	if (!ctx->prepared)
> -		return 0;
> -
>  	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
>  	regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
> =20
> -	ctx->prepared =3D false;
>  	return 0;
>  }
> =20