Received-SPF: pass (google.com: domain of linux-kernel+bounces-175388-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <5af0aeaf-c713-406d-9eed-ee24ce129b03@intel.com>
Date: Fri, 10 May 2024 09:12:46 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dma: fix DMA sync for drivers not calling dma_set_mask*()
To: Alexander Lobakin <aleksander.lobakin@intel.com>, Christoph Hellwig
	<hch@lst.de>
CC: Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>, Steven Price
	<steven.price@arm.com>, Robin Murphy <robin.murphy@arm.com>, Joerg Roedel
	<joro@8bytes.org>, Will Deacon <will@kernel.org>, "Rafael J. Wysocki"
	<rafael@kernel.org>, Magnus Karlsson <magnus.karlsson@intel.com>,
	<nex.sw.ncis.osdt.itp.upstreaming@intel.com>, <bpf@vger.kernel.org>,
	<netdev@vger.kernel.org>, <iommu@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
References: <20240509144616.938519-1-aleksander.lobakin@intel.com>
Content-Language: en-US
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20240509144616.938519-1-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHJFZnBWRDhEbXU1OVluNUdtUXJQQU41YWRPaDY0UFlVNWRKUjRmV3ZrMVk2?=
 =?utf-8?B?ZlFoYWtEQjZOK01WQ0hFNFhxZ3ZzaHpvVnAxYy91dkIxVWh5L3g5U2pOVVd6?=
 =?utf-8?B?Z1RRendiazF0Z3ErY2FQdTZzVEFwSnNtblVGeXZNSVY4dkVOWmVWRnNyc3pw?=
 =?utf-8?B?eFZVMmRzemZvQlhRNXpiUEhadnRzQ0R1NDBlQmIxZWROSkFqdDZrbnIwTnJZ?=
 =?utf-8?B?ZitkTjd4TnI0S0tIZkZlNDRLam5iTjl5MHdtbk5YS1JlSTFubVV6d3p0MllY?=
 =?utf-8?B?WCs1ZU5CbXRwMS9ENjdnajZyS3ZXMWxJZXJYOTZ3K0ZRUE9tWXN0S2l0Y2Na?=
 =?utf-8?B?eUhFS204Tm9FSXduMlBvUkZDeUM1MDN2UXlLMzNFN2F3TkFlZFFaMCtHWEU3?=
 =?utf-8?B?ZCtiajRHdVoxZjYzSlNZTldFdmh1a3J0MUpzbnhIaW9seS91U29WdDJ5NXJo?=
 =?utf-8?B?d1JnTElaSHFWZi8vdGRtSXhWc3RIb0Y0aUhLajVzQytKYnAzb0x0ZU5FZC9h?=
 =?utf-8?B?M0ZicXpHU0RMYUo0VXZFMy85YjA1MVJLNVBLSjJrN2FmT1RLU2FubHpUd0s5?=
 =?utf-8?B?WnZUYmVwRE9FcFEra0tzOXNhd3RYT2FNUXp5K2dMSXdscGl6d3ZCTC9vMkQw?=
 =?utf-8?B?OVBTV2RIbHR0WlZBUWkyR1ZvWUp4V3lGdVpueXVxaExZYTBIWk1pODY2dHo2?=
 =?utf-8?B?V1Q4dFNiRWNaclFJZjlTSjNDcUhHVnROZDZIbDRHZTMvbkZoRnA3dHB0d2h4?=
 =?utf-8?B?WEJPRDBkTEtxQUJXWEVnUlRZOGJmM1ZCS0NtTFVtOWVCejBGK2I2bTIrUGMv?=
 =?utf-8?B?U2ZKc3ZDTkdQUVVQSmNvL3ZFRCs0WHZBOGgrRGJpclhXb2xHR1k3MGVGMG1S?=
 =?utf-8?B?N0dIc0UxOThHN3NRTXpVOWEyM2IvaGtEdHFYWDlYSXhNeWlSZkg1WFd1Q2JR?=
 =?utf-8?B?Z1pka3NFRndtS0xpVWxMTmcwWU9FcFhjaU04djVUOFdkbGlPV2ZoTGtlOUZD?=
 =?utf-8?B?WU8wSUxSY2VUSklabTh5elBiR1VtTHJyUStIbUFPWmRiZ1d1MkxKQVBzTFZp?=
 =?utf-8?B?YzRGREQ3Ly8zSmF1dEptak82UjlLMHg2MHdRREk0R1J0bld0c3FTTjhKVjNY?=
 =?utf-8?B?TDUxY3dEd3lTQnFxRTcvb3F5Wi94NEh5UTVsb056alViSjBSMGpnSEtXQjNU?=
 =?utf-8?B?bE5QYW1XT1JZMHpkdzkzaEh2YUtYVnpYeEZRTEkveGx4NTJENllJNWNkKzhI?=
 =?utf-8?B?RlU5UjBLKy9lYXVRVnFIdFlmUDVyUVpFWElFRFpmRGlBMFhEZlluZlFtWmNi?=
 =?utf-8?B?S0dzVkNWQkpzcmxvQmJxVVE1ZFhUV2tkVFRrajJ0cy9TeWN3RHZOS2crK2Vk?=
 =?utf-8?B?U3VqTmY3ejVPUUhlVVQyMkFwZFM1OGRnZVM1NkZrK25pS0hJaU8rVTBZbndt?=
 =?utf-8?B?YzVNM2ZFcW9jZi8rUUVadkx2N1RFV0RNYTNoQVVoNWwrZ2xhcVZ2ZmdlTys4?=
 =?utf-8?B?dFh3N3pYTXVvdVI5QzVxakM1eGdvRFdRVzVnMDdEempJQTU2L3BENFhHRGZC?=
 =?utf-8?B?UWpFTDNOUi9Tc0tlc1ZudWxoc0IxSUJOK2liVmhlUnAvUjVnTC9tNFdibGRo?=
 =?utf-8?B?ZnRzWVAvZnhzbWZvOHk2M2lOZHd0anNvZi8xZTVqVjdiTXlQZU02WEtzVHFi?=
 =?utf-8?B?NE51cWlYbEJaSnZGREhPWFJkVUxoMy96TWlQUGhvck15VG1URXpXVE04ZWpU?=
 =?utf-8?B?MVJFd2JOWlRaRVV4dWFsWW5EK0xXTG50cUJtNlR3VlQ4RlpNOVVuWlpXZzJU?=
 =?utf-8?B?cEFHYm1hS3NVVUozaDVVTTlXMHlMdEFEM3FidVgxUmJibENkNGFJZm9obmdM?=
 =?utf-8?B?R2QvV09CYmpBYmNiWFFMZWlsNzkxUGZ0akwxT25VYm9sVlIrcUQrb0t4c0dI?=
 =?utf-8?B?ZEF2WkNvV0JCaEl2OVJDdHZnV01DM29tMTFDV1F2VjBOYk1qdWR5SWlKYW80?=
 =?utf-8?B?Njg2VE9GNHN0YTQzTW0yY2FnZ0NlbWVGRmF1MHFieVlTNW1ybm5rUmJOcjhk?=
 =?utf-8?B?aUlkZGlvNWRyUjFkOTJmbkVKaFI1UG83TTVYT0ZVdTlSVnNlbC9nb0FiNlZU?=
 =?utf-8?B?VDJUSmo0RVlaUzcyNjVseU5TcllNMlIwamE1WHhZUGtxcm1MOEMvMUdnNG54?=
 =?utf-8?B?Unc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a12c0b9a-1ed6-4155-1a36-08dc70c09be3
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 07:12:53.2507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7o0DN8YpdqdcK6k1GTipZ9P6ArMgEAt7NLjfeC2tbmmOmjFBRyvUuGvPDfUKrarbumjdLgkB8n5xX/ZoWstZfFwvZc89dHKmycQ+rjf3i5k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5065
X-OriginatorOrg: intel.com

On 5/9/24 16:46, Alexander Lobakin wrote:
> There are several reports that the DMA sync shortcut broke non-coherent
> devices.
> dev->dma_need_sync is false after the &device allocation and if a driver
> didn't call dma_set_mask*(), it will still be false even if the device
> is not DMA-coherent and thus needs synchronizing. Due to historical
> reasons, there's still a lot of drivers not calling it.
> Invert the boolean, so that the sync will be performed by default and
> the shortcut will be enabled only when calling dma_set_mask*().
> 
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Closes: https://lore.kernel.org/lkml/46160534-5003-4809-a408-6b3a3f4921e9@samsung.com
> Reported-by: Steven Price <steven.price@arm.com>
> Closes: https://lore.kernel.org/lkml/010686f5-3049-46a1-8230-7752a1b433ff@arm.com
> Fixes: 32ba8b823252 ("dma: avoid redundant calls for sync operations")
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
>   include/linux/device.h      |  4 ++--
>   include/linux/dma-map-ops.h |  4 ++--
>   include/linux/dma-mapping.h |  2 +-
>   kernel/dma/mapping.c        | 10 +++++-----
>   kernel/dma/swiotlb.c        |  2 +-
>   5 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/include/linux/device.h b/include/linux/device.h
> index ed95b829f05b..d4b50accff26 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -691,7 +691,7 @@ struct device_physical_location {
>    *		and optionall (if the coherent mask is large enough) also
>    *		for dma allocations.  This flag is managed by the dma ops
>    *		instance from ->dma_supported.
> - * @dma_need_sync: The device needs performing DMA sync operations.
> + * @dma_skip_sync: DMA sync operations can be skipped for coherent buffers.
>    *
>    * At the lowest level, every device in a Linux system is represented by an
>    * instance of struct device. The device structure contains the information
> @@ -805,7 +805,7 @@ struct device {
>   	bool			dma_ops_bypass : 1;
>   #endif
>   #ifdef CONFIG_DMA_NEED_SYNC
> -	bool			dma_need_sync:1;
> +	bool			dma_skip_sync:1;
>   #endif
>   };
>   

very good solution with inverting the flag,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

// ...