Received-SPF: pass (google.com: domain of linux-kernel+bounces-175413-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Thomas Gleixner <tglx@linutronix.de>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Mahesh Bandewar <maheshb@google.com>, Netdev <netdev@vger.kernel.org>,
 Linux <linux-kernel@vger.kernel.org>, David Miller <davem@davemloft.net>,
 Jakub Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>,
 Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>, Sagi
 Maimon <maimon.sagi@gmail.com>, Jonathan Corbet <corbet@lwn.net>, John
 Stultz <jstultz@google.com>, Mahesh Bandewar <mahesh@bandewar.net>
Subject: Re: [PATCHv4 net-next] ptp/ioctl: support MONOTONIC_RAW timestamps
 for PTP_SYS_OFFSET_EXTENDED
In-Reply-To: <Zj2dZJAfOdag-M1H@hoboy.vegasvil.org>
References: <20240502211047.2240237-1-maheshb@google.com>
 <ZjsDJ-adNCBQIbG1@hoboy.vegasvil.org> <87cypwpxbh.ffs@tglx>
 <Zj2dZJAfOdag-M1H@hoboy.vegasvil.org>
Date: Fri, 10 May 2024 09:50:07 +0200
Message-ID: <878r0inm1c.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Thu, May 09 2024 at 21:07, Richard Cochran wrote:

> Thomas,
>
> On Wed, May 08, 2024 at 09:38:58AM +0200, Thomas Gleixner wrote:
>> On Tue, May 07 2024 at 21:44, Richard Cochran wrote:
>> > On Thu, May 02, 2024 at 02:10:47PM -0700, Mahesh Bandewar wrote:
>> >> + * History:
>> >> + * v1: Initial implementation.
>> >> + *
>> >> + * v2: Use the first word of the reserved-field for @clockid. That's
>> >> + *     backward compatible since v1 expects all three reserved words
>> >> + *     (@rsv[3]) to be 0 while the clockid (first word in v2) for
>> >> + *     CLOCK_REALTIME is '0'.
>
> ..
>
>> I agree that it wants to be in the commit message, but having the
>> version information in the kernel-doc which describes the UAPI is
>> sensible and useful. That's where I'd look first and asking a user to
>> dig up this information on lore is not really helpful.
>
> But writing "v1, v2" doesn't make sense for this code.  There never
> was a "v1" for this ioctl.  At the very least, the change should be
> identified by kernel version (or git SHA).

Adding the git SHA before committing the change is going to be
challenging :)