Received-SPF: pass (google.com: domain of linux-kernel+bounces-175430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Justin Lai <justinlai0215@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "andrew@lunn.ch"
	<andrew@lunn.ch>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "horms@kernel.org"
	<horms@kernel.org>,
        Ping-Ke Shih <pkshih@realtek.com>,
        Larry Chiu
	<larry.chiu@realtek.com>
Subject: RE: [PATCH net-next v18 10/13] rtase: Implement ethtool function
Thread-Topic: [PATCH net-next v18 10/13] rtase: Implement ethtool function
Thread-Index: AQHaoUWgPXTTB14VD0aoQIyqdMTInbGPTwiAgADR5MA=
Date: Fri, 10 May 2024 08:12:28 +0000
Message-ID: <b5c86321761f4d24921b3a4a1f02c694@realtek.com>
References: <20240508123945.201524-1-justinlai0215@realtek.com>
	<20240508123945.201524-11-justinlai0215@realtek.com>
 <20240509204047.149e226e@kernel.org>
In-Reply-To: <20240509204047.149e226e@kernel.org>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

> On Wed, 8 May 2024 20:39:42 +0800 Justin Lai wrote:
> > +     data[0] =3D le64_to_cpu(counters->tx_packets);
> > +     data[1] =3D le64_to_cpu(counters->rx_packets);
> > +     data[2] =3D le64_to_cpu(counters->tx_errors);
> > +     data[3] =3D le32_to_cpu(counters->rx_errors);
> > +     data[4] =3D le16_to_cpu(counters->rx_missed);
> > +     data[5] =3D le16_to_cpu(counters->align_errors);
> > +     data[6] =3D le32_to_cpu(counters->tx_one_collision);
> > +     data[7] =3D le32_to_cpu(counters->tx_multi_collision);
> > +     data[8] =3D le64_to_cpu(counters->rx_unicast);
> > +     data[9] =3D le64_to_cpu(counters->rx_broadcast);
> > +     data[10] =3D le32_to_cpu(counters->rx_multicast);
> > +     data[11] =3D le16_to_cpu(counters->tx_aborted);
> > +     data[12] =3D le16_to_cpu(counters->tx_underun);
>=20
> Please limit stats you report in ethtool -S to just the stats for which p=
roper
> interfaces don't exist. Don't duplicate what's already reported via
> rtase_get_stats64(), also take a look at what can be reported via various
> *_stats members of struct ethtool_ops.

OK, I will check this part and modify it.