Received-SPF: pass (google.com: domain of linux-kernel+bounces-175459-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 10 May 2024 10:45:29 +0200
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
        Vasily
 Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle
 <svens@linux.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Gerald
 Schaefer <gerald.schaefer@linux.ibm.com>,
        Matthew Wilcox
 <willy@infradead.org>, Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH v2 10/10] s390/hugetlb: convert PG_arch_1 code to work
 on folio->flags
Message-ID: <20240510104529.26f68fd8@p-imbrenda>
In-Reply-To: <36c6bdd3-b010-4b58-b358-395462d8765b@redhat.com>
References: <20240412142120.220087-1-david@redhat.com>
	<20240412142120.220087-11-david@redhat.com>
	<20240507183307.3336dabc@p-imbrenda.boeblingen.de.ibm.com>
	<36c6bdd3-b010-4b58-b358-395462d8765b@redhat.com>
Organization: IBM
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 8 May 2024 20:08:07 +0200
David Hildenbrand <david@redhat.com> wrote:

> On 07.05.24 18:33, Claudio Imbrenda wrote:
> > On Fri, 12 Apr 2024 16:21:20 +0200
> > David Hildenbrand <david@redhat.com> wrote:
> >   
> >> Let's make it clearer that we are always working on folio flags and
> >> never page flags of tail pages.  
> > 
> > please be a little more verbose, and explain what you are doing (i.e.
> > converting usages of page flags to folio flags), not just why.
> >   
> >>
> >> Signed-off-by: David Hildenbrand <david@redhat.com>  
> > 
> > with a few extra words in the description:  
> 
>      Let's make it clearer that we are always working on folio flags and
>      never page flags of tail pages by converting remaining PG_arch_1 users
>      that modify page->flags to modify folio->flags instead.
>      
>      No functional change intended, because we would always have worked with
>      the head page (where page->flags corresponds to folio->flags) and never
>      with tail pages.

this works, thanks!

> 
> 
> > 
> > Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>  
> 
> Thanks for all the review!
>