Received-SPF: pass (google.com: domain of linux-kernel+bounces-175551-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <b288926e-f9d6-48d5-9851-078a6c9912bf@intel.com>
Date: Fri, 10 May 2024 12:55:54 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [Intel-wired-lan] [PATCH v2 2/2] e1000e: fix link fluctuations
 problem
To: Andrew Lunn <andrew@lunn.ch>, "Ruinskiy, Dima" <dima.ruinskiy@intel.com>
CC: Ricky Wu <en-wei.wu@canonical.com>, <netdev@vger.kernel.org>,
	<rickywu0421@gmail.com>, <linux-kernel@vger.kernel.org>,
	<edumazet@google.com>, <intel-wired-lan@lists.osuosl.org>, <kuba@kernel.org>,
	<anthony.l.nguyen@intel.com>, <pabeni@redhat.com>, <davem@davemloft.net>,
	"Lifshits, Vitaly" <vitaly.lifshits@intel.com>, naamax.meir
	<naamax.meir@linux.intel.com>, "Avivi, Amir" <amir.avivi@intel.com>, "Keller,
 Jacob E" <jacob.e.keller@intel.com>
References: <20240503101836.32755-1-en-wei.wu@canonical.com>
 <83a2c15e-12ef-4a33-a1f1-8801acb78724@lunn.ch>
 <514e990b-50c6-419b-96f2-09c3d04a2fda@intel.com>
 <334396b5-0acc-43f7-b046-30bcdab1b6fb@intel.com>
 <cc58ecfc-53f1-4154-bc38-e73964a59e16@lunn.ch>
Content-Language: en-US
From: Sasha Neftin <sasha.neftin@intel.com>
In-Reply-To: <cc58ecfc-53f1-4154-bc38-e73964a59e16@lunn.ch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVB3TW00MzFFRG5VdGJkdS9UNzBpdU1mTTlLSThvOVgrdXJVbGN3QUlzTzN3?=
 =?utf-8?B?WlZQU21kUXhEY2tqWU1YU2IwVTFvT3BuTDlWQ010eFNXQ3I2dDNEQWJpbHhP?=
 =?utf-8?B?R0k0Q21Nb0p0R3ljcnBWaG1KaEZrVjgzcHZ3eGFxSjFPQzJoOU1aOHFydVZp?=
 =?utf-8?B?TEN1dCtiZm1kMk5ZTVZvY3pLT0pxOHhqT0ZSaFpaQm9TeDJhRHdZUkJxTWVJ?=
 =?utf-8?B?bWhQS24yc3ZacDVwdGdQWFRQalh1UERMQnFhVEppc213ZEI3S3RYWnE2YjNH?=
 =?utf-8?B?dXhpQ0xaeHVVYjJpaStsNG4xaVJocS9xaE1FWk9kT0hlQTZLRjRQZkV4REpK?=
 =?utf-8?B?UVlFSFNtWjNvUVc4L05LNkgwYms4WXM3a3pCSjd1UTlCWW5DVTlWWjAybzdu?=
 =?utf-8?B?K2xTK01yL20zYjEvVTJycGwwY0xpQWJ1VFpJNHZiWitsVGdWL09qdE9zdmp6?=
 =?utf-8?B?TVVHbVJNMTd4S0dUWm8vQlR4QjI4T1M4TnVMa0FVRGlOOE5LUk05UlJOMTZz?=
 =?utf-8?B?NU8vOHlNTW13ZklTZjYvN3ZXT09WYXdtRTNkQmltZ0NOdTdzMkxYME9GOVV3?=
 =?utf-8?B?YjhYa09CZURsT3ZwSFR1UEtjZVRtY1pGS2FwL21yTVA1Q2hYS1o3aG5BbVBI?=
 =?utf-8?B?MndjR2lDaWJ6bDEvVmhIdjdVR0g4M21lNUhjZmpFeHUyMXlUR1JMTkxuaTZE?=
 =?utf-8?B?dU8zai9wWWZMUmh2dUtGTUVXM1dYRmZ4VVlHRFQzQi9ZZHhLVTRKdE12ZGF3?=
 =?utf-8?B?U3FkU2xLMTUrUXBjd1pkb1VydUlyWHlqZkZzOUY4V3ZJZ3NzcjVLbXRHQW9H?=
 =?utf-8?B?WGxGeUo4NDdSc09sc0RQUzBYc1pYYzhSb24xVGdCRWoxeGlJSnhkYTc0NThl?=
 =?utf-8?B?T21tajBJd2Ivckl1TVkzSWY2SWUrd0p5eUxJNU9MN3VwVHorNmV2NnZjVkZa?=
 =?utf-8?B?VDk3WDI5M003RHJYeElPcTRiNGdWeDNPTGF3L2RuTjNOVDhlMGd5Z1VFaW1y?=
 =?utf-8?B?UzNVM3ExVnZhL3RWZFBOd25OQlAwQlpWQ0psQStyZGFnT2piSkU1VzhoT1lq?=
 =?utf-8?B?OW1hV04zMVA2RDY5ZnhiMmlJblMvZ29mRHhFMDZvajkvQmpCZ3VJb1F3OGV0?=
 =?utf-8?B?Wm10Y1JMQlA1Sk9KZHZGanJYYjgxazl4ajNjdU9JaWpLQ1UyMElPblRsbVV6?=
 =?utf-8?B?UFVCU0MzT0RsdmY5ZWs5WEpneG9UQnNkSXJEZW95ZnRkMXVYeDl6RWw1QnZX?=
 =?utf-8?B?aTJaMDNFSDR0RVJucUJQYkcyOG10NVFzL3lEUWNIcFpBdVRGbU5PenJ5MTlI?=
 =?utf-8?B?MFdla0FLT3IyN0Q0ci9RWjd6SVZIanU2ZDFadzB6MVFqeEZETExzaWpjN0Ra?=
 =?utf-8?B?TnRTeEtVaXRJSzQraWx2WEllSUYyb2U4WmZpOGZiaWlhaktZR24yakwxdGpm?=
 =?utf-8?B?czY1cGloc2E4YklXTGgwY09naytMRVNNWnJpTkJkZUwzYVNtODZYcm9PRkRF?=
 =?utf-8?B?SU9PQUlTSHpCMXhWWWhQb1YyMUlhQk1mV3pBM2Q3d3Z5cCtxb3lKem5DOTVC?=
 =?utf-8?B?d1A1ZjZPd1FEUXVXemhmVTMwajhWVjg2eFJQRW5IMTNTOUI1SnFQRFRzQlZQ?=
 =?utf-8?B?N0tBT3dwQUIwSHpqNEFJTGgvak9xWExyUVQxeExvYytVZU8rOVlyWWYxYmc5?=
 =?utf-8?B?ano1SmlaV3Q5ajdvcGtzUTVPeE1iYm9QM0hQcThPSUhENGplaWcrMVQvN2Ni?=
 =?utf-8?B?NllhcmFaQmpKZ3BGc2dZTmU2ZVUzdWkvaFFrTmorUTJPWjY2VUw0LzU4RlYr?=
 =?utf-8?B?U0xWQ01OY2E2NFBDd2hkeGI4NW5HYnViNXdJRVpCRjdBem94M2ZvZVhTOFlu?=
 =?utf-8?B?Nm5wSGVkL1lVMGtUU2IyZDBxZ1VsNkFaRzFXVlRqcmpEbno5TWc0QjhGaUkx?=
 =?utf-8?B?aDhUYUdMMmlKR1N0a3JzWlExTFFuRC80YWtNaFFEL2NFN3BaNUVNSU9xVjUv?=
 =?utf-8?B?b2NHaEJ3Q0srOXdONENwQXJZY2ZGeGRVNmVDVFlkV2hzMGU0MEwybWl2cEx5?=
 =?utf-8?B?VElZMXpuTVJvSVNLZ1JRZFZ4NG1Wdk9ISFdCeDZIaTMyMFBEQVRwYk43TTdJ?=
 =?utf-8?Q?2LbWYimZQtbCYV3fCC6q5xk2d?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f1306bb-afbd-43eb-441c-08dc70d765bc
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6725.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 09:56:01.0203
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZabHkEC/Mv7MrNUbeMoBqUntinaP8p23BNM90Srv9qH36/k/am+Tte/iym9oCW1rXq67OGX3w3YXDBfVAhcF8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6533
X-OriginatorOrg: intel.com

On 09/05/2024 16:46, Andrew Lunn wrote:
> On Thu, May 09, 2024 at 12:13:27PM +0300, Ruinskiy, Dima wrote:
>> On 08/05/2024 8:05, Sasha Neftin wrote:
>>> On 07/05/2024 15:31, Andrew Lunn wrote:
>>>> On Fri, May 03, 2024 at 06:18:36PM +0800, Ricky Wu wrote:
>>>>> As described in https://bugzilla.kernel.org/show_bug.cgi?id=218642,
>>>>> Intel I219-LM reports link up -> link down -> link up after hot-plugging
>>>>> the Ethernet cable.
>>>>
>>>> Please could you quote some parts of 802.3 which state this is a
>>>> problem. How is this breaking the standard.
>>>>
>>>>      Andrew
>>>
>>> In I219-* parts used LSI PHY. This PHY is compliant with the 802.3 IEEE
>>> standard if I recall correctly. Auto-negotiation and link establishment
>>> are processed following the IEEE standard and could vary from platform
>>> to platform but are not violent to the IEEE standard.
>>>
>>> En-Wei, My recommendation is not to accept these patches. If you think
>>> there is a HW/PHY problem - open a ticket on Intel PAE.
>>>
>>> Sasha
>>
>> I concur. I am wary of changing the behavior of some driver fundamentals, to
>> satisfy a particular validation/certification flow, if there is no real
>> functionality problem. It can open a big Pandora box.
>>
>> Checking the Bugzilla report again, I am not sure we understand the issue
>> fully:
>>
>> [  143.141006] e1000e 0000:00:1f.6 enp0s31f6: NIC Link is Up 1000 Mbps Half
>> Duplex, Flow Control: None
>> [  143.144878] e1000e 0000:00:1f.6 enp0s31f6: NIC Link is Down
>> [  146.838980] e1000e 0000:00:1f.6 enp0s31f6: NIC Link is Up 1000 Mbps Full
>> Duplex, Flow Control: None
>>
>> This looks like a very quick link "flap", following by proper link
>> establishment ~3.7 seconds later. These ~3.7 seconds are in line of what
>> link auto-negotiation would take (auto-negotiation is the default mode for
>> this driver).
> 
> That actually seems slow. It is normally a little over 1 second. I
> forget the exact number. But is the PHY being polled once a second,
> rather than being interrupt driven?
> 
>> The first print (1000 Mbps Half Duplex) actually makes no
>> sense - it cannot be real link status since 1000/Half is not a supported
>> speed.
> 
> It would be interesting to see what the link partner sees. What does
> it think the I219-LM is advertising? Is it advertising 1000BaseT_Half?

i219 parts come with LSI PHY. 1000BASE-T half-duplex is not supported. 
1000BASET half-duplex not advertised in IEEE 1000BASE-T Control Register 9.

> But why would auto-neg resolve to that if 1000BaseT_Full is available?
> 
>> So it seems to me that actually the first "link up" is an
>> incorrect/incomplete/premature reading, not the "link down".
> 
> Agreed. Root cause this, which looks like a real problem, rather than
> apply a band-aid for a test system.
> 
>        Andrew