Received-SPF: pass (google.com: domain of linux-kernel+bounces-175583-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <3938d7a7-17d0-4da6-b811-23f0eed546c3@linaro.org>
Date: Fri, 10 May 2024 11:16:44 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] soc: qcom: pmic_glink: Handle the return value of
 pmic_glink_init
To: Chen Ni <nichen@iscas.ac.cn>, andersson@kernel.org,
 konrad.dybcio@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240510083156.1996783-1-nichen@iscas.ac.cn>
Content-Language: en-US
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
In-Reply-To: <20240510083156.1996783-1-nichen@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/05/2024 09:31, Chen Ni wrote:
> As platform_driver_register() and register_rpmsg_driver() can return
> error numbers, it should be better to check the return value and deal
> with the exception.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   drivers/soc/qcom/pmic_glink.c | 13 +++++++++++--
>   1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c
> index 40fb09d69014..8534a9692c45 100644
> --- a/drivers/soc/qcom/pmic_glink.c
> +++ b/drivers/soc/qcom/pmic_glink.c
> @@ -369,8 +369,17 @@ static struct platform_driver pmic_glink_driver = {
>   
>   static int pmic_glink_init(void)
>   {
> -	platform_driver_register(&pmic_glink_driver);
> -	register_rpmsg_driver(&pmic_glink_rpmsg_driver);
> +	int ret;
> +
> +	ret = platform_driver_register(&pmic_glink_driver);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = register_rpmsg_driver(&pmic_glink_rpmsg_driver);
> +	if (ret < 0) {
> +		platform_driver_unregister(&pmic_glink_driver);
> +		return ret;
> +	}
>   
>   	return 0;
>   }

Please add a Fixes tag

Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK 
driver")

Then add

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

---
bod