Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp398677lqo; Fri, 10 May 2024 03:25:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUvqGzJEMvrOqnZufH5PJ5GtiUfHIqakz0N1H63oSZ+NM0lqh3BBFPNvoM0oGCRDS3KX0BPMZPxH5C76zRrgWqBRvLxvVhnkAvXXjhfSw== X-Google-Smtp-Source: AGHT+IEwkdhZpGR+FJgnyLKdSQ2DEBOFUSu3vl6Dkd/139nwwTqjdoKUUueGIGr9GRZyzK1ydKxC X-Received: by 2002:a17:906:f296:b0:a59:cfab:50e with SMTP id a640c23a62f3a-a5a2d55a8bamr171892466b.16.1715336729061; Fri, 10 May 2024 03:25:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715336729; cv=pass; d=google.com; s=arc-20160816; b=kMTRMGIkIwcF3iUcWTH5KMDBaAu8geeCLp1yQUhq2eCPMgTRmqpzx2FDwb/KuVtbZ+ rRz+IfX/V5yxk3SzAvF6fWuiTrnBK39ClvhC6GtuCk5QGZ9bGp9pCTw/FbDo3Kml6N8/ oZHHfFu2jKtrweb6cIS0kgYY+EV71pt+z8sGPCgR7ad1OhNQlR/1Sw4KGAVEeXCPzKbx crOSF1UmdxYrZqrEXrpp3y2/0MUxivqfo7zGqjzg2fTg6V50lu7XCPWezLapZ2VPxIiz IRy70Ic5400mDjVXkpRHeLbHXZ20yb+IWHTMUp8u6BqfmOLRL2/MlerihhgQIVTPKClJ OjZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:cc:to:from:date:references:in-reply-to:message-id :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:feedback-id:dkim-signature:dkim-signature; bh=RV16UsPZ7kHshFR9q+mGzDhSzK0T5+eVMIdSnuqNlDU=; fh=JCnMmtm/chcxFJzJcW60ESnBa57K76San1fom/fKcig=; b=FVa0AALW1THHZMD3T3VMyh+a4w0h3DAa3syHL/9prgBxgfkkGQ3x6TPV9V7rBeluEZ 27oN42ztFM2sJSJsm9HQK5nvJakdmU77I8ZJuP5gdMFzEj3tijaXc8Txo7THiPFAnlYa VO1q++qJ5H5DGBrypskyxcFXC44wHfQBnCJRngnjgi3XRn0b237XRQ3f8VhdGp0oJxvC zeGX84Mt0+x3ZXZhsYKTtjpum9JHABxhl1L2Q0dYpg2L+ZVySBM+UPJ246/6zt+rkION HtdEwJn3yEXw3S/PhFD2wFwF73SQOVfytEJzbKY1r5DrXUY7ApnKSmg6cvGdfU0FRk0m A69A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm3 header.b=SLY6F6B2; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=AZhLmQsf; arc=pass (i=1 spf=pass spfdomain=arndb.de dkim=pass dkdomain=arndb.de dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=arndb.de); spf=pass (google.com: domain of linux-kernel+bounces-175590-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175590-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17bfc555si186018366b.870.2024.05.10.03.25.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 03:25:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-175590-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm3 header.b=SLY6F6B2; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=AZhLmQsf; arc=pass (i=1 spf=pass spfdomain=arndb.de dkim=pass dkdomain=arndb.de dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=arndb.de); spf=pass (google.com: domain of linux-kernel+bounces-175590-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175590-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C83951F22384 for ; Fri, 10 May 2024 10:25:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5637A165FD1; Fri, 10 May 2024 10:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="SLY6F6B2"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="AZhLmQsf" Received: from fout5-smtp.messagingengine.com (fout5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C4C168AEC; Fri, 10 May 2024 10:24:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715336700; cv=none; b=Cw+VfREQPUzK+AXrRgZZDZyFqiHd/2oPtxLFD6FDRVNmpNRHP6AyUL5vJc0SZNbh3+zvEh+AHRfF8ZLcSTd+kTsg9kq/yssn2swi5gFQSdWRVej9T65QmOUsQ96v7BFi/kMAjYFY8lsEY7EjMf+g/AoYUwFlIi6xjyPuVS7i8R4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715336700; c=relaxed/simple; bh=Hl6kXvzdVfgBxSqvB2M7xmg83KYSmqfYFk93FT/AylA=; h=MIME-Version:Message-Id:In-Reply-To:References:Date:From:To:Cc: Subject:Content-Type; b=Apt5kaKBIRfYLTKjbHgMOQbtVsj46Lll7tRg4tRepeupPfLx/e8t/q2yL+cmIITXGm+E88+CVTCCuHCSYKjWXJ/NR9a4WXJz5UnXNGnNLVrg9t4h1Vcx566oqSAfBjDSOZ3Y9b29q78LtheFwD3HHB2zSFY+y6K0jXVNlw1kvA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=SLY6F6B2; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=AZhLmQsf; arc=none smtp.client-ip=103.168.172.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 7EC2F13823D7; Fri, 10 May 2024 06:24:57 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Fri, 10 May 2024 06:24:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1715336697; x=1715423097; bh=RV16UsPZ7k HshFR9q+mGzDhSzK0T5+eVMIdSnuqNlDU=; b=SLY6F6B2eaidYessQIvxF2HLgB s5090Pe5YP0hfdfqS7mU4pD4KRf+UJmfuGvKw2mvDarEa+r6MW3ep4N+DN5/FRLY TsPIh648rVXqnVqS+gnqVVyDObNseJ+DOKfMPdMqlXp0u8pxZKPEVi/uRSIOgwYt mBMT77GaRYkeOjSIp4biyAiC2sIfUPzbBvKU390EIK25fc9PXb0Adzy9jy7YSvGa YtejdqijxrzC6Jx6PQMsB0jaiSBfBnPjhQ8YZchnmui0vJP3hke0HjVxA5BTI+jH HbBy/J6nSAUjSIJyRXKAhT66t37U97M+itVI4jiMOmgc3Ma+Zw/zNx5S8JNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1715336697; x=1715423097; bh=RV16UsPZ7kHshFR9q+mGzDhSzK0T 5+eVMIdSnuqNlDU=; b=AZhLmQsfDQlx2APbhbWtRxGvWE4UNrkDsaqZkx60eMBM g9xiKjc+F1veqBdQKO7Anf/2sale2wTw/GxFTlYyJ2Znw3JKqKR21UPbz+YAJanD yQJmIduuegPtg+c71XvS1qFYyR3mmlnTYsyWOuokqVwbYmshZcy5zuWfPdBOmxkR gxt+pcKCNmT+D5nT9/nVBDI2aD8GuVxLyiCTQ8I6NTa4349Etbpw7uuTcTi19wP0 69BYC34wXcVDcQni/kR4BD36iHkR/9zCatefEE6oR3oGcRF59iWdDjlEzRiveQu3 h/+FXvQXR86jyauFVzlCohImXL8OatFQFSbTznSDYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdefkedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B6FC3B60092; Fri, 10 May 2024 06:24:56 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-443-g0dc955c2a-fm-20240507.001-g0dc955c2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: In-Reply-To: <2024051039-decree-shrimp-45c6@gregkh> References: <20240510-hotplug-drm-bridge-v2-0-ec32f2c66d56@bootlin.com> <20240510-hotplug-drm-bridge-v2-5-ec32f2c66d56@bootlin.com> <2024051039-decree-shrimp-45c6@gregkh> Date: Fri, 10 May 2024 12:24:06 +0200 From: "Arnd Bergmann" To: "Greg Kroah-Hartman" , "Luca Ceresoli" Cc: "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "laurent.pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Dave Airlie" , "Daniel Vetter" , "derek.kiernan@amd.com" , "dragan.cvetic@amd.com" , "Saravana Kannan" , "Paul Kocialkowski" , "Herve Codina" , "Thomas Petazzoni" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Paul Kocialkowski" Subject: Re: [PATCH v2 5/5] misc: add ge-addon-connector driver Content-Type: text/plain On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote: > On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote: >> >> +config GE_SUNH_CONNECTOR >> + tristate "GE SUNH hotplug add-on connector" >> + depends on OF >> + select OF_OVERLAY >> + select FW_LOADER >> + select NVMEM >> + select DRM_HOTPLUG_BRIDGE > > Can these be depends instead of select? 'select' causes dependencies > that are hard, if not almost impossible, to detect at times why > something is being enabled. I think FW_LOADER needs to be 'select' since it is normally a hidden symbol and gets selected by its users, all the other ones should be 'depends on'. Arnd