Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp405239lqo; Fri, 10 May 2024 03:41:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXCmFOSpBLmtGwckvwVJxLwuHH7C0clBMpCsHastQZChlpUIPrbaRJiCqJTOSfktFuUInE3LGDDXn+eesF/U6MGJkQyyy3JfEj5XgOPKg== X-Google-Smtp-Source: AGHT+IHd9fLMlVzKd8/xKMqoR8GxFXDKKkBoWaP/lp2wRNYfFqE2E4h60D/jNl6dI1kzFsKxw28k X-Received: by 2002:ac8:5fd6:0:b0:43c:7d29:3f9c with SMTP id d75a77b69052e-43dec2975dfmr91238141cf.25.1715337660079; Fri, 10 May 2024 03:41:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715337660; cv=pass; d=google.com; s=arc-20160816; b=IDTd//Fmr9uOHf8jc4SAgiIEXlboiKrTI+46AyQrk6G+ifuYEUz7gGJGtxTpmjcNZa rfCd+sCkzJXKtG5KqAF/IpDh6Vij9+oq96h374mSQYu0HzWX15dc3zZfcGtd3rH3wZ1+ a/5krkK5ZEo7BYK3p7nbsOnMi4BgVggJOlV1Rc/aZYSqsl2PpiYzdjvNhO+RPReMuSQf PtocsmMgRcDyj0TnUYiYr60YpqXZ+A05SnvEP97q5yLVrdCputpARWOzB7qfmnzN1yoZ OODR1pbpbrY3Ma0Eg6JtnFa4QtLElLd5gAqVoQ28h3KGxuiSnJHeVnj2O/TL6n4gW0Xm QPeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wMZuHNxRQ1suG3JAK+RcMQPpAT4dzMSqsh91R2I2sUc=; fh=UuzE+NXgAoP49wHD0bLr679aiMHAFmvokmvFeq8zL7w=; b=f/CNC9RH/+NGeDFb+VzIcZ2a8OaulrGE2HmM3EXrcoTup6ZIixHioPV0s+bmgHMTg1 3qTrbgBOGhf//fsPnTVK1Rsd76LmRcI44izudKyeWbwbF8dAuLAG7C9GOikzqoGN6x0w iSgfZzqXKJBOvlGMx3e57VAEb+pdZM55iZRxTvH3tS4bHl1wQPfVYAtZEcE4Izp5J3wY BmaoO2R1tK7RK/qEYeloUJCRggKOAr76zqXNshBa98baN02ZTGGDsgPdTpGlGmmU1t0W v5bWgLY53Z1gosEEb3VA2/SH3B2WBl9U0uxFXQ75zDOOp6N/t4eCJqeVD6/GSkTN6odh F04Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Qrtjd92q; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-175602-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175602-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-43df56ab837si33545391cf.514.2024.05.10.03.40.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 03:41:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-175602-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Qrtjd92q; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-175602-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175602-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CE8A91C20CAD for ; Fri, 10 May 2024 10:40:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89606168AF6; Fri, 10 May 2024 10:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Qrtjd92q" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84D6780BF8; Fri, 10 May 2024 10:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715337653; cv=none; b=noBlxirLYWH2XQOQSR7zvTbGN8ap5A6cTz3WYkwvjYmSiuFvZ4v7hsBGWq312f8qESfC//GH3i+HapJNsNEZIhuAzR8vf6T8cI1wfZ/MOXFcNaa3/JPYRlt6JeH8CCaYN+CWErGL6BFOd4L5INQA3Yese+4oPwMzWcoB2ARacxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715337653; c=relaxed/simple; bh=wMZuHNxRQ1suG3JAK+RcMQPpAT4dzMSqsh91R2I2sUc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=stliVhRhI8jjItFRY7qdyq1wVE0hb9484BymUaNnOL68vOnghYdG5Epe7dCvdAVm2zOJxcEQe4xh+wrjHiC06IvS7i7H8YjJOUPi+xX+ZdAV4W2YE7X4l3WjMAd43qrw2fQpSCs/Hy1OX8EIunoTD/iAS+JCeekb6/uVg8s+GDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Qrtjd92q; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70C12C113CC; Fri, 10 May 2024 10:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715337653; bh=wMZuHNxRQ1suG3JAK+RcMQPpAT4dzMSqsh91R2I2sUc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qrtjd92q4b82+6m7iyitDshVzxSqnRhOlZXdBaAE1CMjHKxvbzYsGdtSkZKahjC8n oZ+KWftBz98c9FAXo4qvnJoKJYKqRcO5ZYP2hB6b9WqZx90BD8GzjbncCKgRyC0smR DfRGewBFt+iAWWMrRAscTASQZtLqQ/GWVuYetdlk= Date: Fri, 10 May 2024 11:40:33 +0100 From: Greg Kroah-Hartman To: Justin Stitt Cc: Jiri Slaby , Nathan Chancellor , Bill Wendling , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] tty: vt: saturate scrollback_delta to avoid overflow Message-ID: <2024051039-bankable-liking-e836@gregkh> References: <20240506-b4-sio-scrollback-delta-v1-1-4164d162a2b8@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240506-b4-sio-scrollback-delta-v1-1-4164d162a2b8@google.com> On Mon, May 06, 2024 at 06:55:19PM +0000, Justin Stitt wrote: > Using the signed overflow sanitizer with syzkaller produces this UBSAN > report: I think you might want to hold off on these until the discussion on the hardening list about overflows all settles down to a solid resolution. Right now these all seem to be a mess and perhaps you will have a better set of primitives to work with once that thread is finished. thanks, greg k-h