Received-SPF: pass (google.com: domain of linux-kernel+bounces-175664-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <a4586446-2318-4220-8610-0d5a99e0ad6c@I-love.SAKURA.ne.jp>
Date: Fri, 10 May 2024 20:25:22 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH (REPOST)] profiling: initialize prof_cpu_mask from
 profile_online_cpu()
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@redhat.com>,
        akpm@linux-foundation.org
Cc: tglx@linutronix.de, paskripkin@gmail.com, rostedt@goodmis.org,
        glider@google.com, ebiederm@xmission.com, linux-kernel@vger.kernel.org,
        syzkaller-bugs@googlegroups.com,
        syzbot <syzbot+b1a83ab2a9eb9321fbdd@syzkaller.appspotmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>
References: <000000000000d6b55e060d6bc390@google.com>
 <7227c8d1-08f6-4f95-ad0f-d5c3e47d874d@I-love.SAKURA.ne.jp>
 <85edf211-aa30-4671-93e0-5173b3f7adf2@I-love.SAKURA.ne.jp>
 <239eadaf-d694-4dff-89b9-b476be35f4e9@I-love.SAKURA.ne.jp>
 <60011cc3-b9fc-49c8-b0c0-35aafe46f313@I-love.SAKURA.ne.jp>
Content-Language: en-US
In-Reply-To: <60011cc3-b9fc-49c8-b0c0-35aafe46f313@I-love.SAKURA.ne.jp>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2024/05/05 15:18, Tetsuo Handa wrote:
> On 2024/04/27 15:51, Tetsuo Handa wrote:
>> Can somebody test this patch? I don't know how not using
>> cpu_possible_mask affects expected profile data collection
>> (especially when written to /sys/kernel/profiling interface
>> when some of CPUs are offline).
> 
> I confirmed that writing to /sys/kernel/profiling while some of
> /sys/devices/system/cpu/cpu$num/online are 0 will not affect profile data
> collection, for profile_online_cpu() is called (and corresponding bit is set)
> when /sys/devices/system/cpu/cpu$num/online becomes 1. Thus, I consider that
> this patch itself is correct and safe.

Can someone take this patch and
https://lkml.kernel.org/r/20230423012744.24320-1-chenzhongjin@huawei.com ?
These bugs remain unfixed due to lack of someone who can take patches...