Received-SPF: pass (google.com: domain of linux-kernel+bounces-175684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 10 May 2024 12:30:53 +0100
From: Simon Horman <horms@kernel.org>
To: =?utf-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= <ast@fiberby.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Manish Chopra <manishc@marvell.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net-next v2 13/14] net: qede: propagate extack through
 qede_flow_spec_validate()
Message-ID: <20240510113053.GP2347895@kernel.org>
References: <20240508143404.95901-1-ast@fiberby.net>
 <20240508143404.95901-14-ast@fiberby.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240508143404.95901-14-ast@fiberby.net>

On Wed, May 08, 2024 at 02:34:01PM +0000, Asbjørn Sloth Tønnesen wrote:
> Pass extack to qede_flow_spec_validate() when called in
> qede_flow_spec_to_rule().
> 
> Pass extack to qede_parse_actions().
> 
> Not converting qede_flow_spec_validate() to use extack for
> errors, as it's only called from qede_flow_spec_to_rule(),
> where extack is faked into a DP_NOTICE anyway, so opting to
> keep DP_VERBOSE/DP_NOTICE usage.
> 
> Only compile tested.
> 
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>

Reviewed-by: Simon Horman <horms@kernel.org>