Received-SPF: pass (google.com: domain of linux-kernel+bounces-175681-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 10 May 2024 12:29:54 +0100
From: Simon Horman <horms@kernel.org>
To: =?utf-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= <ast@fiberby.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Manish Chopra <manishc@marvell.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net-next v2 11/14] net: qede: use extack in
 qede_parse_flow_attr()
Message-ID: <20240510112954.GN2347895@kernel.org>
References: <20240508143404.95901-1-ast@fiberby.net>
 <20240508143404.95901-12-ast@fiberby.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240508143404.95901-12-ast@fiberby.net>

On Wed, May 08, 2024 at 02:33:59PM +0000, Asbjørn Sloth Tønnesen wrote:
> Convert qede_parse_flow_attr() to take extack,
> and drop the edev argument.
> 
> Convert DP_NOTICE calls to use NL_SET_ERR_MSG_* instead.
> 
> Pass extack in calls to qede_flow_parse_{tcp,udp}_v{4,6}().
> 
> In calls to qede_parse_flow_attr(), if extack is
> unavailable, then use NULL for now, until a
> subsequent patch makes extack available.
> 
> Only compile tested.
> 
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>

Reviewed-by: Simon Horman <horms@kernel.org>