Received-SPF: pass (google.com: domain of linux-kernel+bounces-175698-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <1586576.1715341405@warthog.procyon.org.uk>
References: <1586576.1715341405@warthog.procyon.org.uk>
Cc: dhowells@redhat.com, Max Kellermann <max.kellermann@ionos.com>,
    Jan Kara <jack@suse.com>, Miklos Szeredi <miklos@szeredi.hu>,
    Christian Brauner <brauner@kernel.org>, linux-ext4@vger.kernel.org,
    linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ext4: Don't reduce symlink i_mode by umask if no ACL support
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1586840.1715341572.1@warthog.procyon.org.uk>
Date: Fri, 10 May 2024 12:46:12 +0100
Message-ID: <1586841.1715341572@warthog.procyon.org.uk>

David Howells <dhowells@redhat.com> wrote:

> -	inode->i_mode &= ~current_umask();
> +	if (!S_ISLNK(inode->i_mode))
> +		inode->i_mode &= ~current_umask();

Meh.  I forgot to commit the change.  Will resend.

David