Received-SPF: pass (google.com: domain of linux-kernel+bounces-175764-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240509064336.9803-1-lvzhaoxiong@huaqin.corp-partner.google.com>
 <20240509064336.9803-2-lvzhaoxiong@huaqin.corp-partner.google.com> <CAD=FV=Ugm+-ziY+8f93KOChvmkbf_MdxEOoyJP5WJq70m-aOGQ@mail.gmail.com>
In-Reply-To: <CAD=FV=Ugm+-ziY+8f93KOChvmkbf_MdxEOoyJP5WJq70m-aOGQ@mail.gmail.com>
From: zhaoxiong lv <lvzhaoxiong@huaqin.corp-partner.google.com>
Date: Fri, 10 May 2024 20:07:39 +0800
Message-ID: <CA+6=WdT=eoh+qc=O+YzxmugotZvkfcdXxiK4S9Mg++6EtR8vkg@mail.gmail.com>
Subject: Re: [PATCH v1 2/2] HID: i2c-hid: elan: Add ili2900 timing
To: Doug Anderson <dianders@google.com>
Cc: dmitry.torokhov@gmail.com, robh@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jikos@kernel.org, 
	benjamin.tissoires@redhat.co, hsinyi@google.com, 
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

hi Doug

Sorry, This patch was accidentally sent when sending other patches.
Please ignore this patch.

>  Also: other than the main power supply, there is no difference between

> this and the ili2901. If you actually do have a main power supply,
> then you probably don't need a new table. You probably don't even need
> your own compatible string and in the device tree you could just
> specify:

> compatible =3D "ilitek,ili2900, "ilitek,ili2901";

> ...which says "I actually have an ILI 2900, but if you don't have any
> special driver for the ILI 2900 it's likely that the driver for the
> ILI 2901 will work because the hardware is almost the same."

In addition, in the previous patch, we have made modifications based
on your suggestions. "ilitek ili2900" and "ilitek ili2901" use the
same driver. Upstream may not be needed in the future. Thank you for
your previous suggestions.
[1] https://lore.kernel.org/r/CAD=3DFV=3DX5tk0tCcDa+vLnu0aoas1TDWuqvkMzM-27=
8dOCX8K1gw@mail.gmail.com


On Thu, May 9, 2024 at 10:35=E2=80=AFPM Doug Anderson <dianders@google.com>=
 wrote:
>
> Hi,
>
> On Wed, May 8, 2024 at 11:43=E2=80=AFPM Zhaoxiong Lv
> <lvzhaoxiong@huaqin.corp-partner.google.com> wrote:
> >
> > From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com>
> >
> > ILI2900 requires reset to pull down time greater than 10ms,
> > so the configuration post_power_delay_ms is 10, and the chipset
> > initial time is required to be greater than 100ms,
> > so the post_gpio_reset_on_delay_ms is set to 100.
> >
> > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com>
> > ---
> >  drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
>
> You silently ignored pretty much all of the feedback from the previous
> version [1], so I'm not planning to review this version.
>
> [1] https://lore.kernel.org/r/CAD=3DFV=3DX5tk0tCcDa+vLnu0aoas1TDWuqvkMzM-=
278dOCX8K1gw@mail.gmail.com