Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp460518lqo; Fri, 10 May 2024 05:29:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCViVY47YUz07TILVPZTh0HL6Ar/2RlwkucgZnxZElFriFIddubN7w+ax5iBNf86gstH48Gazs3TQreIQIU3GQzr5RF2c8s6kwmPfiMCiQ== X-Google-Smtp-Source: AGHT+IETcKXyCqsXcPPmMZJcxu57s2HJT0wJzJJ27iuSj906p+VICPreQT3kJxi1XjcepYAIvSCJ X-Received: by 2002:a17:906:3ad2:b0:a58:ca9d:7b6b with SMTP id a640c23a62f3a-a5a2d6653e9mr146084166b.60.1715344184463; Fri, 10 May 2024 05:29:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715344184; cv=pass; d=google.com; s=arc-20160816; b=Qfa2liFt2uBhCEH6p3yt+J+p46ayKtyT35GzrosFIae3SsMaDEzbesKothTc1zsXmH rChRfp0kq/IalRrTpec6Pp9gAJP+dpfgTU7a+LrcJt+DVZfSrT4KON7tbsUmsIGzaZq1 fZJQFmVhwqQQclYPWRuCwNurQQ+eH00VfeBNSYbu7Bf4eh1aYBNJ/1fhdkNXmKuVj3kw Y8x1ZKdpLum0BvbOf/jKN74FQ99K5dyNAoa4G0XBCQ6FE62kqJ8+PyQAjcOjHu0i8T9D EeEJ9TMwBgJSUkrNMBbrOJCjBsBrIcsPBcYYiN4hWjtwTqwlTuNR4JxbJTtvBU4680lT vYyA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LWdlmT5BJ48dTfdd8hzGp3/xV5sk6wJWM18S0QaMXtY=; fh=HhuIivL3HM8mdooAtgAGj3ulc7r1udiQ2G8KItzwPD8=; b=0pqzIV8Sbqc2qIPEy58B5RxgxLdsaVapnYcdO/SDg3Sl4WTgRh3MnYL0QfLFzyP5FF qhO1TbPLDzzsS513ddM7OTetAvBhvSOPCxo+TC14JGmBWBveWTNfuWG44jWr69fUslbT UhXDa6wpzYBXKVz9yN/WcWTkSvl55srRP+wCtdp+L6P4GyA/jXvY9XC1bwlCLmXc6W6e 6SA9uxyLipzZ9MQYxGxcYbQMGT3urDTr0UYRP7NJKvmo5By4T9oZGY3k1jTQaOLXGNKO iBFFPbKGpojCBsfISjRLxRd+Z4cbnxqa7Z2+0SUlmYFzHSmSky91QrT1QL0jbdptzcG0 wZPg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EMv8z6SJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-175779-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175779-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a1794634asi198331666b.166.2024.05.10.05.29.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 05:29:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-175779-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EMv8z6SJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-175779-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175779-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 333591F256CA for ; Fri, 10 May 2024 12:29:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F5D416DED7; Fri, 10 May 2024 12:29:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EMv8z6SJ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A521F487BC; Fri, 10 May 2024 12:29:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715344174; cv=none; b=OffNrJEfCIbS1sudWCfwh1Wq0jkJC7vtYsN1KUzVrd4G6rE1rlkkYO5Tmdf2Jox559GXImw2nh0uGpngL9H9lLeywRm3ilt/gz9gr0qmitFIa9kkz67jJz/F9PXdJHroKvlQ3cYoZP5AjTwm/rqqu9jVnfYyf25w0GEsGS3/xBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715344174; c=relaxed/simple; bh=KLTEQaQm0FiKrFX+yiOF9TjuFZuP1CHAkj/bzBphg3M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eVzDGq8/dF4oaFkzthWiAneEn2SP8UZ5edGoo4of34hvoEynFEuhLwsWquiMnjFgsFpAcRzPUNdPeMPEUoHt/Z3mjgLDnLJ0IV44zZdemQb8cfuLmi6rAWQDt9eqWb5QhNAlTj5KytVDRJrmTgvGzdWvP2A5Vql+gEFPzBZxJvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EMv8z6SJ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50D53C113CC; Fri, 10 May 2024 12:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715344174; bh=KLTEQaQm0FiKrFX+yiOF9TjuFZuP1CHAkj/bzBphg3M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EMv8z6SJgjOkYO8F9OmlDJc1OX4Dw5sMcTwrp3qrJanEAm/UX1rAcrxLFwfNqgmpe /PU0QXrxfVoVPBdfZtCdM7hNA2mrscGvYlNjz+rGtb3UflMUsDV7gQf7ZSj6t+Y0zO 1tUWYEW4lmf3Ou1nPm1/+sXXklEKH5URkSc9iPsp7sdFU39ggWDZBLXd+U54iCSZ0T RIJXeJFaJWCGJixm99vjbFAI7GFg10MRVv7AqJtG3zFkhB3vvX2ie8P+2BhXQJM8UJ BuAlyCfrOyqgNYHZ6wWS8+ZE0wyKNb3odRDQQCwpR9nN1NPcfCKnY8OhbCT0SG8SyO F3MgcnXQ/EWSQ== Date: Fri, 10 May 2024 13:29:27 +0100 From: Simon Horman To: Oleksij Rempel Cc: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, David Ahern , Willem de Bruijn , =?utf-8?B?U8O4cmVu?= Andersen Subject: Re: [PATCH net-next v3 2/3] net: dsa: microchip: dcb: add comments for DSCP related functions Message-ID: <20240510122927.GW2347895@kernel.org> References: <20240510053828.2412516-1-o.rempel@pengutronix.de> <20240510053828.2412516-3-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510053828.2412516-3-o.rempel@pengutronix.de> On Fri, May 10, 2024 at 07:38:27AM +0200, Oleksij Rempel wrote: > All other functions are commented. Add missing comments to following > functions: > ksz_set_global_dscp_entry() > ksz_port_add_dscp_prio() > ksz_port_del_dscp_prio() > > Signed-off-by: Oleksij Rempel > Acked-by: Arun Ramadoss Thanks, I really appreciate attention to this detail. Reviewed-by: Simon Horman