Received-SPF: pass (google.com: domain of linux-kernel+bounces-175828-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240509221947.3118-1-W_Armin@gmx.de>
In-Reply-To: <20240509221947.3118-1-W_Armin@gmx.de>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 10 May 2024 16:30:33 +0300
Message-ID: <CAHp75Vd9JZxuDGYm2drSYun+h2CAU+Lb4BEFq3LnQYBKpOfyMA@mail.gmail.com>
Subject: Re: [PATCH v7] ACPI: fan: Add hwmon support
To: Armin Wolf <W_Armin@gmx.de>
Cc: mlj@danelec.com, rafael.j.wysocki@intel.com, lenb@kernel.org, 
	jdelvare@suse.com, linux@roeck-us.net, linux@weissschuh.net, 
	ilpo.jarvinen@linux.intel.com, linux-acpi@vger.kernel.org, 
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, 
	platform-driver-x86@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, May 10, 2024 at 1:19=E2=80=AFAM Armin Wolf <W_Armin@gmx.de> wrote:
>
> Currently, the driver does only support a custom sysfs
> interface to allow userspace to read the fan speed.
> Add support for the standard hwmon interface so users
> can read the fan speed with standard tools like "sensors".

> Tested with a custom ACPI SSDT.

This most likely fits the comment/changelog area and not the commit
message. Also would be good to put there the link to this custom SSDT
(like one of zillion of pastebin sites, or GitHub, or ...).

I was under the impression that Guenter gave a tag, which is missing,
but no, he just said it's okay to go. Guenter, maybe a formal
Acked-by?

Some cosmetic related remarks below.

..

> +/*
> + * Hwmon interface for the ACPI Fan driver.

I would use hwmon (as it is an abbreviation based compound word which
we know in small letters).

> + *
> + * Copyright (C) 2024 Armin Wolf <W_Armin@gmx.de>
> + */

..

> +#include <linux/acpi.h>
> +#include <linux/device.h>
> +#include <linux/err.h>
> +#include <linux/hwmon.h>
> +#include <linux/limits.h>

+ types.h

> +#include <linux/units.h>

..

The rest LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andy@kernel.org>

--=20
With Best Regards,
Andy Shevchenko