Received-SPF: pass (google.com: domain of linux-kernel+bounces-175996-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 10 May 2024 12:10:08 -0400
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: Rob Herring <robh@kernel.org>, Richard Zhu <hongxing.zhu@nxp.com>,
	vkoul@kernel.org, kishon@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de, imx@lists.linux.dev
Subject: Re: [PATCH v4 2/3] dt-bindings: phy: Add i.MX8Q HSIO SerDes PHY
 binding
Message-ID: <Zj5G4B/aHq4WlunT@lizhi-Precision-Tower-5810>
References: <1715234181-672-1-git-send-email-hongxing.zhu@nxp.com>
 <1715234181-672-3-git-send-email-hongxing.zhu@nxp.com>
 <20240510153849.GA308062-robh@kernel.org>
 <20240510-daisy-overkill-99c4bee476c0@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240510-daisy-overkill-99c4bee476c0@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?yvKprQylRHe+UNLmB1Uek2K+xhvLW6mPnWKSQ1zGA0I9Rxw5fldIKIgAeDyQ?=
 =?us-ascii?Q?eAX481Wle6nndMasvA/8DgiL2LFZ5H3jIPudGciCmK959aYcDkfgKDqVfdLp?=
 =?us-ascii?Q?K+dUOMm/obrWGJYRsZWAR43TJXBfRRN99ms4/Zy5JlaetGAFtUitHHe3vzA9?=
 =?us-ascii?Q?ZhODrJOuD26ACsf0uPKxHabzwzGnuDN/OqDNrCC/QKC/IchdvtZj3Ks3KZ0Q?=
 =?us-ascii?Q?lf8LusvlncVju2nQcST/byudcYqaNByC81/IZWJPcaKV0+HNixlwBX8zHj+z?=
 =?us-ascii?Q?nNnYakcdF/MV3sLncxSJXaG7qMy3YyX6rkYWYNNeMKAopevXs35uzpxOeV0G?=
 =?us-ascii?Q?D6sdNFA9IKQl4jRcJNn2FjdNhvbMAIZfNNHzaZ4WKf08NdlAvqe1CnMx46X6?=
 =?us-ascii?Q?xNcbmFfrL8Y9f7S5oGyxHtqQ+cKrsQx/AlugPn3Bv4OJuDqrNcyjfuaTs6RU?=
 =?us-ascii?Q?/gFdd2fdZm5uFvajHPxG4ayFKR/afiPQhHw/8VN/LIQpSPZkXuHKcn/ZBoKo?=
 =?us-ascii?Q?VZxrsJOJCwpgYzkB1jwT27qisk+WWbCwvNQSkJ99Iqm2BaOpy/L4PLJvhfLH?=
 =?us-ascii?Q?nImnOEIzTmMhcZFLIE9+uJGfvS6u87aE79J9lQ2wZrXSSNzqAaZBeX4kU3PQ?=
 =?us-ascii?Q?xMTK0Tte2FeeV30ZF1oLBrc134A8ZRdOeVCxwku+2/4aZOvjuDQgvz/sxb+v?=
 =?us-ascii?Q?QLSHWUmW6moKHWx0oiWX9K3GyRckDD7D79rYDe7MCCcQWNal29OoF6vqELx6?=
 =?us-ascii?Q?C0vNHSkaiOHZlpmmTvk5J6HTj4UjYH2b4NZ6R75Pdi9F3h2EyVnSOeya0CwM?=
 =?us-ascii?Q?Tu1pG4P+jLtdcvi+bBdvdcauG23OO/j1bVkkZjhSM+xDkGFVy0GdIIoXl/5P?=
 =?us-ascii?Q?rdxoXkQ27mVC9cTT1/004y1eV4KcirO6g4sfvbQEWJx+RW/UVj6IlULQd2fN?=
 =?us-ascii?Q?YuFXIcplh3pNQAgFKAnkDoah3thdeVxeWwjEybeezaYfwDT7qLSk6A/YyUNk?=
 =?us-ascii?Q?oW92pQXrfhtwnuOJBMq2Xzf+tMEIIiTPiCXeaGozvis9tHAvbLvJbDmuz/K+?=
 =?us-ascii?Q?0ngjlc14AjNyoKwWwNSyOV7m7sR/3Vm2xD4Bu1c8XzmFafvPx6WmqxMatd4A?=
 =?us-ascii?Q?oEmEhsdnzGQPb2QSZ7Dba95LnNQBcE1Hu2q+D1KTaUiTWTmAKhZWsBrU0yjI?=
 =?us-ascii?Q?p6Ssun26T83qrOVDslYUWtjX8vpbcqPzKkeIsKxTP2xO/lLI5jpOZVZMcpaC?=
 =?us-ascii?Q?UxD8bjR3pEdhj+EEOcycDCk8QgZEcW1OxvxA9KymtGmx2gFLqbGERwsv5BjN?=
 =?us-ascii?Q?pZndKKOtbPkCTAykf2ZZeDCLIQhwV1wSU7UAgIvuxFkvE5nLQNiyPIZ27HPE?=
 =?us-ascii?Q?578orvVr0Ukw553LbgGb7XZopwOXokZuydI6PP4UT97fJwt1ZRHFsU7fU5hQ?=
 =?us-ascii?Q?0nJheuC7oGZ1CyNpynwqyCxKlfT0TDhioi8TI8xhCZ1fIFxmviUX74TgFM/w?=
 =?us-ascii?Q?e8dG6krP/f0jk8aON2YsodBZDVrxt4pska3nvgON8LQu3nQTTVTVmmvlwCW7?=
 =?us-ascii?Q?gGkddWBMAI+IQxZ7/UkAwLIyiUvXGH8agmBf3+gY?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08bb7d35-6abc-4ec5-1d9f-08dc710bae3f
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 16:10:16.3022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PHSlpK82dB9WpF3JYLqm34erPOmakvkCncfxOOziVn14d2NWtoMw+2Pv/ryxr72stOiHbKlAKG/HBw6j3pVIbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8988

On Fri, May 10, 2024 at 04:52:22PM +0100, Conor Dooley wrote:
> On Fri, May 10, 2024 at 10:38:49AM -0500, Rob Herring wrote:
> > On Thu, May 09, 2024 at 01:56:20PM +0800, Richard Zhu wrote:
> > > +  fsl,refclk-pad-mode:
> > > +    description:
> > > +      Specifies the mode of the refclk pad used. INPUT(PHY refclock is
> > > +      provided externally via the refclk pad) or OUTPUT(PHY refclock is
> > > +      derived from SoC internal source and provided on the refclk pad).
> > > +    $ref: /schemas/types.yaml#/definitions/string
> > > +    enum: [ "input", "output" ]
> > 
> > default?
> > 
> > Really, this could just be a boolean for the non-default mode.
> 
> There's actually a third option, or at least there was in v1, unused.
> The description in v1 was:
> 
>       It can be UNUSED(PHY
>       refclock is derived from SoC internal source), INPUT(PHY refclock
>       is provided externally via the refclk pad) or OUTPUT(PHY refclock
>       is derived from SoC internal source and provided on the refclk pad).
> 
> I suggested that there should be 3 strings and not having the property
> would mean unused. But all mention of unused seems to have vanished :/

Yes, missed mention about unused.

Is it okay about "fsl,refclk-pad-mode not exist means unused ?

Of course, need mention in description. 


Frank