Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755662AbYA3Tqq (ORCPT ); Wed, 30 Jan 2008 14:46:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755345AbYA3Tqg (ORCPT ); Wed, 30 Jan 2008 14:46:36 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:56660 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752720AbYA3Tqe (ORCPT ); Wed, 30 Jan 2008 14:46:34 -0500 Date: Wed, 30 Jan 2008 20:46:16 +0100 From: Ingo Molnar To: "Luck, Tony" Cc: Mike Travis , Geert Uytterhoeven , Linus Torvalds , Thomas Gleixner , Linux Kernel Development , Linux/PPC Development , linux-ia64@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup Message-ID: <20080130194616.GA19426@elte.hu> References: <200801301414.m0UEEgCC006371@hera.kernel.org> <47A09F8A.3000309@sgi.com> <20080130161036.GA12293@elte.hu> <1FE6DD409037234FAB833C420AA843EC757C72@orsmsx424.amr.corp.intel.com> <20080130180623.GA24881@elte.hu> <1FE6DD409037234FAB833C420AA843EC757DEA@orsmsx424.amr.corp.intel.com> <47A0CD4B.5040706@sgi.com> <1FE6DD409037234FAB833C420AA843EC757F12@orsmsx424.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1FE6DD409037234FAB833C420AA843EC757F12@orsmsx424.amr.corp.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=none autolearn=no SpamAssassin version=3.2.3 _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 52 * Luck, Tony wrote: > > This is only defined for !__ASSEMBLY__ > > Some place in there. The CONFIG_SMP=n path in ia64 makes quite > radical changes ... rather than putting all the per-cpu stuff into the > top 64K of address space and providing a per-cpu TLB mapping for that > range to a different physical address ... it just makes all the > per-cpu stuff link as ordinary variables in .data. The error messages > indicate that some of the new code is unaware of this. ah, that was the vital clue. The patch below makes the small memory model only defined on SMP, and makes the config build/link fine here. Does this build and boot on your box? Ingo ------------> Subject: ia64: build fix #3 From: Ingo Molnar Signed-off-by: Ingo Molnar --- include/asm-ia64/percpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-x86.q/include/asm-ia64/percpu.h =================================================================== --- linux-x86.q.orig/include/asm-ia64/percpu.h +++ linux-x86.q/include/asm-ia64/percpu.h @@ -15,12 +15,12 @@ #include +#ifdef CONFIG_SMP + #ifdef HAVE_MODEL_SMALL_ATTRIBUTE # define PER_CPU_ATTRIBUTES __attribute__((__model__ (__small__))) #endif -#ifdef CONFIG_SMP - #define __my_cpu_offset __ia64_per_cpu_var(local_per_cpu_offset) extern void *per_cpu_init(void); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/