Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp624059lqo; Fri, 10 May 2024 09:34:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWzdOM6iR9hAmsZhdS79RPbxwsCFj0dFqS9QgRrSA8ypGAd+DyUXj2gfQgLKgfyaI2Z2GcfFjAQUoE1pHRIOC6gG50f1ufNChcb/zQVkw== X-Google-Smtp-Source: AGHT+IHvQ/GlZQ7j9ztr31yMMW0DE3qbDIy/0IFH4U61gYfAO57a2vH2USOGhW1lJzyJUrw+dfh4 X-Received: by 2002:a05:6358:7204:b0:192:8935:4067 with SMTP id e5c5f4694b2df-193bb612b4fmr377358055d.14.1715358881752; Fri, 10 May 2024 09:34:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715358881; cv=pass; d=google.com; s=arc-20160816; b=wjmfXgDR3rMzArgIH+Zg68lSwg4UmC+EDw2tHDrEpOSNyzc+eid0QK6duPOrbJ0mm/ kXOHLsnqfQqXmH8CG68xGWwD+rZpb7p9Dn53KvOgfJ+VU4C/xMUb8BOWSEnAXZXppmIF rfnjg+gd4bMs6ZVK9eZ+szvY6gKYDeQzpaFSyeYqdJJSO4CUBXJbUFEdpSlwibzON8iG SxeUcibwF+Rg3ws77nNKt1Ut5TIhAYwI2s7siUxd8+n8DR6OAJt92dYydVcoVU/VG8Q2 qFP/qgBLYC0r/U4F/QLJ1h9p9MSmUyj0rteyuTiCuIMycDgi8xnZsthZnWkCkECy6qvI 7iEg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=oQi7BMvhKG60rFUGiXd360AqzfjgMdqrvJlRvRCCOMo=; fh=3jGHjD9uIMbXpBatQ4ANLir7jJdthdNgYIZ7HnK2wxM=; b=BNR1Eo/p6vchx/CGjKShgwWt39DJ2w0nOco9OhxD9iU7pl//4XhzTsfrShfLWC1NXm otO0oXze0iFBF5Z3IfDt4qosAfGMvUPjHCGLkzQnDHMPlgnFjXG6jbkW0Zu39zwIIJ07 +QtDjpv3QbPdOulXNBAPERbGelctY0uTsD8HzfYhvLO/nc40ByK7zaOMrlqpp3ONt8H7 VG8D2RFniI83MHo2mEafVeoi68dhrNZapKAuxNtP2jzwzNW1AEj2QugLpFh3+wmCOcwg NqFDL5vEezmjEnQXZDaJR9z1sLw13Dw+XWK/4/WuH2sU77aiTE3H3RnWBLCgb4PZ+3cD vTyw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=VAGbDnjO; arc=pass (i=1 dkim=pass dkdomain=bgdev-pl.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-175864-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175864-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-63411530b4asi3824934a12.534.2024.05.10.09.34.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 09:34:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-175864-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=VAGbDnjO; arc=pass (i=1 dkim=pass dkdomain=bgdev-pl.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-175864-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-175864-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5B3352853FD for ; Fri, 10 May 2024 14:07:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D0341170846; Fri, 10 May 2024 14:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="VAGbDnjO" Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F217312C81F for ; Fri, 10 May 2024 14:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715349981; cv=none; b=G+AHKd0AKKV8Re1Ud45Xz+br5fGboWbTDW8zwy1RWpakojssbdQObpZbVIo8jWQ09LEcfw/cIy+O1gVHLLHrCpAoDUMfpLAsB1ZhVJqveGAUCQMSYj6Gx142P0PicOgjpW0f4Yk5J4T7TWehmrCZ9MMBcXzHsbkZz5JLDohxb3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715349981; c=relaxed/simple; bh=3vrH3H0o028E+i3JWGWAvMc6RQs4IPDuJpZHn6s8NFo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=DJeBtbieba8gwMs4kVniLnwVL8+U6euBFG/EOxHg/c2gM5l7xEJjJeBb4rE3qLyWuMneu8qHncx7yeYoozXYbSP2kLli36Nj4dLEjcYwTrqf18kamIvAmbi8itmMOhh5OFg49RMeATcSpfqPlNyYceZq4uU/MhxXS0turzSKsWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=VAGbDnjO; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-34f52fc2191so1065856f8f.1 for ; Fri, 10 May 2024 07:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1715349978; x=1715954778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oQi7BMvhKG60rFUGiXd360AqzfjgMdqrvJlRvRCCOMo=; b=VAGbDnjOou2c/z0xBkoi7al/mREiaFjF0IfOHzAluXx2Pc7gwAF4Bach3HUkkbJJhm H/JLHl9jMbDXKz03g00qIUWxnu5sPrCDECqyhZWejYud34j2Sd1J6skXEVUv5UK2vp6n mSgQmo/uuNNIjaS3yt09rx5iueTFncE93cJ9PSGQCHScsSlSEJPHC0c/JHyOdrq0T1al OSPyVCU6rmvg5hwxCTiR77kQ7dqXGn/+mgexoOAcGWjaNlgFgTtk7M7kuVp32R9OjLcb trJyMM67pQF5/V2Xo5US2sPZxCqRNCihlQI4K5RfXR13mC69EYR0MBCTDUhqYleULYn4 AU3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715349978; x=1715954778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oQi7BMvhKG60rFUGiXd360AqzfjgMdqrvJlRvRCCOMo=; b=f4Kr0pAk3D7xg4gPrC+A3ld2DsUz8EDPEo6bk3vEtbryb7v0C78nX6BxGtWUd7APmX UUA4F0Bn5fwYA4i9VT3ChXKcEtfUHeQ3W37BioMHoq106gewbkKxICyWutBQXd4NjDNP 0NuJAUZj2PjFelAhAdRB6rV90aiOhvxg1TrJFrmXsZk63cyBszaGIs0cTuODqUsNx3yT rJA60FYoZU7e4lLjJkfnBaJ+JIayc+iubt98VfusugEYvutrIhHRvyXu+wv11uB+6qmt 5d3yJX3PgGn0ipBEMnkH3jt0MTAwhuwfLejOXpCxKGxlmQHvHRxv8cq9EtDU29LiOk7W NEIA== X-Gm-Message-State: AOJu0Yy0pONeJPQxGZbTNc0Je3+1Nb0Q3ODGmPH6lQ6zZVk/xIx4PnSX vDJcX+Ldci+SruRlJNMcJinA2NTG2UI1R0U62zKI8EM3jRsAmYDEuAhLPGDjjK6e59VXgQCZtxD i X-Received: by 2002:a5d:6da8:0:b0:350:f6d3:4ad4 with SMTP id ffacd0b85a97d-350f6d34b63mr1251329f8f.44.1715349977896; Fri, 10 May 2024 07:06:17 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:75a:e000:f6ed:a982:f92e:840c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3502b8a780fsm4620264f8f.59.2024.05.10.07.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 07:06:17 -0700 (PDT) From: Bartosz Golaszewski To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Kent Gibson Cc: Bartosz Golaszewski Subject: Re: [PATCH] gpiolib: cdev: fix uninitialised kfifo Date: Fri, 10 May 2024 16:06:16 +0200 Message-Id: <171534996897.34114.8159265536879918834.b4-ty@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240510065342.36191-1-warthog618@gmail.com> References: <20240510065342.36191-1-warthog618@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit From: Bartosz Golaszewski On Fri, 10 May 2024 14:53:42 +0800, Kent Gibson wrote: > If a line is requested with debounce, and that results in debouncing > in software, and the line is subsequently reconfigured to enable edge > detection then the allocation of the kfifo to contain edge events is > overlooked. This results in events being written to and read from an > unitialised kfifo. Read events are returned to userspace. > > Initialise the kfifo in the case where the software debounce is > already active. > > [...] Applied, thanks! [1/1] gpiolib: cdev: fix uninitialised kfifo commit: 3c1625fe5a2e0d68cd7b68156f02c1b5de09a161 Best regards, -- Bartosz Golaszewski