Received-SPF: pass (google.com: domain of linux-kernel+bounces-176029-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 10 May 2024 10:47:50 -0600
From: Keith Busch <kbusch@kernel.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Keith Busch <kbusch@meta.com>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org, hch@lst.de, tglx@linutronix.de
Subject: Re: [PATCH 1/2] genirq/affinity: remove rsvd check against minvec
Message-ID: <Zj5PtvnSMoLPjg0o@kbusch-mbp.dhcp.thefacebook.com>
References: <20240510141459.3207725-1-kbusch@meta.com>
 <Zj46KiMO5trL09RA@fedora>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zj46KiMO5trL09RA@fedora>

On Fri, May 10, 2024 at 11:15:54PM +0800, Ming Lei wrote:
> On Fri, May 10, 2024 at 07:14:58AM -0700, Keith Busch wrote:
> > From: Keith Busch <kbusch@kernel.org>
> > 
> > The reserved vectors are just the desired vectors that don't need to be
> > managed.
> > 
> > Signed-off-by: Keith Busch <kbusch@kernel.org>
> > ---
> >  kernel/irq/affinity.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
> > index 44a4eba80315c..74b7cccb51a16 100644
> > --- a/kernel/irq/affinity.c
> > +++ b/kernel/irq/affinity.c
> > @@ -113,9 +113,6 @@ unsigned int irq_calc_affinity_vectors(unsigned int minvec, unsigned int maxvec,
> >  	unsigned int resv = affd->pre_vectors + affd->post_vectors;
> >  	unsigned int set_vecs;
> >  
> > -	if (resv > minvec)
> > -		return 0;
> > -
> 
> This behavior is introduced in 6f9a22bc5775 ("PCI/MSI: Ignore affinity if pre/post
> vector count is more than min_vecs"), which is one bug fix.

Thanks for the pointer. Probably best I avoid messing with irq code just
for this use case, so I can have the driver disable the PCI_IRQ_AFFINTY
flag instead ... assuming hch doesn't "nak" it.  :)