Received-SPF: pass (google.com: domain of linux-kernel+bounces-176026-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 10 May 2024 12:43:48 -0400
From: Frank Li <Frank.li@nxp.com>
To: Joy Zou <joy.zou@nxp.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	"open list:FREESCALE eDMA DRIVER" <imx@lists.linux.dev>,
	"open list:FREESCALE eDMA DRIVER" <dmaengine@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH] dmaengine: fsl-edma: change the memory access from local
 into remote mode in i.MX 8QM
Message-ID: <Zj5OxCXiSt5Np3sm@lizhi-Precision-Tower-5810>
References: <20240510030959.703663-1-joy.zou@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240510030959.703663-1-joy.zou@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?yC8ACWoftx+q+DFQOuxCSCRVqCB85/N7KStKl7hvDaUrZzzFy/jqCisOcjaS?=
 =?us-ascii?Q?1ADxVwroJeaqOb3ojzrmRwwMKCGwdB/UgETBlNjly0JxcJO+n0Gxl/typBoI?=
 =?us-ascii?Q?CK1+0IZCf7AehkuaPeyRJ3EzGB9XL9isT5PvERDCHAZZCBYQDP/9Uc1wOyr2?=
 =?us-ascii?Q?lVcs4hL+JTngT9s03mLAIWFoB+VBWxrO09ZcdE3pd/TWWYOhkD5FBZjNBAn/?=
 =?us-ascii?Q?ee7Lia5Lny4CXeRERGeETUCnSYSCvzOwI2HQ+KqZvUIp+nA0Z99Hj+ow+BDf?=
 =?us-ascii?Q?2xOC4Rc4vT3PiDqguj9uPjYDHItU7+muroVwnt59c8Gim/uIHUwslZFBaOGz?=
 =?us-ascii?Q?wiP8MmRXkTslEIUOo3b7sIrYYt0XG9kJDQC70irnG31jk2kdUTcv4f9o9kQA?=
 =?us-ascii?Q?qZJ1L2udaIK1QdYw5YJgzigd2XW5PPGXjr4kPLcEA3WNeJMxb2wqXFaCEUWp?=
 =?us-ascii?Q?hdBLWQpmSehACiaC+sEYS6pVAiF+DMQJsBrKrGg/bfYLCNXuJMjDzKxUjpIh?=
 =?us-ascii?Q?0g6kHFePpAQ1TJCy01Adh8RCb9Ar9dPIISURcJOzeFhwG+Rw/fBuiIrEnz7F?=
 =?us-ascii?Q?rtWrascS9U6wtom6j6HFAgAEmNi0gQvA4zg+OUwik0VIswMU+NvigQPEobnq?=
 =?us-ascii?Q?XD4mvzyhmpAV5QThDrGH7chCUFjU4Y/qZ4ZFo5sbYFIGrENtIYR7aEZjsIBX?=
 =?us-ascii?Q?e3BUQ0Zt/p6wHp65r9aN+oGXxEVBqcA9WpXf7T3AURJbXofdvvo5AKIchYA1?=
 =?us-ascii?Q?t8TIAcRuMFnkgterYlI5CDWxXHhhEFAJnpkQIEVgkC1oNC8CiolwC6WGp0DS?=
 =?us-ascii?Q?UllQ7QJ7p6MSHlR9iK2Wr7okgUqaXQ6CxC6nTBRi1rFS9WbU3usQlQVVF6EF?=
 =?us-ascii?Q?saFAg86fkJmziPqQIh3Dwns8XIR3l7CedTv/tMMRfAokA8buC87g/orJno0L?=
 =?us-ascii?Q?ThG3S3Nhx90+RcSZxzM5hpLG6WaXg8/8zw2QqKpqplqM5tJrdS+Foug8XVd7?=
 =?us-ascii?Q?TCiQsJTKQkXjEZeL9FWKQZhpPJvIWJgmYDt//uYp5DVry+ogX+mnww9fIPAO?=
 =?us-ascii?Q?XjVPXQWAja5PEbQla8MN/Suyy+l/xmM/jnbyfPslATjwjAcp2N+4WCJBF8TT?=
 =?us-ascii?Q?PNXybd4FQQX0bvz+KNYpMbVH1QG7Zj2T4AAo4h2YYWjdCGRwQ6qz3EyWBPkw?=
 =?us-ascii?Q?e2g/4a1savOUJTBaUIYzFhON99NS1NFv0qUocBYwjJVBZ29YptXOFWf4zHAG?=
 =?us-ascii?Q?ZG4Szs0pFRpDbnIgO7I6LvMVn98a/t/SxAUYozsgDKx98q+karr9GyB4FMfA?=
 =?us-ascii?Q?MYCDJw/Qj9hBzGhE480OG2YycaQVNTkRKdwlnJd7AY6nf4XmRaUQRwJ3XPVa?=
 =?us-ascii?Q?oPRpA09mLPjGgUZA7y6v7/DlteklxPif1I4GRSV+3IJeh8tQnfGreqx4TOw3?=
 =?us-ascii?Q?puViUMhzbHPxo34NNSxsWg0SaXL80JSFLWVeg3dEbnTn4Uvqn9i/pr4JSoGX?=
 =?us-ascii?Q?niihWws8FuP4W2P5BCNAf3nRLiqh6j3Ho9i2ePMsV6V7PCaw/6csVZV/scds?=
 =?us-ascii?Q?ReiKmNZ3cPZbuiSJsyQ=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9ca4663-4565-4a61-70e5-08dc711061d8
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 16:43:55.5564
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: npCP4z6l5PPiv3pseXqZowF8AFnDP1b//gQqtk8M1Pc2rOSxbSASjdCSw6PWoDYYJyFmWGkYXfboK0UvVk5Gbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8806

On Fri, May 10, 2024 at 11:09:34AM +0800, Joy Zou wrote:
> Fix the issue where MEM_TO_MEM fail on i.MX8QM due to the requirement
> that both source and destination addresses need pass through the IOMMU.
> Typically, peripheral FIFO addresses bypass the IOMMU, necessitating
> only one of the source or destination to go through it.
> 
> Set "is_remote" to true to ensure both source and destination
> addresses pass through the IOMMU.
> 
> iMX8 Spec define "Local" and "Remote" bus as below.
> Local bus: bypass IOMMU to directly access other peripheral register,
> such as FIFO.
> Remote bus: go through IOMMU to access system memory.
> 
> The test fail log as follow:
> [ 66.268506] dmatest: dma0chan0-copy0: result #1: 'test timed out' with src_off=0x100 dst_off=0x80 len=0x3ec0 (0)
> [ 66.278785] dmatest: dma0chan0-copy0: summary 1 tests, 1 failures 0.32 iops 4 KB/s (0)
> 
> Fixes: 72f5801a4e2b ("dmaengine: fsl-edma: integrate v3 support")
> Signed-off-by: Joy Zou <joy.zou@nxp.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> Cc: stable@vger.kernel.org
> ---
>  drivers/dma/fsl-edma-common.c | 3 +++
>  drivers/dma/fsl-edma-common.h | 1 +
>  drivers/dma/fsl-edma-main.c   | 2 +-
>  3 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
> index d62f5f452a43..7accee488856 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -756,6 +756,8 @@ struct dma_async_tx_descriptor *fsl_edma_prep_memcpy(struct dma_chan *chan,
>  	fsl_desc->iscyclic = false;
>  
>  	fsl_chan->is_sw = true;
> +	if (fsl_edma_drvflags(fsl_chan) & FSL_EDMA_DRV_MEM_REMOTE)
> +		fsl_chan->is_remote = true;
>  
>  	/* To match with copy_align and max_seg_size so 1 tcd is enough */
>  	fsl_edma_fill_tcd(fsl_chan, fsl_desc->tcd[0].vtcd, dma_src, dma_dst,
> @@ -835,6 +837,7 @@ void fsl_edma_free_chan_resources(struct dma_chan *chan)
>  	fsl_chan->tcd_pool = NULL;
>  	fsl_chan->is_sw = false;
>  	fsl_chan->srcid = 0;
> +	fsl_chan->is_remote = false;
>  	if (fsl_edma_drvflags(fsl_chan) & FSL_EDMA_DRV_HAS_CHCLK)
>  		clk_disable_unprepare(fsl_chan->clk);
>  }
> diff --git a/drivers/dma/fsl-edma-common.h b/drivers/dma/fsl-edma-common.h
> index 3f93ebb890b3..cc15c1a145eb 100644
> --- a/drivers/dma/fsl-edma-common.h
> +++ b/drivers/dma/fsl-edma-common.h
> @@ -194,6 +194,7 @@ struct fsl_edma_desc {
>  #define FSL_EDMA_DRV_HAS_PD		BIT(5)
>  #define FSL_EDMA_DRV_HAS_CHCLK		BIT(6)
>  #define FSL_EDMA_DRV_HAS_CHMUX		BIT(7)
> +#define FSL_EDMA_DRV_MEM_REMOTE		BIT(8)
>  /* control and status register is in tcd address space, edma3 reg layout */
>  #define FSL_EDMA_DRV_SPLIT_REG		BIT(9)
>  #define FSL_EDMA_DRV_BUS_8BYTE		BIT(10)
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 391e4f13dfeb..43d84cfefbe2 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -342,7 +342,7 @@ static struct fsl_edma_drvdata imx7ulp_data = {
>  };
>  
>  static struct fsl_edma_drvdata imx8qm_data = {
> -	.flags = FSL_EDMA_DRV_HAS_PD | FSL_EDMA_DRV_EDMA3,
> +	.flags = FSL_EDMA_DRV_HAS_PD | FSL_EDMA_DRV_EDMA3 | FSL_EDMA_DRV_MEM_REMOTE,
>  	.chreg_space_sz = 0x10000,
>  	.chreg_off = 0x10000,
>  	.setup_irq = fsl_edma3_irq_init,
> -- 
> 2.37.1
>