Received-SPF: pass (google.com: domain of linux-kernel+bounces-176036-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <4363899d-2203-5829-9074-beb6c0e583b6@amd.com>
Date: Fri, 10 May 2024 12:01:40 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH v3 03/17] x86/resctrl: Detect Assignable Bandwidth
 Monitoring feature details
Content-Language: en-US
To: Reinette Chatre <reinette.chatre@intel.com>, babu.moger@amd.com,
 corbet@lwn.net, fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com,
 bp@alien8.de, dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, paulmck@kernel.org, rdunlap@infradead.org,
 tj@kernel.org, peterz@infradead.org, yanjiewtw@gmail.com,
 kim.phillips@amd.com, lukas.bulwahn@gmail.com, seanjc@google.com,
 jmattson@google.com, leitao@debian.org, jpoimboe@kernel.org,
 rick.p.edgecombe@intel.com, kirill.shutemov@linux.intel.com,
 jithu.joseph@intel.com, kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, peternewman@google.com,
 maciej.wieczor-retman@intel.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, eranian@google.com, james.morse@arm.com
References: <cover.1711674410.git.babu.moger@amd.com>
 <63134ddf18208bbd11bcec0ec75c33ef6e5635b2.1711674410.git.babu.moger@amd.com>
 <ac22b96d-c4bb-42d9-bac8-22b9e032b59e@intel.com>
 <80b33bc6-7b70-4853-92a0-718c2d8728d3@amd.com>
 <753844b6-b68d-4b05-89b0-3ac36e1c8564@intel.com>
 <be20ffe1-ef8c-41fa-b359-9ebfaa326ebc@amd.com>
 <50d006e0-8488-4579-ab4e-701e1a8f410a@intel.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <50d006e0-8488-4579-ab4e-701e1a8f410a@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T3p5ZmpETzNmaElGYmc3S0s5QmJ2ei8wbldaWnNVRzNwT21WMVpubWJPeGlG?=
 =?utf-8?B?MFNzZjFDbDFoUHVhQUp1YkhlWnJiOHRvbmhKQkhTeXNEUWoyZFNWak04MTNT?=
 =?utf-8?B?TFdOQWdvN3l6bkw1eEtVSkpCVTRLQ0JkdGNJWVQzeGd3KzdUZWZXVm5veHVt?=
 =?utf-8?B?SCtzTkMrM1lCdGZKa1B2cWZaelAvMDA5Q2xCZjFweW1tTER0Z0pmQ0tUUktx?=
 =?utf-8?B?NWtjUGgzQ3g1M1dOeTNRVW51VzR1YVl3Q0VUa3dmYkVJdFF1ZkhTZENvRmZF?=
 =?utf-8?B?V3hMT0lwaFlHck15UnkybEFWTTBUQzZOaGNlcjR4THh5Vm5pMnd1QnBRdlFN?=
 =?utf-8?B?VUF6YVd5cDZVdVhkTWtIWXU3bzFZdGxuOVVraEdybjUwVDErZUxJNThyNHNH?=
 =?utf-8?B?NS95SWkxR004eEtDRUJGd1lTSEJKU1NISjBiT1BsWkM4VndmY09Ja250NmU4?=
 =?utf-8?B?NEtNaVZWYnJBUmhFMFViVGlSMjk2YXhVcUNkc0docHJldmFCUlRxekdaNnBr?=
 =?utf-8?B?NlVvazdnNlI5bzVGQkIrWlAvSFNCb0RpYVFsNUlxV3MzcG9UTzY0RkZyRWdj?=
 =?utf-8?B?YVJETnIyS3o4WnNycXRIR1VuK1prbzhmeXhzR2R4WDVoblBuZEZrOVY2RUhF?=
 =?utf-8?B?YXRLL0VpS3dMUDQ5MU9jelA5dy9vNVZhSENJNDlBbTJNMUdXT3orZkxBYkM3?=
 =?utf-8?B?UXdjTHJqZW5BREkxRkZqTTlTQ3RnY2lSMkQxWExqWWFySHcyOGtNZU9DWjZS?=
 =?utf-8?B?elFDT0xSOUtRRmJ6UXFLN2Z1dUlaSWZlTHlzNjcxcEhqc0ppSkxXN1JqQ09B?=
 =?utf-8?B?OEhoMFVNbmZOaWVZYWJFaXN4NzdnVXU3V0NheGQycmZDbjZpL1Fub2tMOERi?=
 =?utf-8?B?ZG5XQW5JekV3SUdEUDZoczZqMVlJcTRWNnZaS01qMzFxQWkrN2NkamZ0Ylhv?=
 =?utf-8?B?Q2V3UjVTVnVlUlhvTzNkcUFTaWZYSURDemFxaEJ4dnE3YnVhS0tnZlJQQ0sr?=
 =?utf-8?B?V1JncGZnM2pVWHFEUEhKSlVEZmFidEUvcERrUGkyT2UwMXd6dlZTZnZwN21C?=
 =?utf-8?B?bGMxN2h0MUNtN01HRFFsWlNXMEJiRXFXNmxBZ1hUa3dzVjJVN2UrQ3ZVNnhM?=
 =?utf-8?B?Mk5kbGxOZmhPbUlndFNCT1NWSVVDdGdMM1dpeE95RXlRREFnZzQyeENXVDlp?=
 =?utf-8?B?N2JCeHF0MS9NS0EvZkZLb09YQ1VSaisrRXBKZ0lGUTA1WFkyNk9pT1Y3NVN6?=
 =?utf-8?B?ZGljRDluSEY0NTUrNzlUcGtVdEQzdVlMczJDS1BxMXFJcjYxbXNWZWp2ejZM?=
 =?utf-8?B?ODlETFg4bldVeXJDSWV3dkdGN1JWNU04Rm9RclJyNHY1eW1wQlRxakVrOUNG?=
 =?utf-8?B?aWRiaGJJZFN3ZHZBNXZOY3lHanpVZnB4ZU1aMTA1anZyUjRndkcxOFE5L3l4?=
 =?utf-8?B?VktWdUp0QXQ1RGVIanpGN1lKVFZWMDNmVEZvWGRtUzdyR0Z2T3VSQ3ZLdkNs?=
 =?utf-8?B?eVEwWjZuUzllZWM3cmpKYUJXdXBDMHM5RmE1b3R3dm5sZWJ3V08zMytsMnl1?=
 =?utf-8?B?SlZHZU1UcUVzNUVZTHRCdW1DZkhrdHJmL0dLSnR5NFZEQitqSGlxaFNpVVVG?=
 =?utf-8?B?eW9BSm5tUXpadEJHNjJud09UVGdSbXhwSHdJanRCQkhXWHFIWlJyL1o2WCtw?=
 =?utf-8?B?Sk1VNktFK1JxTEVHcWpNc1JQakFQTDBLSHdObWRBT0trWFllZFUvQXJHZ2dp?=
 =?utf-8?B?YktDeVNtQjNmOFFCN2NneUlEWUNLakxTOVh5Z2FzdVlrMVkxWGVtakl5bmFH?=
 =?utf-8?B?ZVphY2p6eUVsKzY0VzRiVktDaFQzR3IwRnFSa1RNZzJhdVEzangzWTV4RldZ?=
 =?utf-8?B?Vm82U1VQdDd5ZFRoQlFrUFB2UDVZU2Q0ZFIyeG5ZRmdFclRTM1V4Q09CQ0hs?=
 =?utf-8?B?bC9uUmtBT2llR2FzL3c3clR5SnJLWkNjcU9pT1o5YytBRWdaUnh1R2FFYWsx?=
 =?utf-8?B?Umx4bm44MXNhZ1RYQm44Mmo5UHFQMlRUZ0ZBRDZaSFFFZFBUUy9GSEtFOVRz?=
 =?utf-8?B?SkxUVWNPOHI3MGsrLzZsMzhkWk0yYzBQcGowamVUbGhuV2NYSk5mTnRCQXNO?=
 =?utf-8?B?bmtsZGZZSnZtbGEwa2wxU1JnYnU3eEVBVG1YVzUydTltN3NGV01YbVh4REhh?=
 =?utf-8?Q?soEwO+Dqc7lVRy9ejBiI0EugLzUzHA/XHPU5MFgSHlaJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67d85f28-b478-4fe4-7d7a-08dc7112dfa6
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 17:01:45.7643
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RlolCrGRD+w4L6JZcDDkZdSGlBWN4y8ycc2EeZZ5qbrgRbmLQWINnBKLZR4+JqmI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8142

Hi Reinette,

On 5/9/2024 10:18 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> On 5/9/2024 3:34 PM, Moger, Babu wrote:
>> Hi Reinette,
>>
>> On 5/7/24 15:27, Reinette Chatre wrote:
>>> Hi Babu,
>>>
>>> On 5/6/2024 12:09 PM, Moger, Babu wrote:
>>>> On 5/3/24 18:26, Reinette Chatre wrote:
>>>>> On 3/28/2024 6:06 PM, Babu Moger wrote:
>>>
>>> ...
>>>
>>>>>> + * @mbm_assign_cntrs:	Maximum number of assignable counters
>>>>>>    */
>>>>>>   struct rdt_resource {
>>>>>>   	int			rid;
>>>>>> @@ -188,6 +198,8 @@ struct rdt_resource {
>>>>>>   	struct list_head	evt_list;
>>>>>>   	unsigned long		fflags;
>>>>>>   	bool			cdp_capable;
>>>>>> +	bool			mbm_assign_capable;
>>>>>> +	u32                     mbm_assign_cntrs;
>>>>>>   };
>>>>>
>>>>> Please check tabs vs spaces (in this whole series please).
>>>>
>>>> Sure. Will do.
>>>>
>>>>>
>>>>> I'm thinking that a new "MBM specific" struct within
>>>>> struct rdt_resource will be helpful to clearly separate the MBM related
>>>>> data. This will be similar to struct resctrl_cache for
>>>>> cache allocation and struct resctrl_membw for memory bandwidth
>>>>> allocation.
>>>>
>>>> Did you mean to move all the fields for monitoring to move to new struct?
>>>>
>>>> Struct resctrl_mbm {
>>>>            int                     num_rmid;
>>>>            bool                    mbm_assign_capable;
>>>>            u32                     mbm_assign_cntrs;
>>>> }:
>>>>
>>>
>>> Indeed, so not actually MBM specific but monitoring specific as you state (with
>>> appropriate naming?). This is purely to help organize data within struct rdt_resource
>>> and (similar to struct resctrl_cache and struct resctrl_membw) not a new
>>> structure expected to be passed around. I think evt_list can also be a member.
>>
>> How about this?
>>
>> Lets keep assign_capable in main structure(like we have mon_capable) and
>> move rest of them into new structure.
>>
>> Struct resctrl_mon {
>>             int                     num_rmid;
>> 	   struct list_head        evt_list;
>>             u32                     num_assign_cntrs;
>> }:
> 
> This looks like a good start. It certainly supports ABMC. I do not yet
> have a clear understanding about how this will support MPAM and soft-RMID/ABMC
> since the current implementation has an implicit scope of one counter per event per
> monitor group. It thus seem reasonable to have a new generic name of "cntrs".

How about renaming it to "assignable_counters"?

-- 
- Babu Moger