Received-SPF: pass (google.com: domain of linux-kernel+bounces-176059-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <dc64a811-3e33-4d5c-ab42-a5c2e8a79c50@gmx.de>
Date: Fri, 10 May 2024 19:40:27 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 2/2] platform/x86: wmi: Remove custom EC address space
 handler
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
 Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Hans de Goede <hdegoede@redhat.com>,
 Mario Limonciello <mario.limonciello@amd.com>,
 Heikki Krogerus <heikki.krogerus@linux.intel.com>
References: <5787281.DvuYhMxLoT@kreacher> <2332870.ElGaqSPkdT@kreacher>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <2332870.ElGaqSPkdT@kreacher>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:u81cezJJvhY=;qWfFEO3cN8PrxOrzwdMWcUWEKc8
 fk0tJrFWx/wbLy4IzJqk0dbXOjXNYEIFZxtvQ8eoaRvbzT+EWcamKlQLPchpoCa8kwzsheXiG
 Ya1+jjiWxtOlvRB/7WeuswOB86tqgseDV/nCXnIevnMRgdf2lq+GM/ebAWWmKZh0oYdPi2TB8
 45JytlKAQRcbmXUErWcoAJH3q0CpwwFIECcr3SArvE2Kbe2vFq9irNfvWB+wJi5Aa/toUzk9Q
 EDENv5b78tq0mUn4XCcXE2wokU0mJZjIqseZPEIv5/R3J1NGUcgzh9KvbXvU7/FhkQVBeFtBG
 kxy7SqZ6RShkgf60s5R4KDYa1+X2caWMNqTc6TjrpsZZtRnwB1MZEMeeLsKKnv0RggpxnkVha
 aT5Z2R9dbJ3qVVGjz9b0++UbbMvEgc4v9+J9RusX8VJTH30q6QvYKYSjaGCYIgGCNpwMyKYxR
 DhtUjeNLBfoA0CY++KlB0tBEhXJHTRBO9CHiYiYMczKcboxmleUSRdhLZBfX38qJN4gJNztVl
 IeTKIvaHuRSg6z3I12Ec3jG0EthjzRjQejh8vr2El62uHtUhlAOY6TILJ9pJ41JH+m0wffyv9
 7rFJK+6oN3ABINuRl9/rUgIAwJucuvzpOy+BO2fyPvbZGKXsFZxA41XfmpeoF8xVqzEZWnROH
 gnyCf0mj/QflXwFQfcTLGLUTv/OtgCIbYzAXjeW14P/B5+4RXnxPZaBGAm27tZFCM+vkLewB7
 MaAXQKBnvi4WBOTflTRxv/kSjYxggwLKF1a3xMS9tAhvJrBPJBde5PlvHa9BbYUqgOHdI2lIi
 LbOXDB69YasmkUukaQGZyh8i1RqOXTnfz1hNXrvw6l1Bw=

Am 10.05.24 um 16:04 schrieb Rafael J. Wysocki:

> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The custom EC address space handler in the WMI driver was only needed
> because the EC driver did not install its address space handler for
> EC operation regions beyond the EC device scope in the ACPI namespace.
>
> That has just changed, so the custom EC address handler is not needed
> any more and it can be removed.

The patch seems ok to me, but it might conflict with pdx86/for-next.

Other than that:
Reviewed-by: Armin Wolf <W_Armin@gmx.de>

> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>   drivers/platform/x86/wmi.c |   62 ------------------------------------=
---------
>   1 file changed, 62 deletions(-)
>
> Index: linux-pm/drivers/platform/x86/wmi.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- linux-pm.orig/drivers/platform/x86/wmi.c
> +++ linux-pm/drivers/platform/x86/wmi.c
> @@ -1153,47 +1153,6 @@ static int parse_wdg(struct device *wmi_
>   	return 0;
>   }
>
> -/*
> - * WMI can have EmbeddedControl access regions. In which case, we just =
want to
> - * hand these off to the EC driver.
> - */
> -static acpi_status
> -acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address,
> -			  u32 bits, u64 *value,
> -			  void *handler_context, void *region_context)
> -{
> -	int result =3D 0;
> -	u8 temp =3D 0;
> -
> -	if ((address > 0xFF) || !value)
> -		return AE_BAD_PARAMETER;
> -
> -	if (function !=3D ACPI_READ && function !=3D ACPI_WRITE)
> -		return AE_BAD_PARAMETER;
> -
> -	if (bits !=3D 8)
> -		return AE_BAD_PARAMETER;
> -
> -	if (function =3D=3D ACPI_READ) {
> -		result =3D ec_read(address, &temp);
> -		*value =3D temp;
> -	} else {
> -		temp =3D 0xff & *value;
> -		result =3D ec_write(address, temp);
> -	}
> -
> -	switch (result) {
> -	case -EINVAL:
> -		return AE_BAD_PARAMETER;
> -	case -ENODEV:
> -		return AE_NOT_FOUND;
> -	case -ETIME:
> -		return AE_TIME;
> -	default:
> -		return AE_OK;
> -	}
> -}
> -
>   static int wmi_get_notify_data(struct wmi_block *wblock, union acpi_ob=
ject **obj)
>   {
>   	struct acpi_buffer data =3D { ACPI_ALLOCATE_BUFFER, NULL };
> @@ -1308,14 +1267,6 @@ static void acpi_wmi_remove_notify_handl
>   	acpi_remove_notify_handler(acpi_device->handle, ACPI_ALL_NOTIFY, acpi=
_wmi_notify_handler);
>   }
>
> -static void acpi_wmi_remove_address_space_handler(void *data)
> -{
> -	struct acpi_device *acpi_device =3D data;
> -
> -	acpi_remove_address_space_handler(acpi_device->handle, ACPI_ADR_SPACE_=
EC,
> -					  &acpi_wmi_ec_space_handler);
> -}
> -
>   static void acpi_wmi_remove_bus_device(void *data)
>   {
>   	struct device *wmi_bus_dev =3D data;
> @@ -1347,19 +1298,6 @@ static int acpi_wmi_probe(struct platfor
>
>   	dev_set_drvdata(&device->dev, wmi_bus_dev);
>
> -	status =3D acpi_install_address_space_handler(acpi_device->handle,
> -						    ACPI_ADR_SPACE_EC,
> -						    &acpi_wmi_ec_space_handler,
> -						    NULL, NULL);
> -	if (ACPI_FAILURE(status)) {
> -		dev_err(&device->dev, "Error installing EC region handler\n");
> -		return -ENODEV;
> -	}
> -	error =3D devm_add_action_or_reset(&device->dev, acpi_wmi_remove_addre=
ss_space_handler,
> -					 acpi_device);
> -	if (error < 0)
> -		return error;
> -
>   	status =3D acpi_install_notify_handler(acpi_device->handle, ACPI_ALL_=
NOTIFY,
>   					     acpi_wmi_notify_handler, wmi_bus_dev);
>   	if (ACPI_FAILURE(status)) {
>
>
>