Received-SPF: pass (google.com: domain of linux-kernel+bounces-176080-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <e366b4d3-1cf3-48cf-8445-cdbc1156d32b@nvidia.com>
Date: Fri, 10 May 2024 11:01:09 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] selftests/resctrl: fix clang build warnings related to
 abs(), labs() calls
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: Shuah Khan <shuah@kernel.org>, Nathan Chancellor <nathan@kernel.org>,
 Nick Desaulniers <ndesaulniers@google.com>, Bill Wendling
 <morbo@google.com>, Justin Stitt <justinstitt@google.com>,
 Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Valentin Obst <kernel@valentinobst.de>, linux-kselftest@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
References: <20240508190254.266892-1-jhubbard@nvidia.com>
 <c1e834d6-266d-d8bb-4e85-cdc440ddcb31@linux.intel.com>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <c1e834d6-266d-d8bb-4e85-cdc440ddcb31@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ckJJbVM0cGNWa3FKRTVvOXFRZkJWTjF2Z2l0UHlCRjB6R29iZ3k3SDg0eEpr?=
 =?utf-8?B?MkVkRWllSUFqVFdqdjJKQ1MwNUdLckptRGJxTnVTQU51dU9kelFtRGpYNHdM?=
 =?utf-8?B?VnZsWDJkbnZISS85ZjYvZkNqL0tWc3BHTTM2REc4OVB6M1pxZXpkaTBKaFZa?=
 =?utf-8?B?SFpQMHgrbnhBZGlXRXpxOEdxYmEvOGxPczRDN3NQLzduekVtNjhsOG5PYnpj?=
 =?utf-8?B?WS9iSS9lYmx4QTY4TVc1aDBidzZhaG9PNmRJdVc1N3ZqY0ZkZWRSVjhiNGlY?=
 =?utf-8?B?WkJONWhnakVUS21PK3R4OGp5eHV3M2hpQ2ZKV2xvVEFEZWJSMjhoeFRzV1RR?=
 =?utf-8?B?ZFJVY2RONjJWdFUrU0ZlOHhpckdhaGxjSUtCNWM0ZHpuRndINlFaQlJvT1dZ?=
 =?utf-8?B?MEFVUWQ5ZDF6YmVhYlJWUkZKMDgyd2ZlQ28rb1M1cHdtem01Qldkc28vN2pC?=
 =?utf-8?B?MHFOU1hzUTNlWlpSUkRPWkpsNklKQ1NQOHhTblVjSUJlelUwOVhoZVFJWnIw?=
 =?utf-8?B?TTdwZ29NaloyekZFOTA2dnlzd0xHQ01wYmh5Q2d5c3E3UnJWcVlIR01BMjAy?=
 =?utf-8?B?ZXN2VU5TaklXejZFLzlyZE91RWNDMnZhY0FBYmdyUWJHNHoxcnZ3MUdxQjRx?=
 =?utf-8?B?ekg5b0dsVFB1c1dsMnRrcHpNQlQ3Qk5KdEpvOHE5a1lwc01pNXVMcDFHYlB2?=
 =?utf-8?B?V0gxYXd2MkY5ZCthTFBZTE9zdUEyc2w0NnVaMk1SZEZiaDJOMlFKdmNlbWZ1?=
 =?utf-8?B?eWk1M1l0SysxVHl3d2JWMjFLdFFKbENpdkkycmgwaTVWQmVLN3NLY1NjNzFR?=
 =?utf-8?B?ZlczOEJtcGJqL2ZOQW1ZNzR6MGZIcjZ4WDZtUEVHSzdiL3U1cGJCVWxNK1Ev?=
 =?utf-8?B?RlBEVlpSRkNaVnlLYmtnYlRRZWswdXFkdDJCSURucWVRMVNidHNDeW1IVlVO?=
 =?utf-8?B?YmI5Z1NPbk5EWXdrSnl2cEw0YzFLNkZlQm5jTlR3TEpvUVh3UjFlSFBWbFJQ?=
 =?utf-8?B?NmlIUzFQZ2hyTCtvUFlDSmxubkZZYndrTmhRN3VIQ2d6WHdjMW1QVGZONE9C?=
 =?utf-8?B?c1FrOUNBU2pVajN3RTNaYlJmUDdtWjZFdkd6ZzFSandaZFN0R00zVCtiS2o0?=
 =?utf-8?B?Rk85b056a0dEVFVETEtPbzhFUVdiV1RLTkxLR0NKUXlWVkJHWExTcXRMVVlp?=
 =?utf-8?B?dEVYVmVIczc3aVhjbVRLRUFMelVZWlZZVTcrWURYbmYzTzY1R2pCT01mZklY?=
 =?utf-8?B?RGF5WExxa1FObzJnbk1aK1NiRWdZZ3IyZEZpb3ZNUE9Mekp2N0NnSy9VZVRB?=
 =?utf-8?B?VlRCU2R4eE9la1EwRVVHWjJxSGZkVWpwNWM4K0VRczNaeE5uOWVFclhZUDF2?=
 =?utf-8?B?U0F5MjlWWWdtVStMWG5UQ0R1b3NjVEJnWTlsK1owbm8xa2s2UEZLZGVQZ3Ix?=
 =?utf-8?B?bFJZOENBcnI2a2VnRENZaEpvY1hmbmloTEpCMmIyc3F4M1Q1V3h2VVprM0h5?=
 =?utf-8?B?aDJkWmU3aFNYdG5FcUtzVEtSaSsvQ3ZCYWpHZUZpdnNONzNjQVhCTlA0K25E?=
 =?utf-8?B?MUM3S3lTVkJaU1JnWnJLem1CbnJxaTZSRldNQnlGN0F6R0dUTFlYNGNIR3ZZ?=
 =?utf-8?B?dmtlZzRCQktuZWhuMmp3NFkzdE9wUnRmWEh1U0FQeXRxLzZWSEhFTXFHbGMx?=
 =?utf-8?B?ZDFBR3hSQnVnRW1ueE54U004RXlLYnRyNEpueXdzMFpRYlVPRUcxMGlNYkVs?=
 =?utf-8?B?NTcxMHFoczZwNFgzby94R0VLMU10STZtcGtYY1N4RXF1ZFBZc1dUSzZBbTZH?=
 =?utf-8?B?N2xzUlNRdVRkeGxDckFLYkRwTkk1RXorZHpDTVFkdWRkTy9PQnJTSGRPSlpB?=
 =?utf-8?B?bkp4S0pNaWs3YjJmMHNDeVkvbTh1cE5XbUZ4aDlrd0J3ZzBZUk9Wbnp1QmVJ?=
 =?utf-8?B?My9zVEcwTFdzWmVUdjhSTVNxelhLc25UeDZaZjl2QldBd2w4emdMZ0w1Q2JV?=
 =?utf-8?B?TlhodXJzZG5wY3BacE5GL2lSUFVTMWo0aW9ieENBQmM4eXE5Y0VPWkcrbnVp?=
 =?utf-8?B?U0MxV1VDd1dPTUlPdm5Ma3NnT2lOWTBSdElDTXZxU2F0a2pOdmlrcUdBQTVo?=
 =?utf-8?B?MnZyMlNoZDN3YjV6YnV6eTBXcXd3YldyM1ZHeCtmUE12T3hQaGx1aE5RTm9K?=
 =?utf-8?B?Q2c9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18299fef-0bb6-48f3-5be8-08dc711b3327
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 18:01:21.7106
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YtkdiUnb8mXEnJ66GUq2u2BBF9y/euj0VY7x05G/G4zYYfXmIlAy/iNd3Nk4CxQPV4Q+r9vTEeex5nJd1pN7jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7968

On 5/10/24 2:06 AM, Ilpo Järvinen wrote:
> On Wed, 8 May 2024, John Hubbard wrote:
> 
>> When building with clang, via:
>>
>>      make LLVM=1 -C tools/testing/selftests
>>
>> ...two types of warnings occur:
>>
>>      warning: absolute value function 'abs' given an argument of type
>>      'long' but has parameter of type 'int' which may cause truncation of
>>      value
>>
>>      warning: taking the absolute value of unsigned type 'unsigned long'
>>      has no effect
>>
>> Fix these by:
>>
>> a) using labs() in place of abs(), when long integers are involved, and
>>
>> b) Change to use signed integer data types, in places where subtraction
>>     is used (and could end up with negative values).
>>
>> c) Remove a duplicate abs() call in cmt_test.c.
> 
> In general, instead of filename, it's better to refer to the actual
> function in this kind of description. And in this particular case,
> cmt_test.c could be replaced with "the CMT selftest" which is more
> descriptive and still unambiguous.

Sure, I'll change that.

> 
>> Cc: Reinette Chatre <reinette.chatre@intel.com>
>> Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> 
> Thank you.
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 

Thanks for the review!


thanks,
-- 
John Hubbard
NVIDIA