Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp686107lqo; Fri, 10 May 2024 11:27:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVjzUfW3oTpXuQU1z32QQcXoZ9AEonVYDyt/hKbGn46U1XmyNdQ301nv029Ew9CXZuzTgvqR2jyzq4QvzAxL45mt4oOxvutnrrF/DCC5A== X-Google-Smtp-Source: AGHT+IEW6mO4a9AlsRlG6uju61Wc0tu29Tjg8EZKtLSAqR/9nOZHAxfuEPRdVrSxdbEgJ5xfS69y X-Received: by 2002:a05:622a:514:b0:43a:f697:6670 with SMTP id d75a77b69052e-43dfdcd7c69mr33434051cf.49.1715365652880; Fri, 10 May 2024 11:27:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715365652; cv=pass; d=google.com; s=arc-20160816; b=gr53MrWiFFtxJLy6GjVwwmPDTrvhCK1u+BuGhc83JyYfJnWr23GFthluUXfVVA9wOH opXj26a6S0NPoUne1rRflykGI25XjNFUsYH6MZX1oykOBddD8phtyE6InRzdtg8FzSsn Lc5DbuDoLORBA7IZ48ioEYvK2YONm5Uhn1JOoSQBZy1KFP1yrQF/mo3u4OkL1+oQioFy 4v8BWnOIww4/2rW/McXxMwa/A34tswkPEyzv4ytT8hQqkA1jjOxoBMW+KqRcp8NixUQ+ 8/IdoFNhkx3fFa1wNeR6TsRYPk+/lRP8CFGRUB6HVmuwv42vWC2LNEPR4IQOuZFMJVp1 Qn5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=JBvdzVQWJU8MypKGBKD1JTF1bR2eY0ug4Y9S+vmlZ9s=; fh=RN8bBoRbiuDq2ckGM1nN48AbKJR9T8H/X3zeo9ysSVE=; b=TCkdWuu49mHoygGdziO7AzCAdzuH8WEMRmnW5/o3Na6pTyTFvvuxuDEL7G8/UwD6FQ Yn86+QRkV3BE/ETgdxCexqCuF4n75DKMVXx/SyJhERGjH8LFQc/LHcvxpNTh9pXKDWOa UxJ+jfZMWs3u+82HTD1OxWmDDoWojwF2fSJmOaRJ21Yv2rXLFu8kewqHSAnzVDxpUssz fhhkT3iWp3eW/rdLcvUYXHoflW0Zg/ZPPXkHwbioNH6SgZdqOoxv/rPKqnMwAEJuoiW9 NnqhfxL5/32f4P7RHVuYCboTKCbDYLaLv7n9yP2b4eQlI4y/JgzrVU5W6euFtmsH2GWZ C0uA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fPtFgsqh; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-176094-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176094-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-43df54b4b37si39956541cf.182.2024.05.10.11.27.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 11:27:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-176094-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fPtFgsqh; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-176094-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176094-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0CD541C222A3 for ; Fri, 10 May 2024 18:27:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A3D23D968; Fri, 10 May 2024 18:27:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fPtFgsqh" Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED05E22F19 for ; Fri, 10 May 2024 18:27:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715365642; cv=none; b=EpdwjmJhibGk8f0DkOI8T70bA8jH/mMIntLc0IlZxdq65AUmIWOnRvyYR8xs0PIHz5H0MciFnZL4D/rfxDVu75rI8XS0tg1BkpeToq+CIdhqz7EYj+rCwrayovKjFXmDwRrzdQ6xEBqu+m5MoOAqbN6FspCgVzZos7FYkRm6KtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715365642; c=relaxed/simple; bh=SjX/kCfSrJi2GY2ka8pKL65+RnH5+NTpFGW2SRgh7jk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nz9cby088MQSa31Ea0uyFTlmOUmWhdEcjNg/stnYZQZpHL7IIReZX7Z38Bnb5VKSHWk03bGq116oi1HF0vMKEdUJXLBK0r/ihNI0GtrsoiSDUMonC9dJrCcnHfFwq1Ax1kiCKab7m86A+r07xVodutBp8DAbUxZmaTaYB8c1e4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fPtFgsqh; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-34db9a38755so2062932f8f.1 for ; Fri, 10 May 2024 11:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715365639; x=1715970439; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JBvdzVQWJU8MypKGBKD1JTF1bR2eY0ug4Y9S+vmlZ9s=; b=fPtFgsqhuXB4ZOxfuYGN3ld2R+L1HwXave8/w4i8d3f6AZFxU1R+razLqqnZG4j/fu IozTPVIl1LYmMn0qK39saGRaRVURBCVB53zgWLgLUw5KWoI5xky8QdLcJmMYUUtfr0/p qQmpsGUIogtYQM5kWcJp9fuR5S0P+N1T5NBm/LdeFNMl7soTG3YJISSnJDU7WIh20Wb/ qY8VNI4a9+wqkBXd6qRRDbossrDZ4CXAwNcsDPPlCvXFLRdTc+pcf64ay4Ty0IjLZqrC e1RPbTNOT037+VbSowRmBfBd6/G/9/G/QpCGT7sRMAol+4ciYZIjR/gY+WPmAJ52JHMj WAXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715365639; x=1715970439; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JBvdzVQWJU8MypKGBKD1JTF1bR2eY0ug4Y9S+vmlZ9s=; b=HKwWj2dtgyDMdIKfwMuFYSopoWQkiLsn6VI57ctqLilK+Hu6L4E4wIFe7v4nzCm4iV lZfasHpYW3Yee+YT59huthZVR4CO4+k3RRPj/1WB201g3mvwZ2acYNNHwy6SPkDtkLn+ RR5rHcMzjQ5YyHfSD1vfSwVyOCgGuzKaEBPTNn3meB138+jocsFfsKX8XIxG1wsFEJCu LZrZxHwGVn7/fBEhxZH1pLyhgGKujCbClMZD/h7UAnfvyWYNsvt6hMwvh9tVPpK7gkDv 9rLc0Z9B4qQ2Lg6WG6kI/iTAXUMRhZM2braTJA8/u61Z5spFb0RZIh56J6W5e5KbZKnW oRlg== X-Forwarded-Encrypted: i=1; AJvYcCU405MBqMYYX6jqGqPIoqIwfywxil6nfquo08ZhzuixMJF2JR6/NkM3X2q4tfjB4G+MdjTV/ctANjMvj1LAegixPtty8I9tjRbKsFIh X-Gm-Message-State: AOJu0YxtlI2oDYmFljgkvd4TLuow84xkKmWH0PSiSVELqHOEJGiWSWrC OFjIKZlBsGjsEKmL1THR/Y3lQHcuF/V36f4iOvN/cGXF3HOnbxNV+XHTkOscdiY= X-Received: by 2002:a5d:5490:0:b0:34a:4227:e9e8 with SMTP id ffacd0b85a97d-3504a9694f2mr3126219f8f.47.1715365638824; Fri, 10 May 2024 11:27:18 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3502b8a791esm5198463f8f.64.2024.05.10.11.27.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 May 2024 11:27:18 -0700 (PDT) Message-ID: <320ba508-56aa-4ef2-9fab-3752f4181da1@linaro.org> Date: Fri, 10 May 2024 19:27:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/8] media: qcom: camss: Attach formats to VFE resources To: Gjorgji Rosikopulos , rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, hverkuil-cisco@xs4all.nl, quic_hariramp@quicinc.com References: <20240411124543.199-1-quic_grosikop@quicinc.com> <20240411124543.199-3-quic_grosikop@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240411124543.199-3-quic_grosikop@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/04/2024 13:45, Gjorgji Rosikopulos wrote: > From: Radoslav Tsvetkov > > Video node formats have direct dependency by the sub-device pad formats. > Remove dependency for SoC version and move format definitions in device > which creates video node. > > This commit attaches a struct to the VFE resources that holds format > description, so it is much easier to assign them to the video node. > No need to use a switch-case. > > NOTE: The mbus_bpp is used to calculate the clock rates and is different > from bpp which is the bits per pixel written to memory. We need to keep > both values to not break the calcualtions. > > Signed-off-by: Radoslav Tsvetkov > Signed-off-by: Gjorgji Rosikopulos > --- Reviewed-by: Bryan O'Donoghue Tested-by: Bryan O'Donoghue # sc8280xp/sm8250/sdm845/apq8016