Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp686295lqo; Fri, 10 May 2024 11:28:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUnWa8/4y/bejoEAdwufjzqMicfVtLBQk6QFiVUQecs6pekKlEpuQX6cXeffPn7Uh4Qo9s5cZaam4LxTZnMDtebaZE9BFDNTXMnxlMx4g== X-Google-Smtp-Source: AGHT+IHxqIaD1VqoWJSw3DuiaHYqhUnQlZVFKEWukZ1uwuvTQGBH3JvLMIINuDh+H3wY1RdBZ8IM X-Received: by 2002:a50:9b42:0:b0:572:a1d7:ab29 with SMTP id 4fb4d7f45d1cf-5734d5903f5mr2686681a12.9.1715365679835; Fri, 10 May 2024 11:27:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715365679; cv=pass; d=google.com; s=arc-20160816; b=olQTkH+1CegvA3QnhmUI3TUWhKUAB2SWcBoNJROwp9ip0ooXYnsHYOltPubJl6GpbE DnWUMP+yx+iqa0YY3Bsaiccv1xilCJajxZhlDT3EnXEIBPyg1GYOO0vxyKG8UN1nOkSI qgKSnDhdqsbPUPTCiC6xJnYi8IX3nTAaxevBGeSsxLrpjBlaCXJ8hL85HQFiodw6KxDW ZuQISQzU20uwOqkfR/w6ufLt8cGE1MKpf8m8KO/t5eEgNKHxGm9zpQSr7HfNbRMkhlyK fhGlCvX0B5Ed+W19Vp/q8BVAIn7Elhd0rgBTvtVEl8CORTViLLWUsWNY1MfMEuF666RF Eugg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=N5gysLK7eBXrdS+RL9/zVN/Yqx4/fP1l7kizHDddPSA=; fh=WndGzADSYylace8XVmij7MSkT6R/fR6zAJuLIRF/ivw=; b=U8YYiMvMVkFUzi/BPk/QAnlAGymGTJdFtvM78YhbZSR8J4y2mXofmbvPWPBi4ShcEW R8Kl8IIrbzDCt07LrwMm34cdE8E+rdXJzhE1lY1xLnpmRvOXDW8FvANiGquO0gG3w38M J/mGqELkvIYahieAwg4uCIjguxEJSGKUMsPwq8A5B944TNUhSohDLL6FPoDiLe7m5iaK N9A2N2GPoFMZqyr/xX0Qh8vvHzWnapV9dukPpueMm7Kru6NyJ2YQT9cYmLW7eb0Fv3AA oYp2RPBF/LAOWA9rXAnkAMnUG9nkm38LMudps+qca0L37j0SkmhTjcf1zOW+4EADCx5B Q7kw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VZRV8ygJ; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-176095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176095-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5733c37810csi2332504a12.644.2024.05.10.11.27.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 11:27:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-176095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VZRV8ygJ; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-176095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176095-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8F8591F2122B for ; Fri, 10 May 2024 18:27:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7CAA517BA3; Fri, 10 May 2024 18:27:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VZRV8ygJ" Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A9572C683 for ; Fri, 10 May 2024 18:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715365667; cv=none; b=fMf9U6Y3F3E0RQ7DG+VgP/E5CFGZmN36E3BeVBYEbHFSD4+QPouLlT25U2Otn1dM5+6CJdfSHMyFCx+dJ92w2hGm37xtlOCMyllAzsOP+ZOp1yKmHUs4MGz2EZamSk9I/saaGw3GIB7hjd6XD+tRIL3GF+Ufq/T66DkLtABByzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715365667; c=relaxed/simple; bh=uLqe92/dQ4dMxvG6UINLCSdWA9vxn9F9HhspNog0qfE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tp5mhoUXFzNpYLxNmmgXbqpJ+Az7nPLRQOgLMSP6zXWHk6eKNfB6vF9hCYxvuKYNxCaBFI1TtgMwWJwVQ8R5doN7UrPfjX5SJ6GNkCL+8MxeKsKAL+IUdY2iNJ0DI2xJYwIFGwzgQ3NtF9dO46yGVo4yS3V+ORamblHPLLXrAGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VZRV8ygJ; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2e3fa13f018so28127071fa.3 for ; Fri, 10 May 2024 11:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715365664; x=1715970464; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N5gysLK7eBXrdS+RL9/zVN/Yqx4/fP1l7kizHDddPSA=; b=VZRV8ygJzcWS1QwM5oX65XYyIca6fJ3O6IIIRltWw26KVUvQaHNj+dSXv9WSoyTnxp IjLQ7qW91QFuqZXt/zX87OI30HRJ1DYTojolgq0kM/SUUYUy5wyu4ZP6CaTBuQd6YeC4 wZ9vKxjn+e+6IwzU2Mrwfr7mJ3I/ih4aou1IWLlL4VWDzFbDi9AodfOy/UYgDUgspJ88 PjHHX114v1sA4Re2jKt+6M3FQhrmZCBfUVKig7GqAHEGzN1Z+D1UmnNrP2UT1s71H0ly Y2DGVC93tthBI/iCjdA7UQinTZxBkvZIBhQ4jLNg4DHX1XnpMrWxxanMSI4TxPlkFXfF xGxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715365664; x=1715970464; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N5gysLK7eBXrdS+RL9/zVN/Yqx4/fP1l7kizHDddPSA=; b=qdNIlMB5UEy0XyMY7j8npvyfteR35j86cApgGyCharG32twAMkpo75D08TuD7l3Qp8 5sGotmvsskg3rgt2k0cB7uzOG41d/+6RkaCqlNYzZKcwmtIaT7h0HWc6ojFzKBjwukma ksC6PeXbH1v7+eh2+aLcNBQXWm298UK/Gv4CRkbz8afLvlOLkDYN2baeyzPk6EEOzfzF zQ01YcaScPSpxKOZPTtEQ55VDsLjrxXMQ7tAy7bkw7Ti1vZqwUL1jtSgldyihy3BQo3P PP28goIR8d8OdpuFEDyn27LPn+HHW0mUp7/1QD7HqeX91py5CqFd/TvfeFKOk8h+0BdN 2vPg== X-Forwarded-Encrypted: i=1; AJvYcCV9k228k4hEcCMceDIcUc07FzLR9RAFiL9B7Zw/cgmmCgMf+fy0MAQbdOzb6hKPHIzPzSZaJhDuJKHmV1C1oGhPkCUomeFqszFuzWiB X-Gm-Message-State: AOJu0YyUIwhC/snw7/dhPkz3TXdU+zCJIIIUyqNJJBr3uglw02Cpob7d 4vrR1gkR0Kn49eO9T1/A56GtGHwrVUzNutIXPZU057bJCT89dcC9CPsyVl1+PEw= X-Received: by 2002:a05:651c:c9:b0:2de:73b5:4280 with SMTP id 38308e7fff4ca-2e51fd2de83mr24891861fa.3.1715365664318; Fri, 10 May 2024 11:27:44 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccce25d5sm72370325e9.14.2024.05.10.11.27.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 May 2024 11:27:44 -0700 (PDT) Message-ID: Date: Fri, 10 May 2024 19:27:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/8] media: qcom: camss: Attach formats to CSID resources To: Gjorgji Rosikopulos , rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, hverkuil-cisco@xs4all.nl, quic_hariramp@quicinc.com References: <20240411124543.199-1-quic_grosikop@quicinc.com> <20240411124543.199-4-quic_grosikop@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240411124543.199-4-quic_grosikop@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/04/2024 13:45, Gjorgji Rosikopulos wrote: > From: Radoslav Tsvetkov > > Following the example of VFE, move all formats of the decoder > to camss-csid.c and attach them to the subdevices resources. > > Signed-off-by: Radoslav Tsvetkov > Signed-off-by: Gjorgji Rosikopulos > --- > .../platform/qcom/camss/camss-csid-4-1.c | 132 +---- > .../platform/qcom/camss/camss-csid-4-7.c | 160 +----- > .../platform/qcom/camss/camss-csid-gen2.c | 164 +----- > .../media/platform/qcom/camss/camss-csid.c | 474 +++++++++++++++++- > .../media/platform/qcom/camss/camss-csid.h | 24 +- > drivers/media/platform/qcom/camss/camss.c | 75 ++- > 6 files changed, 538 insertions(+), 491 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-4-1.c b/drivers/media/platform/qcom/camss/camss-csid-4-1.c > index dd49a40e6a70..c95861420502 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-4-1.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-4-1.c Reviewed-by: Bryan O'Donoghue Tested-by: Bryan O'Donoghue # sc8280xp/sm8250/sdm845/apq8016