Received-SPF: pass (google.com: domain of linux-kernel+bounces-176106-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <51af9362-ccb5-4393-9dfd-8615138df217@intel.com>
Date: Fri, 10 May 2024 11:34:12 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v3 03/17] x86/resctrl: Detect Assignable Bandwidth
 Monitoring feature details
To: <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1711674410.git.babu.moger@amd.com>
 <63134ddf18208bbd11bcec0ec75c33ef6e5635b2.1711674410.git.babu.moger@amd.com>
 <ac22b96d-c4bb-42d9-bac8-22b9e032b59e@intel.com>
 <80b33bc6-7b70-4853-92a0-718c2d8728d3@amd.com>
 <753844b6-b68d-4b05-89b0-3ac36e1c8564@intel.com>
 <be20ffe1-ef8c-41fa-b359-9ebfaa326ebc@amd.com>
 <50d006e0-8488-4579-ab4e-701e1a8f410a@intel.com>
 <4363899d-2203-5829-9074-beb6c0e583b6@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <4363899d-2203-5829-9074-beb6c0e583b6@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ek52aDl6bklQVlBMN3BXK21GM0IxNzZLVHAzVllObXYrcVYvTFY5MEF5RmRs?=
 =?utf-8?B?dC81SEpkY1Z2d2pZMnM1RStSREIrUDRqaEdTcVhNWGhKZjBYQkQ5UFUrcTdZ?=
 =?utf-8?B?UGZXdTBrRmFNb3dLbWN1OHdxejhWWlJ5T2Vpa0tROTJCQ0cxK3hYc3J5S3dj?=
 =?utf-8?B?bU1oSzVSZE0yR3lldzVUUzZrd2ZYZXJlM0F2LzgvVWNJMmhyMSswWEZ0Y092?=
 =?utf-8?B?c3ZoNmR4R2hRaEt2bFRUUjJjS1hjL3NBMzN6ZEZ3L05xaVJyK3JwSDNDVEdV?=
 =?utf-8?B?bWZ0cUhwczNHN1N6eFpkckJsamdiSmZXMWg4ZVM2RlBNR2tBaVlPZkJlM0Z1?=
 =?utf-8?B?bDcyNk82ZlN1c1d1TmZIQ3VZbzcvckp4OXZpK2xlMjN3WDlFaDhjR0l0dUpF?=
 =?utf-8?B?WGx1NFpjcSthQmd3elVSOHpnWlpuUjc1R3dNQ0RlQTFCRTdNcG9mR3ArQ3B0?=
 =?utf-8?B?dDMweDdPREYvSDhzUWFwOHczZFhHUzBrM0ZzdjRoOGFsbnlsSGNnRW55eHM1?=
 =?utf-8?B?WVF2ZlMxREVwQjV2YU1UMzJneW9raXB1L3FaQlhyTzNjeUJHM25EamNBWThq?=
 =?utf-8?B?WVBRWUVsNURtQkh6dFdoNEttNVREMkkvZHpBeWhRNFhSVmhoeDNSMStqbUxr?=
 =?utf-8?B?OGtGdEVnOWdRNDhoeGVzaEY0YVc0MEVmb2JkSzM2UTM1U3JnQlp0Tm45TUJ0?=
 =?utf-8?B?SGd1b2xjd0pSdU5neGcyU3Bsai91ZzFoSVBDcnRRbHBpb09DRDFrT1FhZ3Z6?=
 =?utf-8?B?Z3RXcDk3N01qeG5OTGE1UWxOZGZsMVVXdWE5RlUxeXJaaU0rM1k3a1pGWEhy?=
 =?utf-8?B?YW5SQlpYZ0ZIeEhpMVdJdGd6SmltOVFRa2dWTFNXRCtCVlBnVTE2S29XZDI2?=
 =?utf-8?B?WitGRlF4Q21ESmtyWWpJRVMxVE1qR2djS2VvYkV3SVJ4M2F5bklKaGxsc2U5?=
 =?utf-8?B?OVhHU2RhUmx2NnNFdjcydURDbEFMQUlEOVNMMDIwWFQ5cnBYSUY3SWlBNXJT?=
 =?utf-8?B?dUVrRFlXWXBOOWtDd0dqRHB4eVRpRkFFTDZtci9HU3cwNnlGVjJVL0VOclZv?=
 =?utf-8?B?OHZuMUxCQ005Rm01aDZuenE5Z3dVUFQ4dFpSSVlBSkdkYStGSXpJd2ZMQlNP?=
 =?utf-8?B?RUE2RDE1OXdpTk9sL1VqWTcwYUpmSk5aRE5qTDlGZUFqbEhNWXM3Mktsbnp2?=
 =?utf-8?B?c2MvM2svcFJJZi9ML0R2ZlNEK1l6UmhLTjYzOTVVUGdmbGVoZzFsTWhoMHNZ?=
 =?utf-8?B?MHA0U1B3eDBWR2Zwem0wZGdZRHVDdWtnazJ0V0xiK01yampybm02dmdDSlFC?=
 =?utf-8?B?Zk1tM1lJeXovMWJGWnFhcGQ5cU1qcldjSTNPTjVPRUNXbUZNUWxvd29VWU5P?=
 =?utf-8?B?UDJSN2lKQTMzUDZNQXBiVjQ4b2k1NUxFdTFzb0JJS3NWU2MyZEFkUEhzdUNJ?=
 =?utf-8?B?R3l1aUZTb0U4Z1NLQ3BqNHE1eXRQWStFYjhuOFhqWVBCd3FLZWdWL0IrZWxQ?=
 =?utf-8?B?d29mYWQxaXZwcFcyRFVVb0ZIendGRXVoaWlLUmxyNFFreWJuYWRnRUxMTzZa?=
 =?utf-8?B?R3ZMN1ZTbjZXZHlXMEQzSDcrbGV5NThBSTA5TWNKWVBEVk1STWNiZng2OWNt?=
 =?utf-8?B?eU9uUVREUEg5T25jRXRYWTdpeUEwcDUxR2x5cng5bXdIT1lwVlRFZkM5Szg4?=
 =?utf-8?B?dXMvZjQySGhtUmtVVXZsTDMyd0RSSXpTVkluL25KZm9HRDAwYzhWdG1xbGh4?=
 =?utf-8?B?cnV5TzdKdUtWaSsvazY1TFNmS2IzS0NjZDFqMWc4MUVRUG5JYkhEUlA3cUlX?=
 =?utf-8?B?UTV2ZC9qbmRLcUthNkg5V2wrYkU5bzJGak80UXRpVWVXREpWQkNpSEI4dDYw?=
 =?utf-8?B?a0hDVHB1SWx5bU1PMzdFZWhOVkZWcHQ3QXlJWm9IL2s0YS9XM2QxZWFabFo0?=
 =?utf-8?B?RTR3N3ZTRTVBMXF1VGhiUlZKSG1DS01aRW9nYWtRcnZpc2xsOGJseDA1QWY0?=
 =?utf-8?B?TDhlZDdyZTNZTDhXdEphOUNQY0JOMkxBVHdMYUFxbkFYVzlZdE12VEFSVVpw?=
 =?utf-8?B?eUNHT0tISFQzcGJTY3FiRW02dlBSbmp4SUNhWFNHc1NSMFB4UWM1T0NUR0xa?=
 =?utf-8?B?bzV0Y1dVaEhsQURUVlpUWUJkQmpxU3I2aERUWEFOdVBuUFFCYmIvN1ZTZHJ5?=
 =?utf-8?B?ZEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 02a2294d-59ad-4dec-586a-08dc711fcbef
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 18:34:16.0879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cneuZo3vvHiUOjaAycejKgrCtSaGk48k45WVJ/H+LyHJli3eC73LaUVsssts4wYqad/YXStJFUBdHkwnc+2JuggyF2WVqdMC/8zuk0TqAgQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5040
X-OriginatorOrg: intel.com

Hi Babu,

On 5/10/2024 10:01 AM, Moger, Babu wrote:
> On 5/9/2024 10:18 PM, Reinette Chatre wrote:
>> On 5/9/2024 3:34 PM, Moger, Babu wrote:
>>> On 5/7/24 15:27, Reinette Chatre wrote:
>>>> On 5/6/2024 12:09 PM, Moger, Babu wrote:
>>>>> On 5/3/24 18:26, Reinette Chatre wrote:
>>>>>> On 3/28/2024 6:06 PM, Babu Moger wrote:
>>>>
>>>> ...
>>>>
>>>>>>> + * @mbm_assign_cntrs:    Maximum number of assignable counters
>>>>>>>    */
>>>>>>>   struct rdt_resource {
>>>>>>>       int            rid;
>>>>>>> @@ -188,6 +198,8 @@ struct rdt_resource {
>>>>>>>       struct list_head    evt_list;
>>>>>>>       unsigned long        fflags;
>>>>>>>       bool            cdp_capable;
>>>>>>> +    bool            mbm_assign_capable;
>>>>>>> +    u32                     mbm_assign_cntrs;
>>>>>>>   };
>>>>>>
>>>>>> Please check tabs vs spaces (in this whole series please).
>>>>>
>>>>> Sure. Will do.
>>>>>
>>>>>>
>>>>>> I'm thinking that a new "MBM specific" struct within
>>>>>> struct rdt_resource will be helpful to clearly separate the MBM related
>>>>>> data. This will be similar to struct resctrl_cache for
>>>>>> cache allocation and struct resctrl_membw for memory bandwidth
>>>>>> allocation.
>>>>>
>>>>> Did you mean to move all the fields for monitoring to move to new struct?
>>>>>
>>>>> Struct resctrl_mbm {
>>>>>            int                     num_rmid;
>>>>>            bool                    mbm_assign_capable;
>>>>>            u32                     mbm_assign_cntrs;
>>>>> }:
>>>>>
>>>>
>>>> Indeed, so not actually MBM specific but monitoring specific as you state (with
>>>> appropriate naming?). This is purely to help organize data within struct rdt_resource
>>>> and (similar to struct resctrl_cache and struct resctrl_membw) not a new
>>>> structure expected to be passed around. I think evt_list can also be a member.
>>>
>>> How about this?
>>>
>>> Lets keep assign_capable in main structure(like we have mon_capable) and
>>> move rest of them into new structure.
>>>
>>> Struct resctrl_mon {
>>>             int                     num_rmid;
>>>        struct list_head        evt_list;
>>>             u32                     num_assign_cntrs;
>>> }:
>>
>> This looks like a good start. It certainly supports ABMC. I do not yet
>> have a clear understanding about how this will support MPAM and soft-RMID/ABMC
>> since the current implementation has an implicit scope of one counter per event per
>> monitor group. It thus seem reasonable to have a new generic name of "cntrs".
> 
> How about renaming it to "assignable_counters"?
> 

As I mentioned in [1] the "assign" concept is not clear (just to me perhaps?). It
really seems to be the marketing name percolating into the implementation. Why is
"assignable" needed to be in a "counter" variable name? Is a variable not by definition
"assignable"? Why not just, for example, "num_cntrs"? I believe that things to be
as simple and obvious as possible ... this just helps to reduce confusion.

My previous comment regarding counter scope is not addressed by a rename though and
I do not expect you to have the answer but I would like us to keep in mind how these
"counters" could end up getting used. We may just later, when soft-RMID/ABMC and MPAM
is understood, need to add a "counter scope" as well.

Reinette

[1] https://lore.kernel.org/lkml/0d94849c-828c-4f10-a6f8-e26cc4554909@intel.com/