Received-SPF: pass (google.com: domain of linux-kernel+bounces-176111-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 10 May 2024 14:42:53 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: David Hildenbrand <david@redhat.com>, mhiramat@kernel.org,
 linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
 mathieu.desnoyers@efficios.com, kernel-team@android.com,
 rdunlap@infradead.org, rppt@kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v22 2/5] ring-buffer: Introducing ring-buffer mapping
 functions
Message-ID: <20240510144253.4b865a40@rorschach.local.home>
In-Reply-To: <Zj3-8GHR_EiWY7lB@google.com>
References: <20240430111354.637356-1-vdonnefort@google.com>
	<20240430111354.637356-3-vdonnefort@google.com>
	<20240507223402.206d6ddc@rorschach.local.home>
	<cc719813-ba73-461f-8b45-4728f926c151@redhat.com>
	<Zj3-8GHR_EiWY7lB@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 10 May 2024 12:03:12 +0100
Vincent Donnefort <vdonnefort@google.com> wrote:

> > I'm not particularly happy about us calling vm_insert_pages with NULL
> > pointers stored in pages.
> > 
> > Should we instead do
> > 
> > if (WARN_ON_ONCE(s >= nr_subbufs)) {
> > 	err = -EINVAL;
> > 	goto out;
> > }
> > 
> > ?  
> 
> I could also nr_pages = p in the event of s >= nr_subbufs... but that
> really that shouldn't happen so let's return an error.

I'm good with this. It should never happen anyway.

-- Steve