Received-SPF: pass (google.com: domain of linux-kernel+bounces-176141-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Dongli Zhang <dongli.zhang@oracle.com>
To: x86@kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, joe.jin@oracle.com,
        linux-kernel@vger.kernel.org, virtualization@lists.linux.dev
Subject: [PATCH RESEND 1/1] x86/vector: Fix vector leak during CPU offline
Date: Fri, 10 May 2024 12:21:10 -0700
Message-Id: <20240510192110.117175-1-dongli.zhang@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?UQYnnW0Hfvl5HFGYRYG95hq3DhJnJ8ZT+iRMJ+Ju/JUrca0dT2iu/cnt5s8L?=
 =?us-ascii?Q?94HAPjgLPcykuyKwZOaVnj6LcafwoSSGMMxV7oKzGlrsS/grcfIWvOvjwVEu?=
 =?us-ascii?Q?Wk+2eLUC7Nk0Fkqtz7AwkJw1rV0UPtDrRtJSCP+m5h/+WrBG4Al6f4H1dB9K?=
 =?us-ascii?Q?Z3Iwur9jnEWB13AE1Krt1ldZKrM27Xr7LAH2ZLrV969TZ6WxRHdjm2tarE+m?=
 =?us-ascii?Q?fmidj/bx21Fy15kmrNo7ReA63O9C/ZdrQrecYyyCFTf2fkJdxSfPkzk1dgFH?=
 =?us-ascii?Q?4F8T8UjwIe9lI19PoBvlMaLpfQBJChGjg1YM/Pdt/d2+siuNV/N0q9T70rQ+?=
 =?us-ascii?Q?1WjsqLi6yUcFH2EIwJVi9nW9xRioZ2iQ+wuMf2gLdEWBQzH5VnDTSI4vjHXo?=
 =?us-ascii?Q?CLqHXpBgq8+3rLFBqCyBuYZX5L7DD6NqDVI6aZrlT6OE0Fxug2SUYXhpeAVH?=
 =?us-ascii?Q?4mZTQrA2UHskEQtoeth6YOkuqYPTusODZpciJKxi1EBk7pP8fVYeLF72CpTF?=
 =?us-ascii?Q?8TfuWz0pMGiKafyXm40i5uhjCI9Nhl3R+FKiuBxfv7qhZ3r2NOHYLAt1zbiz?=
 =?us-ascii?Q?alH7eYvXMMAX1jE33CmfPuZVQkrkRiSqcwaw5YDHa6aK2XxViU7AWJt+TrWG?=
 =?us-ascii?Q?YCC3GKcAomtuAAVfdnZLBILpsDVDSMMotgfX02VsQvRFVqxeCeozX4dsaeng?=
 =?us-ascii?Q?QEjPq2U3LMwqQ6o9FCc50iqeq1zOaIzOY+l1npGGM0GZNEQvTHyr3UpnDb+7?=
 =?us-ascii?Q?VcrEN405ylXrIOqubxfW3x5UpW6Tpj1dOvM7BTTY7sAMNWkklUzlPk/+4uwY?=
 =?us-ascii?Q?IHtnVlaojZHKw3hMz5YEiFef6UvrRFqlYSrOxsenHfyBHfer21UA9mMgTPZI?=
 =?us-ascii?Q?FF9x6t9v3HGWfrfQWfEvfHjphAszhBIsWVIj+CPBnBoGcAXn6gsbEaVMoZ0S?=
 =?us-ascii?Q?igXZ9doSNHZYrXVtMuUyTiEnn6xmC0JpTIYSJMC2XBv6Bz5+IRKuQhM5P6oy?=
 =?us-ascii?Q?FC8tIesTyP6d4HTUJZoZzlhSgCOSc9UKMXSDQbSFaYGoICynelmgxVWRyzDW?=
 =?us-ascii?Q?DUgkaTw4riju4n3HhRGS1MU6ut3iVU+4LSGPJROkLomHkG19HwA5lOdHbsLl?=
 =?us-ascii?Q?X0duNC9gDyqdBSQj/GJXDXE3/KQ1UlO7e0j9Hi1IY/qYzsP0i0VL6DPgT3Lr?=
 =?us-ascii?Q?e+P0SJvyieNvXorpZt6M+n5WptaC4kYr8iBLpv3Nr5vllRTssjIew1p/NCh7?=
 =?us-ascii?Q?ldp3jMjrYqHTrnDUQyTy62zREkzeA3bDRf/Dc7YXtb7O7iNnpyvpnRFIFj/B?=
 =?us-ascii?Q?rzThX0dn1Gms5tnbeTtqmIuwTHxlJWNy5UlBehP7FiXZDlLnASqKg4J/JJw5?=
 =?us-ascii?Q?dLYQjHqD/ge0QQc0aCZeYHo35yx/gPT/+KO9sJIPxtKaE5cMMu9IrL3k980P?=
 =?us-ascii?Q?IhRQJjhDKyzqVGU3lwApJ1RumVs8ehHi2JBpmHHy+Hiqzm5saUWzy3GtGEmj?=
 =?us-ascii?Q?m/y2ANfMni7HjzNX8R3uaXatl4P6cbx/Nf4wfTqAwOIoOidc/m7aUl9lunWY?=
 =?us-ascii?Q?3SBb4Et/O4/jEL6A/2Zhrszl2EjB2K/bz9q03VuFgC+dVMBdsGmZuXxGp43P?=
 =?us-ascii?Q?8Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	P2SeT7ApEhJ8P/1NiRKXm4Tlb99ZuiRdGeYq2pgF5fZ3WM27QRfu++cUAPiF4uV66OnDU+QYAObgLDodCUX6AmwBgoaCT34LbsfdgRtr/h8yRJpFcmH/c39Lf2S6EGdWtjFk/twye8iYFpu47gC7ivJuAM9Dfz81gmCZbo5T2oPs4QpFxJYrtfjlu7NOcGWQd4MJ3zhoK8oqyvDty8w0EVS2mYqhKfUX+qXRK8tSZJxrp95IuZmX+26/pApMeP3oYxpMP94FU6uSpRavRNWX20ktj08+SXHwiF+K83B5bfG5edTvKAMEkMTho2teJWI+TvCvcmW26EY+l7bvOomrC7KxI+DejotUkR/wzvjwrQ/fIF5vOlEZoCmJtXPQOvl8TsC09FiC44JueE8y8GXbgqSDJSyEf5vfiOkhSiNy/7wW5I75+oXRd+rKzz7YPZMzu94HE5Yb4zWxldotEMkd8AY5JzJEijR2nQRCL53m5f+1fpugRb17rGEJp7IRPHYziy4K7Trpbj7h61rEr+OwPdwkjGJRCWjazC2Y61zjmOmAt9lOODKhRWO8VnIc5ywoRfxx+YtQhX0uVxdm4wpcJfEaCxzXjkqiEukgzG4MQkw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 261e65b3-a19c-4d76-9fb9-08dc7127129a
X-MS-Exchange-CrossTenant-AuthSource: SA0PR10MB6425.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 19:26:21.0439
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oh6xv9FVP4MUPNEAJnXQiVHDHVjqq1v6eEUrrf1j6l873QEvmyaJ+ZB6S32mQenG5FmF6pZlZ5dxBn1wiiKO7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7223
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-10_14,2024-05-10_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 malwarescore=0
 mlxlogscore=999 phishscore=0 mlxscore=0 suspectscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405100138
X-Proofpoint-ORIG-GUID: BYWqXiXWS8YMVHWWWVw6BbKAWaAbyT_H
X-Proofpoint-GUID: BYWqXiXWS8YMVHWWWVw6BbKAWaAbyT_H

The absence of IRQD_MOVE_PCNTXT prevents immediate effectiveness of
interrupt affinity reconfiguration via procfs. Instead, the change is
deferred until the next instance of the interrupt being triggered on the
original CPU.

When the interrupt next triggers on the original CPU, the new affinity is
enforced within __irq_move_irq(). A vector is allocated from the new CPU,
but if the old vector on the original CPU remains online, it is not
immediately reclaimed. Instead, apicd->move_in_progress is flagged, and the
reclaiming process is delayed until the next trigger of the interrupt on
the new CPU.

Upon the subsequent triggering of the interrupt on the new CPU,
irq_complete_move() adds a task to the old CPU's vector_cleanup list if it
remains online. Subsequently, the timer on the old CPU iterates over its
vector_cleanup list, reclaiming vectors.

However, if the old CPU is offline before the interrupt triggers again on
the new CPU, irq_complete_move() simply resets both apicd->move_in_progress
and apicd->prev_vector to 0. Consequently, the vector remains unreclaimed
in vector_matrix, resulting in a CPU vector leak.

To address this issue, the fix borrows from the comments and implementation
of apic_update_vector(): "If the target CPU is offline then the regular
release mechanism via the cleanup vector is not possible and the vector can
be immediately freed in the underlying matrix allocator.".

Cc: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
Correct the email of bp@alien8.de. Sorry for my fault. 

 arch/x86/kernel/apic/vector.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
index 185738c72766..aad189a3bac9 100644
--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -1036,6 +1036,15 @@ static void __vector_schedule_cleanup(struct apic_chip_data *apicd)
 			add_timer_on(&cl->timer, cpu);
 		}
 	} else {
+		/*
+		 * This call borrows from the comments and implementation
+		 * of apic_update_vector(): "If the target CPU is offline
+		 * then the regular release mechanism via the cleanup
+		 * vector is not possible and the vector can be immediately
+		 * freed in the underlying matrix allocator.".
+		 */
+		irq_matrix_free(vector_matrix, apicd->prev_cpu,
+				apicd->prev_vector, apicd->is_managed);
 		apicd->prev_vector = 0;
 	}
 	raw_spin_unlock(&vector_lock);
-- 
2.39.3