Received-SPF: pass (google.com: domain of linux-kernel+bounces-176164-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <27cd559d7cc47fe38437570e57ec7a99.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <c3c9a75ed77a5ef2e9b72081e88225d84bba91cd.1715359776.git.christophe.jaillet@wanadoo.fr>
References: <c3c9a75ed77a5ef2e9b72081e88225d84bba91cd.1715359776.git.christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] clk: qcom: Constify struct pll_vco
From: Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org
To: Bjorn Andersson <andersson@kernel.org>, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Michael Turquette <mturquette@baylibre.com>
Date: Fri, 10 May 2024 13:14:37 -0700
User-Agent: alot/0.10

Quoting Christophe JAILLET (2024-05-10 09:50:00)
> pll_vco structure are never modified. They are used as .vco_table in
> "struct clk_alpha_pll".
>=20
> And in this structure, we have:
>         const struct pll_vco *vco_table;
>=20
> Constifying these structures moves some data to a read-only section, so
> increase overall security.
>=20
> On a x86_64, with allmodconfig:
> Before:
>    text    data     bss     dec     hex filename
>    9905   47576       0   57481    e089 drivers/clk/qcom/mmcc-msm8994.o
>=20
> After:
>    text    data     bss     dec     hex filename
>   10033   47440       0   57473    e081 drivers/clk/qcom/mmcc-msm8994.o
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>