Received-SPF: pass (google.com: domain of linux-kernel+bounces-176183-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>,
 Tony Luck <tony.luck@intel.com>, linux-acpi@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
 Dan Williams <dan.j.williams@intel.com>
Subject:
 Re: [RFC PATCH v2 3/3] ACPI: extlog: Make print_extlog_rcd() log
 unconditionally
Date: Fri, 10 May 2024 22:54:03 +0200
Message-ID: <2881368.Ex9A2HvPv6@fdefranc-mobl3>
In-Reply-To: <20240510192556.GDZj50xFIWSqK2gzQR@fat_crate.local>
References:
 <20240510112740.667445-1-fabio.m.de.francesco@linux.intel.com>
 <7009544.jJDZkT8p0M@fdefranc-mobl3>
 <20240510192556.GDZj50xFIWSqK2gzQR@fat_crate.local>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On Friday, May 10, 2024 9:25:56=E2=80=AFPM GMT+2 Borislav Petkov wrote:
> On Fri, May 10, 2024 at 09:00:34PM +0200, Fabio M. De Francesco wrote:
> > I thought that ELOG and GHES should be modeled consistently. ghes_proc()
> > prints to the console while ghes_do_proc() also uses ftrace.
>=20
> ghes_proc() calls ghes_do_proc(). I have no clue what you mean here.
>

My understanding is that ghes_proc() logs to the console and ghes_do_proc()=
=20
calls the tracers.=20

Therefore, GHES at the same time always reports the errors via two differen=
t=20
means.

Instead ELOG depends on the check on ras_userspace_consumers() to decide=20
whether to call print_extlog_rcd() to print the logs. And if it print to th=
e=20
kernel logs, it jumps to "out" and skips the tracers.

Why is it different with respect to how error reporting is made in GHES?=20

I thought that ELOG should be modeled similarly to GHES and so it should pr=
int=20
to the kernel logs always unconditionally and then it should also use ftrac=
e=20
(no goto "out" and skip tracers).

(1) Is my understanding of logging and tracing in ELOG and GHES correct?
(2) If it is, does it make sense for ELOG to print to the kernel log,=20
unconditionally, and then call the tracers like ghes_proc() + ghes_do_proc(=
)=20
do?

=46abio