Received-SPF: pass (google.com: domain of linux-kernel+bounces-176233-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 10 May 2024 22:26:22 +0100
From: Conor Dooley <conor@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Alisa-Dariana Roman <alisadariana@gmail.com>,
	michael.hennerich@analog.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	alexandru.tachici@analog.com, lars@metafoo.de, jic23@kernel.org,
	robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
	andy@kernel.org, nuno.sa@analog.com, marcelo.schmitt@analog.com,
	bigunclemax@gmail.com, okan.sahin@analog.com, fr0st61te@gmail.com,
	alisa.roman@analog.com, marcus.folkesson@gmail.com,
	schnelle@linux.ibm.com, liambeguin@gmail.com
Subject: Re: [PATCH v7 5/6] dt-bindings: iio: adc: ad7192: Add AD7194 support
Message-ID: <20240510-figure-cotton-1edeb2b92bbd@spud>
References: <20240430162946.589423-1-alisa.roman@analog.com>
 <20240430162946.589423-6-alisa.roman@analog.com>
 <20240430-winnings-wrongness-32328ccfe3b5@spud>
 <73365049-670b-4068-a159-fbdd0539f5a9@gmail.com>
 <d5b8b193-0694-4e65-9b0a-64fa689ed344@baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="i4THszHJQ+zcpyur"
Content-Disposition: inline
In-Reply-To: <d5b8b193-0694-4e65-9b0a-64fa689ed344@baylibre.com>


--i4THszHJQ+zcpyur
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 10, 2024 at 09:21:37AM -0500, David Lechner wrote:
> On 5/10/24 5:05 AM, Alisa-Dariana Roman wrote:
> > On 30.04.2024 20:21, Conor Dooley wrote:
> >> On Tue, Apr 30, 2024 at 07:29:45PM +0300, Alisa-Dariana Roman wrote:
> >>> +=A0=A0=A0=A0=A0 diff-channels:
> >>> +=A0=A0=A0=A0=A0=A0=A0 description:
> >>> +=A0=A0=A0=A0=A0=A0=A0=A0=A0 Both inputs can be connected to pins AIN=
1 to AIN16 by choosing the
> >>> +=A0=A0=A0=A0=A0=A0=A0=A0=A0 appropriate value from 1 to 16.
> >>> +=A0=A0=A0=A0=A0=A0=A0 items:
> >>> +=A0=A0=A0=A0=A0=A0=A0=A0=A0 minimum: 1
> >>> +=A0=A0=A0=A0=A0=A0=A0=A0=A0 maximum: 16
> >>> +
> >>> +=A0=A0=A0=A0=A0 single-channel:
> >>> +=A0=A0=A0=A0=A0=A0=A0 description:
> >>> +=A0=A0=A0=A0=A0=A0=A0=A0=A0 Positive input can be connected to pins =
AIN1 to AIN16 by choosing the
> >>> +=A0=A0=A0=A0=A0=A0=A0=A0=A0 appropriate value from 1 to 16. Negative=
 input is connected to AINCOM.
> >>> +=A0=A0=A0=A0=A0=A0=A0 items:
> >>> +=A0=A0=A0=A0=A0=A0=A0=A0=A0 minimum: 1
> >>> +=A0=A0=A0=A0=A0=A0=A0=A0=A0 maximum: 16
> >>
> >> Up to 16 differential channels and 16 single-ended channels, but only =
16
> >> pins? Would the number of differential channels not max out at 8?
> >=20
> > Hello, Conor! I really appreciate the feedback!
> >=20
> > The way I thought about it, the only thing constraining the number of c=
hannels is the reg number (minimum: 0, maximum: 271). 272 channels cover al=
l possible combinations (16*16 differential and 16 single ended) and I thou=
ght there is no need for anything stricter. I added items: minimum:1 maximu=
m:16 to make sure the numbers are from 1 to 16, corresponding to AIN1-AIN16.
> >=20
> > Please let me know what should be improved!
> >=20
> > Kind regards,
> > Alisa-Dariana Roman.
> >=20
>=20
> Having looked at the datasheet for this and other similar chips, I agree
> that this reasoning makes sense. Some of the similar chips that have fixed
> channel assignments still have, e.g. a channel where + and - are both
> AIN2 (I assume for diagnostics). So I think it makes sense to allow for
> doing something similar here even if the most common use cases will
> probably have at most 16 channels defined in the .dts.

Actually, I think there were a bunch of whiffs on this one by either
misreading the property in question (me) or not realising that I had done
that and trying to explain what the possible combinations are.
Looking at it now, I dunno wtf I was smoking because there's no way that
this would be a functional binding if the min/max in the quote above
constraining the number of channels. I can hardly blame y'all for that
though, I am supposed to know how bindings work after all...

--i4THszHJQ+zcpyur
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZj6Q/gAKCRB4tDGHoIJi
0jZgAP4t1kxmrJ2JJSskA6bOUNUVp7bftPdSBLKpqLDza7OBRgD+PJKBgBmrXiZD
waVTQqZrXribrQ/vRoRJHn6ayrvD/g8=
=d7Qc
-----END PGP SIGNATURE-----

--i4THszHJQ+zcpyur--