Received-SPF: pass (google.com: domain of linux-kernel+bounces-176123-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>,
 Tony Luck <tony.luck@intel.com>, linux-acpi@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
 Dan Williams <dan.j.williams@intel.com>
Subject:
 Re: [RFC PATCH v2 3/3] ACPI: extlog: Make print_extlog_rcd() log
 unconditionally
Date: Fri, 10 May 2024 21:00:34 +0200
Message-ID: <7009544.jJDZkT8p0M@fdefranc-mobl3>
In-Reply-To: <20240510125214.GCZj4YfluoP-mDz3_U@fat_crate.local>
References:
 <20240510112740.667445-1-fabio.m.de.francesco@linux.intel.com>
 <20240510112740.667445-4-fabio.m.de.francesco@linux.intel.com>
 <20240510125214.GCZj4YfluoP-mDz3_U@fat_crate.local>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On Friday, May 10, 2024 2:52:14=E2=80=AFPM GMT+2 Borislav Petkov wrote:
> On Fri, May 10, 2024 at 01:21:47PM +0200, Fabio M. De Francesco wrote:
> > Make extlog_print_rcd() log unconditionally to report errors even if
> > userspace is not consuming trace events. Remove ras_userspace_consumers=
()
> > because it is not anymore used.
>=20
> Did you do any git archeology before that?
>=20
> d6cae935ec5b ("trace, eMCA: Add a knob to adjust where to save event log")
>=20
> I can't find in this commit message why this is needed... Do share pls.=20
>=20
> > This change makes extlog_print() (ELOG) log consistently with ghes_proc=
()
> > (GHES).

I thought that ELOG and GHES should be modeled consistently. ghes_proc()=20
prints to the console while ghes_do_proc() also uses ftrace. I made this sh=
ort=20
series an RFC mainly to ask / receive comments on this change (3/3).

If we want to make ELOG and GHES act similarly, this patch is needed.=20
Otherwise, things should be left the way they currently are.=20

I'll make a v3  with a more clear explanation of why I think we should pref=
er=20
to make ELOG act similarly to GHES in how kernel logs are handled.

> Avoid having "This patch" or "This commit" in the commit message. It is
> tautologically useless.
>
> Also, do
>=20
> $ git grep 'This patch' Documentation/process
>=20
> for more details.
>=20
> Pls have a look at our documentation and check all your patches.
>=20
> Thx.

Please note that I was introducing the "why" part of the message. I never=20
refer to this patch for the "what", and I always use an imperative tone onl=
y=20
in the "what" part.=20

However, I see why this commit message was poor. And probably also the othe=
r=20
two were low quality. Therefore, I'll rework this and also the other two=20
messages.

Thanks for your comments,

=46abio