Received-SPF: pass (google.com: domain of linux-kernel+bounces-176266-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <f9afdda4-0921-4632-8e4a-e8157b685da1@linaro.org>
Date: Fri, 10 May 2024 23:18:30 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/8] media: qcom: camss: Add per sub-device type
 resources
To: Gjorgji Rosikopulos <quic_grosikop@quicinc.com>, rfoss@kernel.org,
 todor.too@gmail.com, bryan.odonoghue@linaro.org, andersson@kernel.org,
 konrad.dybcio@linaro.org, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
 linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com,
 hverkuil-cisco@xs4all.nl, quic_hariramp@quicinc.com,
 matti.lehtimaki@gmail.com
References: <20240411124543.199-1-quic_grosikop@quicinc.com>
 <20240411124543.199-2-quic_grosikop@quicinc.com>
Content-Language: en-US
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
In-Reply-To: <20240411124543.199-2-quic_grosikop@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 11/04/2024 13:45, Gjorgji Rosikopulos wrote:
> +		.type = CAMSS_SUBDEV_TYPE_CSIPHY,

As Matti pointed out to me on IRC, the .type value here isn't populated 
in the rest of the 8280xp resources.

I completely missed that but, then again this appears to be a dead field 
in this series so it makes no difference if it is populated.

I realise it is probably of use in code you _haven't_ yet published but, 
for now I think we should drop this field, since its dead code.

I'll send a fixup patch for this, I don't think there's a need for you 
to send the whole series again.

---
bod