Received-SPF: pass (google.com: domain of linux-kernel+bounces-176416-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 10 May 2024 21:42:31 -0700
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Yujie Liu <yujie.liu@intel.com>
Cc: kernel test robot <lkp@intel.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Boqun Feng <boqun.feng@gmail.com>,
	"Joel Fernandes (Google)" <joel@joelfernandes.org>
Subject: Re: ERROR: modpost: vmlinux: local symbol
 'rcu_set_jiffies_lazy_flush' was exported
Message-ID: <231e2516-d54b-4cd6-8564-ba2cecd4798f@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <202405110230.vcpgN5vz-lkp@intel.com>
 <965221ae-620a-497a-9a80-5725e3fe3f7b@paulmck-laptop>
 <Zj7do9o265Rrm1HD@yujie-X299>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zj7do9o265Rrm1HD@yujie-X299>

On Sat, May 11, 2024 at 10:53:23AM +0800, Yujie Liu wrote:
> On Fri, May 10, 2024 at 12:09:02PM -0700, Paul E. McKenney wrote:
> > On Sat, May 11, 2024 at 02:53:06AM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   f4345f05c0dfc73c617e66f3b809edb8ddd41075
> > > commit: 499d7e7e83d25fcf0fa1a8c0be6857a84cbf6a4a rcu: Rename jiffies_till_flush to jiffies_lazy_flush
> > > date:   3 months ago
> > > config: riscv-randconfig-r021-20230817 (https://download.01.org/0day-ci/archive/20240511/202405110230.vcpgN5vz-lkp@intel.com/config)
> > > compiler: riscv32-linux-gcc (GCC) 13.2.0
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240511/202405110230.vcpgN5vz-lkp@intel.com/reproduce)
> > > 
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202405110230.vcpgN5vz-lkp@intel.com/
> > > 
> > > All errors (new ones prefixed by >>, old ones prefixed by <<):
> > > 
> > > >> ERROR: modpost: vmlinux: local symbol 'rcu_set_jiffies_lazy_flush' was exported
> > > >> ERROR: modpost: vmlinux: local symbol 'rcu_get_jiffies_lazy_flush' was exported
> > 
> > These do not look to me to be local:
> > 
> > 	void rcu_set_jiffies_lazy_flush(unsigned long jif)
> > 	{
> > 		jiffies_lazy_flush = jif;
> > 	}
> > 	EXPORT_SYMBOL(rcu_set_jiffies_lazy_flush);
> > 
> > 	unsigned long rcu_get_jiffies_lazy_flush(void)
> > 	{
> > 		return jiffies_lazy_flush;
> > 	}
> > 	EXPORT_SYMBOL(rcu_get_jiffies_lazy_flush);
> > 
> > What am I missing here?
> 
> Sorry this is a false positive. We will fix the bot to handle
> this case correctly. 

No problem, and I do know that feeling!  Thank you for your testing
efforts!!!

							Thanx, Paul