Received-SPF: pass (google.com: domain of linux-kernel+bounces-176455-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 11 May 2024 15:45:53 +0800
From: Chen Yu <yu.c.chen@intel.com>
To: Ravi Bangoria <ravi.bangoria@amd.com>
CC: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<namhyung@kernel.org>, <irogers@google.com>, <swapnil.sapkal@amd.com>,
	<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
	<jolsa@kernel.org>, <rostedt@goodmis.org>, <vincent.guittot@linaro.org>,
	<bristot@redhat.com>, <adrian.hunter@intel.com>, <james.clark@arm.com>,
	<kan.liang@linux.intel.com>, <gautham.shenoy@amd.com>,
	<kprateek.nayak@amd.com>, <juri.lelli@redhat.com>,
	<yangjihong@bytedance.com>, <linux-kernel@vger.kernel.org>,
	<linux-perf-users@vger.kernel.org>, <santosh.shukla@amd.com>,
	<ananth.narayan@amd.com>, <sandipan.das@amd.com>
Subject: Re: [RFC 4/4] perf sched schedstat: Add support for report subcommand
Message-ID: <Zj8iMV9vhyGC3tT9@chenyu5-mobl2>
References: <20240508060427.417-1-ravi.bangoria@amd.com>
 <20240508060427.417-5-ravi.bangoria@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240508060427.417-5-ravi.bangoria@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h05TRhWL436EMtReEhAo2kyNEZsNyj41sFgIAyApRsyTmudI7rUAxj0l6pFq?=
 =?us-ascii?Q?VPM/SXGajHeLx8vvMopFlqxFGf7VEQDAeQcmPagVM0KmoLV0ZNigsOvwSXKs?=
 =?us-ascii?Q?bi4CpbK02TjY1qDMN7RexVR4/ibnBSbQygUmmnQiKUzGWyvbcRJNz8ZLUWpX?=
 =?us-ascii?Q?o3XvGQh1kxWWCB/5WpnNohwb4YWG85I1EPD0xBptBk5dBbj5JYHwfhJNldjW?=
 =?us-ascii?Q?jLW6bKF4tEgVXp8j2hkP+Uiqr6lmmbdkngcOZH0lCm5XHAkOdCIvKDI4mU8Q?=
 =?us-ascii?Q?hDvRqaPt989wPm6TigQFpZL7IKs7v0Uef+pSf0OHNOmOFJ96ko0PA0TE+mbN?=
 =?us-ascii?Q?XMhHUCJlZmmrkM6XHfxdt/966u0oLiQtDDEsQRqxPSRDu2EKISxsNmJs2+ht?=
 =?us-ascii?Q?sbwmm4bOuPZ5MoWd0L+fXQCU9PYUxXpffJN4oqumE7nwLHnj/ZOPms3mMnp/?=
 =?us-ascii?Q?jSQMjbfD6gBy4UMwop+OJWPy/AItyNDSY9WFi44OiosoKmZVaZOsxTrpsAcP?=
 =?us-ascii?Q?OHyFyY/JnkhNRPUIh+PJzzKxed919WG76la3iV1hsFa4cViB3ZEprjdr+Atq?=
 =?us-ascii?Q?r1VJ6gWBaaIsPmdpNlhn1Xbsl3vWZRBcGhwEbPBDtIUzVrF/T46sKCnxw1lW?=
 =?us-ascii?Q?BtM24XpmwtjOqd8F81lIDqwoGpKMGuH7D67UWgiXoPWqv4zJ6GYACZRJ3sxU?=
 =?us-ascii?Q?tFzZk09RfphDo7CRyF04W/71cZkSsRsI47qt5W6m1gd4POa3sEqJUkfWRa/l?=
 =?us-ascii?Q?YtVq54MjGpOkoADYocG94MYnSSp0wCLZB/R5aswXZQ0MByxg5UCbuzK9XJzc?=
 =?us-ascii?Q?DJaG38Clx62DpShOebCQ6z++eicrEROIFSjpR7PPpu7qeyr2vDWyBDzxZNld?=
 =?us-ascii?Q?Az7Ge2wNns1NRKGxHErdGJyJD4aWMXEq9/Mvx6kO1sxIkOXe1wUFcBb4VU8N?=
 =?us-ascii?Q?1cEnzfdMsi+39basyEQUNQFYojMu+aLbLloDgvXWeLAKvY4mHJweA+1RCERo?=
 =?us-ascii?Q?IvD3Nv8BfnRCWVsn+AJijCSED0t/s0HEn0ImNINju+C4Jc79VITrOqFTxv/J?=
 =?us-ascii?Q?hd5RNEWZ1qBzg9Bf8e2gRHYWN5Z7aEWkTZzt9Z4LZ3+KhyUghY8i09SKdkpa?=
 =?us-ascii?Q?bbs3VD7R7TYbN9QAkWcWHREwa4ZP1W1J3Jy7BeCmdpXeDTt9yGyLwXu6hfRe?=
 =?us-ascii?Q?EfAhSrjzsapSU8XEbY9aFW4WoCFqPuakOxubUXuIFk/0HK/ztpKn3OvLQnYw?=
 =?us-ascii?Q?60ri1u5PmrHI/WH3B+Hb513IXd8iRHJ2IVzs5n+lXGacbHr4e7m8vYnBqWEn?=
 =?us-ascii?Q?4eE5x40Bdtc4PyngH4AQFcuxgcpVEeBp57a2cWPG/1eAiYMtevvS9Gr9LkD0?=
 =?us-ascii?Q?mJKAhBv8+RNJrCHbzpRVhyYKNCsbvPMeWXwwZ+INLQS/H4YuwTRVtuVb0reC?=
 =?us-ascii?Q?2TbREVe5OpaFycGbUvwEXRfI/zISF1OertEmcRR7wiyPwy9FrRj6+MlEiguf?=
 =?us-ascii?Q?f0BTQ3w+/rJgh1Vg0Tn67gip8RlUjmCv30RNmGMK/VeVZphIj18YN+Kh1lyp?=
 =?us-ascii?Q?sPAGMWtvNtDX6NGAK1dtln/CRlf4TUQiTQpthaKw?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c06475f-b80d-482a-0902-08dc718e6cb0
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2024 07:46:10.4007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3I0RxHkNX+magSkWiesKu7OxceXVPE8nDrW7exyMihGY0RN0ORUFvlUCnX/bua/5NcHnUQvzu+uPxIVE5V1kGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6812
X-OriginatorOrg: intel.com

On 2024-05-08 at 11:34:27 +0530, Ravi Bangoria wrote:
> From: Swapnil Sapkal <swapnil.sapkal@amd.com>
> 
> `perf sched schedstat record` captures two sets of samples. For workload
> profile, first set right before workload starts and second set after
> workload finishes. For the systemwide profile, first set at the beginning
> of profile and second set on receiving SIGINT signal.
> 
> Add `perf sched schedstat report` subcommand that will read both the set
> of samples, get the diff and render a final report. Final report prints
> scheduler stat at cpu granularity as well as sched domain granularity.
> 
> Usage example:
> 
>   # perf sched schedstat record
>   # perf sched schedstat report
> 
> Co-developed-by: Ravi Bangoria <ravi.bangoria@amd.com>
> Signed-off-by: Swapnil Sapkal <swapnil.sapkal@amd.com>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>

I've tested it on a 240 CPUs Xeon system and it looks very useful. Thanks!

1. Just to confirm, if we want to add new fields for debugging purpose,
   schedstat-domain-v1x.h and schedstat-cpu-v1x.h are the only files to
   be touched, right?
2. Although we can filter the output, is it applicable to only track some
   CPUs? Like perf sched schedstat -C 4 record

thanks,
Chenyu