Received-SPF: pass (google.com: domain of linux-kernel+bounces-176521-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 11 May 2024 20:58:03 +0900
From: William Breathitt Gray <wbg@kernel.org>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: vigneshr@ti.com, jpanis@baylibre.com, linux-iio@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] counter: ti-ecap-capture: Handle error for clk_enable
Message-ID: <Zj9dSy63GIWQSe_j@ishi>
References: <20240510090059.2126666-1-nichen@iscas.ac.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="sMiffhJRWiWAmyPi"
Content-Disposition: inline
In-Reply-To: <20240510090059.2126666-1-nichen@iscas.ac.cn>


--sMiffhJRWiWAmyPi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 10, 2024 at 05:00:59PM +0800, Chen Ni wrote:
> As the potential failure of the clk_enable(), it should be better to
> check it and return error if fails.
>=20
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/counter/ti-ecap-capture.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/counter/ti-ecap-capture.c b/drivers/counter/ti-ecap-=
capture.c
> index 675447315caf..30a269fa5da0 100644
> --- a/drivers/counter/ti-ecap-capture.c
> +++ b/drivers/counter/ti-ecap-capture.c
> @@ -574,8 +574,11 @@ static int ecap_cnt_resume(struct device *dev)
>  {
>  	struct counter_device *counter_dev =3D dev_get_drvdata(dev);
>  	struct ecap_cnt_dev *ecap_dev =3D counter_priv(counter_dev);
> +	int ret;
> =20
> -	clk_enable(ecap_dev->clk);
> +	ret =3D clk_enable(ecap_dev->clk);
> +	if (ret)
> +		return ret;
> =20
>  	ecap_cnt_capture_set_evmode(counter_dev, ecap_dev->pm_ctx.ev_mode);
> =20
> --=20
> 2.25.1

Hi Chen,

Would you add a Fixes tag so we can pick this up for the stable kernels
too?

Thanks,

William Breathitt Gray

--sMiffhJRWiWAmyPi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZj9dSwAKCRC1SFbKvhIj
K8/wAQCVVSZwQZDUzxdIr/+KuCzooJAFd7NxCoG7kZttM8bV+gEAn5JeCDuljDN4
cVmWnRV9mHbP9SVYUmab5iYNnkM1Eg4=
=pcXp
-----END PGP SIGNATURE-----

--sMiffhJRWiWAmyPi--