Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp1054036lqo; Sat, 11 May 2024 05:44:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW2ebHB46DlzYUNUXXejl7/SRibj56J2sfeOvW5HsVNHeDQyXRZvyyC8xqszxBdfg3EOskyuIcsX3bclea7TPZWql3hgYDioxR7RmXsww== X-Google-Smtp-Source: AGHT+IHilhmFXL8Zch/3X1sWewIbAPcoTEojKbpSuHlSO0b0QKJTS2DniJdAIxxtN2ClXbuoTlI3 X-Received: by 2002:ac8:598a:0:b0:43a:f2be:6ce with SMTP id d75a77b69052e-43dfdd6a4f9mr60046061cf.60.1715431468066; Sat, 11 May 2024 05:44:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715431468; cv=pass; d=google.com; s=arc-20160816; b=JqAL488bZdGJbTbyk1ioEE9wAnjISF1b4FrMnn8CIWFBeXnLaWVKgu0PCVFIqkx8UI jgTNKpx5tZHB3wWVA2gN9nUGcsHhBq9llReCUA1vULX3pB3B+T48UseOMFjMn7U0NGCu rS3AYEFAXoWIX3Fr2u6loi9lMsP3R9GrDCc0FRRokoVzxZ5J6mOIIY00ft68Au7/vRXf coDTOI/G+2xJU1zcD85KXzJzGXurXs70v3wpq/yDnYcTo0akNF67MoOebi1GiUCmfzfk +RfOMKhQDiATk2XfUD2CvkrePFMRc0EtrbvJoLzNpB2pwFTeNlqFf39CeTTQf6Ro1FiB oNyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=BZ8Z0Aarz6dukVwTSg6oFxXKuRw0aMvSSKkaUBN7Jgo=; fh=/b8GFVbfjQRCkJgXde8X8VGYx52L9gi35CuevQFqWvY=; b=Q0zPtOJ8qsTCRx6nyAifLj7EwIdkpqDR0l1qhvUc3KC12OwRt4Lc7Hzt14uV04SjkE 9SxOetXl7Aqn2ixa7ddUGvN8LVaAt6l/zFp5yogKf3pvKDPwsRWHvO5Mu0Xh4Y03jo2p 5yWNF/1UaXa9t32KhyZPI6jA1s3nyQBstNOXcB1kRl3U5WePpSLE/azsc6DRMzoO6xhx sloKxFs/L3VHaFF9heJuT/ewDQ4i3ldkFeJD5nlH1rwu7GLlhv9PVUjPEyCz0wbGnUfw qGXMtJGMfinWsj5OzmU3gTSEhPx7iOLqx3o7WHkRpuyOnlDUdZx8vi8qwDVpqQPN9Cjl Qp2w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=BXYnukba; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-176540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176540-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-43df56d592fsi56901001cf.692.2024.05.11.05.44.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 May 2024 05:44:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-176540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=BXYnukba; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-176540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176540-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B291E1C20CED for ; Sat, 11 May 2024 12:44:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BF885027B; Sat, 11 May 2024 12:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BXYnukba" Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 376595028D; Sat, 11 May 2024 12:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715431457; cv=none; b=u+Dh+nfsBF6kmW7QscAib/1BVWe4hHWu7xBaCy+2AFLtKVmeRRwhfFypLrp6xxFbK4VriyCcaE6CfdkOdZ8xIPL0OfGEVLP2vJ2DgUzvIGLrS8S+loED5TY/Femb/8cFa2BvPie+8w36m5RysHTphOyqYGLGX3n0Gv4LGHHEfhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715431457; c=relaxed/simple; bh=rAGSY5+dD8abp+PN4nndzwx7t6kgk2/A0M4fxN9D+cQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=J4U0OR25VcdD9KUujT8N6qlcF4DiCfZE6v45LZq2KndAAqtJ1yQswJv2hMQk92f+tD0mLUrfx7kb/W5wNEXiUGjUjqq4qRJV/i1IS+Hc+PxjKS6Ezb9bbqE/j9CvfQLUS2Magk5qKmEz4B8rNAvDIbe5AiUcgJDI5YhjHrISeCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BXYnukba; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-34db6a299b2so2260976f8f.3; Sat, 11 May 2024 05:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715431454; x=1716036254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BZ8Z0Aarz6dukVwTSg6oFxXKuRw0aMvSSKkaUBN7Jgo=; b=BXYnukbavfvEKNwNX4rGv6dNqYcYz6QbxjFtxTKmXA4zjUFm5uqW/ep5c0bwwS2U9k VXO0yJzURRqdb5/2fQejaB/78S1h9RQdP03G4y3ZOu6Z5x0foZBMZnOIjgVQ9NnwfL7C d4XLzbv0KQoo1J+ArJaGqx12PavA8xlnqnfDbJEhwBCaVDq6j50w4PfAjzAizGkBpfkO npnnoH02KoDYBHGZdJ7Je2anErY66ioMQzC3n2QjxKz6p+qHupo5qBVdlaHKd0/066sz SYvRwqbZIRZsZf5iBcKNRV56j8EOotoNBlF/Egwb8NCKTeJ9nFX5HVkPmjfZjA6VEFWI yzBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715431454; x=1716036254; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BZ8Z0Aarz6dukVwTSg6oFxXKuRw0aMvSSKkaUBN7Jgo=; b=W9owI03d388hIL+8l9NjVaR+1kK8NezATLHYprMF4p0qDDXIj5ahjLlvXOx5yxmcqH 8RXmqvf9DgydAw9JGS0KmiLb5+r5Of9XulUIc+h+l+0sesR1TJi6OOeYRNMSQJkIA09m x0vmL/OBC5XTYkl/CyG/SY7CekHxElNLelO+LC/ihMfwPVrTpl0YSmf+oxaQAq9ETpIs kL15onaPs0pY6OeY2nQ8ZazXnK3kGJIqckrB2rTW14RU2b6NEBUPWwp1xbOZaXLYXAQV Bl96bDw7JdMFTUijSNRb+PFk9miyb2HzpDg9wIiC5/98NZ+6geTmpfYnhXEYFVwYvxuh SCmg== X-Forwarded-Encrypted: i=1; AJvYcCUT0oiGos332+IzZMEfe1ctekbCJfogBlD5WWVyTI8cRuA0xrnW/dVDjCDsq8QA836pZhGqtvUs5Pgw9LyAqq/BinrQlB9DJR56CnOgPRkj0uxqAzOGvfamiF6JlhHZy23oNCNa X-Gm-Message-State: AOJu0Yy/JbAiCy2QiSPINEpD3htMxsbZu+UIJkTRWzaTGzq1U6WI/VoM aIHP3vhtllw+dmtXQDAFH2dZzagEmOcjabqBLK28U20VQ7Zn74QD X-Received: by 2002:a05:600c:4f4e:b0:41b:a271:60a9 with SMTP id 5b1f17b1804b1-41feaa2f38bmr41453825e9.6.1715431454258; Sat, 11 May 2024 05:44:14 -0700 (PDT) Received: from localhost.localdomain (IGLD-84-229-253-184.inter.net.il. [84.229.253.184]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fd10cf8besm49870535e9.1.2024.05.11.05.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 May 2024 05:44:14 -0700 (PDT) From: Elad Yifee To: Cc: eladwf@gmail.com, Sam.Shih@mediatek.com, steven.liu@mediatek.com, bc-bocun.chen@mediatek.com, SkyLake.Huang@mediatek.com, Henry.Yen@mediatek.com, john@phrozen.org, Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net RFC] net: ethernet: mtk_eth_soc: ppe: add source port comparison Date: Sat, 11 May 2024 15:42:26 +0300 Message-ID: <20240511124230.13991-1-eladwf@gmail.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Resolve packet loss issue on the following conditions: - utilizing multiple GMACs - device has more than 4GB DRAM - using PPE Signed-off-by: Elad Yifee --- drivers/net/ethernet/mediatek/mtk_ppe.c | 4 ++++ drivers/net/ethernet/mediatek/mtk_ppe_regs.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/net/ethernet/mediatek/mtk_ppe.c b/drivers/net/ethernet/mediatek/mtk_ppe.c index 6ce0db3a1a92..6415ba618ebf 100644 --- a/drivers/net/ethernet/mediatek/mtk_ppe.c +++ b/drivers/net/ethernet/mediatek/mtk_ppe.c @@ -1053,6 +1053,10 @@ void mtk_ppe_start(struct mtk_ppe *ppe) MTK_PPE_GLO_CFG_IP4_L4_CS_DROP | MTK_PPE_GLO_CFG_IP4_CS_DROP | MTK_PPE_GLO_CFG_FLOW_DROP_UPDATE; + + if (mtk_is_netsys_v2_or_greater(ppe->eth)) + val |= MTK_PPE_GLO_CFG_SP_CMP_EN; + ppe_w32(ppe, MTK_PPE_GLO_CFG, val); ppe_w32(ppe, MTK_PPE_DEFAULT_CPU_PORT, 0); diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_regs.h b/drivers/net/ethernet/mediatek/mtk_ppe_regs.h index 3ce088eef0ef..61fea4b4b65b 100644 --- a/drivers/net/ethernet/mediatek/mtk_ppe_regs.h +++ b/drivers/net/ethernet/mediatek/mtk_ppe_regs.h @@ -18,6 +18,7 @@ #define MTK_PPE_GLO_CFG_UDP_LITE_EN BIT(10) #define MTK_PPE_GLO_CFG_UDP_LEN_DROP BIT(11) #define MTK_PPE_GLO_CFG_MCAST_ENTRIES GNEMASK(13, 12) +#define MTK_PPE_GLO_CFG_SP_CMP_EN BIT(25) #define MTK_PPE_GLO_CFG_BUSY BIT(31) #define MTK_PPE_FLOW_CFG 0x204 -- 2.44.0