Received-SPF: pass (google.com: domain of linux-kernel+bounces-176557-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 11 May 2024 14:24:07 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: Ramona Gradinariu <ramona.bolboaca13@gmail.com>,
 linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, conor+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, robh@kernel.org, nuno.sa@analog.com,
 oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v2 8/8] drivers: iio: imu: Add support for adis1657x
 family
Message-ID: <20240511142407.2401c6a1@jic23-huawei>
In-Reply-To: <202405110735.khNaHnAJ-lkp@intel.com>
References: <20240508131310.880479-9-ramona.bolboaca13@gmail.com>
	<202405110735.khNaHnAJ-lkp@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 11 May 2024 07:24:05 +0800
kernel test robot <lkp@intel.com> wrote:

> Hi Ramona,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on jic23-iio/togreg]
> [cannot apply to linus/master v6.9-rc7 next-20240510]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Ramona-Gradinariu/dt-bindings-iio-imu-Add-ADIS16501-compatibles/20240508-211559
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> patch link:    https://lore.kernel.org/r/20240508131310.880479-9-ramona.bolboaca13%40gmail.com
> patch subject: [PATCH v2 8/8] drivers: iio: imu: Add support for adis1657x family
> config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240511/202405110735.khNaHnAJ-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240511/202405110735.khNaHnAJ-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202405110735.khNaHnAJ-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from drivers/iio/imu/adis16475.c:16:
>    include/linux/iio/imu/adis.h:530:60: warning: 'struct iio_dev_attr' declared inside parameter list will not be visible outside of this definition or declaration
>      530 |                                               const struct iio_dev_attr **buffer_attrs);
>          |                                                            ^~~~~~~~~~~~
>    drivers/iio/imu/adis16475.c: In function 'adis16475_probe':
> >> drivers/iio/imu/adis16475.c:1959:69: error: passing argument 5 of 'devm_adis_setup_buffer_and_trigger_with_attrs' from incompatible pointer type [-Werror=incompatible-pointer-types]  
>     1959 |                                                                     adis16475_fifo_attributes);
>          |                                                                     ^~~~~~~~~~~~~~~~~~~~~~~~~
>          |                                                                     |
>          |                                                                     const struct attribute **
>    include/linux/iio/imu/adis.h:530:75: note: expected 'const struct iio_dev_attr **' but argument is of type 'const struct attribute **'
>      530 |                                               const struct iio_dev_attr **buffer_attrs);
>          |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 
> 
This does need to include linux/iio/sysfs.h

> vim +/devm_adis_setup_buffer_and_trigger_with_attrs +1959 drivers/iio/imu/adis16475.c
> 
>   1912	
>   1913	
>   1914	static int adis16475_probe(struct spi_device *spi)
>   1915	{
>   1916		struct iio_dev *indio_dev;
>   1917		struct adis16475 *st;
>   1918		int ret;
>   1919	
>   1920		indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
>   1921		if (!indio_dev)
>   1922			return -ENOMEM;
>   1923	
>   1924		st = iio_priv(indio_dev);
>   1925	
>   1926		st->info = spi_get_device_match_data(spi);
>   1927		if (!st->info)
>   1928			return -EINVAL;
>   1929	
>   1930		ret = adis_init(&st->adis, indio_dev, spi, &st->info->adis_data);
>   1931		if (ret)
>   1932			return ret;
>   1933	
>   1934		indio_dev->name = st->info->name;
>   1935		indio_dev->channels = st->info->channels;
>   1936		indio_dev->num_channels = st->info->num_channels;
>   1937		if (st->info->flags & ADIS16475_HAS_FIFO)
>   1938			indio_dev->info = &adis16575_info;
>   1939		else
>   1940			indio_dev->info = &adis16475_info;
>   1941		indio_dev->modes = INDIO_DIRECT_MODE;
>   1942	
>   1943		ret = __adis_initial_startup(&st->adis);
>   1944		if (ret)
>   1945			return ret;
>   1946	
>   1947		ret = adis16475_config_irq_pin(st);
>   1948		if (ret)
>   1949			return ret;
>   1950	
>   1951		ret = adis16475_config_sync_mode(st);
>   1952		if (ret)
>   1953			return ret;
>   1954	
>   1955		if (st->info->flags & ADIS16475_HAS_FIFO) {
>   1956			ret = devm_adis_setup_buffer_and_trigger_with_attrs(&st->adis, indio_dev,
>   1957									    adis16475_trigger_handler_with_fifo,
>   1958									    &adis16475_buffer_ops,
> > 1959									    adis16475_fifo_attributes);  
>   1960			if (ret)
>   1961				return ret;
>   1962			/* Update overflow behavior to always overwrite the oldest sample. */
>   1963			ret = adis_update_bits(&st->adis, ADIS16475_REG_FIFO_CTRL,
>   1964					       ADIS16575_OVERFLOW_MASK, (u16)ADIS16575_OVERWRITE_OLDEST);
>   1965		} else {
>   1966			ret = devm_adis_setup_buffer_and_trigger(&st->adis, indio_dev,
>   1967								 adis16475_trigger_handler);
>   1968		}
>   1969		if (ret)
>   1970			return ret;
>   1971	
>   1972		ret = devm_iio_device_register(&spi->dev, indio_dev);
>   1973		if (ret)
>   1974			return ret;
>   1975	
>   1976		adis16475_debugfs_init(indio_dev);
>   1977	
>   1978		return 0;
>   1979	}
>   1980	
>