Received-SPF: pass (google.com: domain of linux-kernel+bounces-176597-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <a1306ffa-c0ea-4ce6-8692-76bf37850e8a@amd.com>
Date: Sat, 11 May 2024 10:12:51 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] platform/x86: dell-laptop: Implement platform_profile
To: "Shen, Yijun" <Yijun.Shen@dell.com>, Lyndon Sanche <lsanche@lyndeno.ca>
Cc: "pali@kernel.org" <pali@kernel.org>, "W_Armin@gmx.de" <W_Armin@gmx.de>,
 "srinivas.pandruvada@linux.intel.com" <srinivas.pandruvada@linux.intel.com>,
 "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
 "lkp@intel.com" <lkp@intel.com>, Hans de Goede <hdegoede@redhat.com>,
 Matthew Garrett <mjg59@srcf.ucam.org>, Jonathan Corbet <corbet@lwn.net>,
 Heiner Kallweit <hkallweit1@gmail.com>,
 Vegard Nossum <vegard.nossum@oracle.com>,
 "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Dell Client Kernel <Dell.Client.Kernel@dell.com>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <20240501215829.4991-2-lsanche@lyndeno.ca>
 <BY5PR19MB392256C65661E76FC292C0889AE52@BY5PR19MB3922.namprd19.prod.outlook.com>
 <63894ef1-c482-4646-8351-4d6cfc6c528f@amd.com>
 <BY5PR19MB392299916A85FF06387DC9C19AE02@BY5PR19MB3922.namprd19.prod.outlook.com>
Content-Language: en-US
From: "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <BY5PR19MB392299916A85FF06387DC9C19AE02@BY5PR19MB3922.namprd19.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c1h0TlRucVczc0o0MHVDblpXVzd6dlBmVG1UMDY4MFdQeUt3dDRGa1dwRkZD?=
 =?utf-8?B?RWFPamoxR3hwQlVObWpVZmRrZzV4MitCdVFObmVmTG1TY0JZVTdsTGhPbUFS?=
 =?utf-8?B?YXgxUWZvcmR0SEFZL1ZXQzgyUC9JdmJTaW90cUplK1JzNDJDOXN5SVpGdkZI?=
 =?utf-8?B?VHI0NUhqR1RZSlJXR25iR0N4U2pGL1FPc0dXNnZ1SWpzZlFBY3VqYU1SU0Zz?=
 =?utf-8?B?WmxGRlZ0TG5qaUt4VVIvWHhEY01nZzBmbnkrK09pRTB1VHp4VE9aQldGRktx?=
 =?utf-8?B?Vk11bGhIdkJBYk5PY05OWXJUQ25DQzcrR3NIbzFTb3EwYWJTd2FOY3B5SU1S?=
 =?utf-8?B?VmlRNnlKLzlEMmtOK0VtMVhaaHU4ZXZZNk9HZlhVdlA0TWlmalIrandJYklQ?=
 =?utf-8?B?NU9kTzkzSkExaCs0RHQ1SkJibnVqSDk4U1BqVnJ3MkNhWHlabGE5djF6cUg3?=
 =?utf-8?B?QklyVlpIengrYnFnVEtzV0lUanovQTY4VG1zamk3L0F5ODJwVHFnNDYxQ2p1?=
 =?utf-8?B?VldaekQ3cG5EOHlHUjNHWWJ5SWVVZDNmd0NFRmFUbFNKalZzdTJXby8vS2JY?=
 =?utf-8?B?SkdFN2pibFpPUjZFRE4zRTBVcEN5cGc3UU9iS1hUVm41VzRnelB5dkJKaWdQ?=
 =?utf-8?B?S1JaMXQwL1AzeDlxZC9oUEFrNFBpc0YyanNMb0ErUDAzQmozcXpWMTVmaXpL?=
 =?utf-8?B?NDVQZGlTcGVET3pRbWNPLzJ6bkZ1cDR4RzZ5S3NCT2pSYlgzT1Vzd3kyczEw?=
 =?utf-8?B?N0FTcTBDa1dDdFdPRENFdXp1Z21Ed3VKcFZRMGgyUVYyYnZGRTh2akIwcVVQ?=
 =?utf-8?B?aDd5VTR0OUd3TlQwbzB4bGlFOEt1ZklIcXl5UkJEeGExWHlZY0J3WlV1RmVV?=
 =?utf-8?B?NGgzdzhlM04rbDZINk5ZdDJScFk4Zm1IVVBuaUNpbWtrbFF2WDJxQkYzSXNT?=
 =?utf-8?B?b29rcVIzRWNXRGZzbC9VNE1ndkgrUEpVSHlHZDF6UjdIV1Q3RVVLRTdRcS9t?=
 =?utf-8?B?NEUwbkdNQi90cXExNDhOVUFJUjJtamFxYTZqV2dzNDlLZHVTQ3dLZS9nUGo1?=
 =?utf-8?B?VUF2OGRHY3RWWWtKY3VZbFJSamJDQlNkeFZMb3FwaVo4Y0dLWnNhN2Z2ZkVB?=
 =?utf-8?B?R1RCTW1XSllQcXdNa3NhL21HOWVZUTdONENxMk10QnhQbHdSS3BtRHFYQUhm?=
 =?utf-8?B?SUJ1emNnTHBLSzRGdG1XLyt5WHlkNUp0ZU1YVjNQU2JuQnU3VDl0WGJreEo5?=
 =?utf-8?B?ZzNFVnh5UFpzWmxhSmhFcEtVRG5GRC9GZEEwNGgwY2FhRkttQndHZURwcDRh?=
 =?utf-8?B?Mm1RdUpMVTdxUGFuUGZueTVQb0NmbEh2bjNUZFBqeEJsdlRFQVlwQ0R0UFhQ?=
 =?utf-8?B?c1BRekM4bk9ZenhZNVB0TFhtMFh1QS81UEI5QytuZGl5MlU4ekpsZUlmbUdD?=
 =?utf-8?B?VXNvUHJnVUlSZjU3RzlWZThDQXNUYkZvd3FXL2tBeXpXTytOd3VhNENHTW5S?=
 =?utf-8?B?dGZtWkxJVi9vbWl2dTcvNjBEOXpoNnRUOE9OTW96dUljZlFXeHpXYUxCajdG?=
 =?utf-8?B?WGFrZEU0WDFFQjZlaDg5REJ6bEhTRTdBelR5bG5aZUpHQ0ZjcGx3SnR6WjJU?=
 =?utf-8?B?WjN0NzQ0YWFLUUlNTWtMRGJqZHVZbzk1ankxUng0cFEwMmNnVGdCaC9sbG00?=
 =?utf-8?B?YVowRjlVckxxWUNMaEJKRWVBRDJkaG1rMVFZYWdYc043N2dZT2xhQWVHN0ZM?=
 =?utf-8?B?VklQNWUrNmFGYUpPS3pCaTVmV0trTTlncGRHMWRwZGZmK0gxTXQxQVI5eVRN?=
 =?utf-8?B?eVdseWpLZzlpRnhaVWNCRzZKaWV1SmRMeXNKMGpQV29la3BIN2FqVVVQd2pm?=
 =?utf-8?B?b0FDMndhcStaVTBRQ1Y5QzBjcWVML1owd3J1am5mc29IOTh1UFRvYVlidzJs?=
 =?utf-8?B?T2swNmd0NmQ5dEozVTZsWDBlSTdIMkJhYnlPbEtzYzZHemtHQ04yY2xsbnRI?=
 =?utf-8?B?Vkh1bDB1bnF6WjA2RmdGOWdjNXB6UWwyd05FTlJwbVpjWFRLbVdTcm4rcWhk?=
 =?utf-8?B?TUlrNlZieCsxZkpDU0VwQnhNWkU0QWVqZWJvYXg0SHp2dWk4R0hMUCtXd2M2?=
 =?utf-8?Q?DzwyH2CG0SRAhghoAu/RgVbBM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b6254cf-4a12-4515-5bc1-08dc71ccd55d
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2024 15:12:54.7651
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hiephPb6cpc7cxd3d3biA2FQRXpcZBr/R3pitc/m6NWOx00u2s8zfyL1kEebTIP1e326u8dh9VzOi/+jJPv0SQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5706


On 5/11/2024 10:05 AM, Shen, Yijun wrote:
> 
> Internal Use - Confidential
>> -----Original Message-----
>> From: Mario Limonciello <mario.limonciello@amd.com>
>> Sent: Wednesday, May 8, 2024 11:53 PM
>> To: Shen, Yijun <Yijun_Shen@Dell.com>; Lyndon Sanche
>> <lsanche@lyndeno.ca>
>> Cc: pali@kernel.org; W_Armin@gmx.de;
>> srinivas.pandruvada@linux.intel.com; ilpo.jarvinen@linux.intel.com;
>> lkp@intel.com; Hans de Goede <hdegoede@redhat.com>; Matthew Garrett
>> <mjg59@srcf.ucam.org>; Jonathan Corbet <corbet@lwn.net>; Heiner Kallweit
>> <hkallweit1@gmail.com>; Vegard Nossum <vegard.nossum@oracle.com>;
>> platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org; Dell Client
>> Kernel <Dell.Client.Kernel@dell.com>
>> Subject: Re: RE: [PATCH v5] platform/x86: dell-laptop: Implement
>> platform_profile
>>
>>
>> [EXTERNAL EMAIL]
>>
>> On 5/8/2024 09:24, Shen, Yijun wrote:
>>> Hi Lyndon,
>>>
>>>    Thanks for working on this patch.
>>>
>>>>
>>>    Dell side has an initial testing with this patch on some laptops, it looks
>> good. While changing the platform profile:
>>> 1. The corresponding USTT option in BIOS will be changed.
>>> 2. thermald will not be impacted. The related PSVT and ITMT will be loaded.
>>>    Some Dell DTs does not have the USTT, Dell'll have a check if nothing is
>> broken.
>>
>> Hi Alex!
>>
>> Have you had a check both on both your AMD laptops and workstations too,
>> or just the Intel ones?  I think it would be good to make sure it's getting the
>> correct experience in both cases.
>>
> Hi Mario,
> 
>   I've a check for this, for both laptop and workstation, the dell_laptop module will not be loaded. So, AMD platform will not be impacted by this patch series.
> Follow is one example output with workstation.
>   #lsmod | grep dell
>     dell_wmi               28672  0
>     dell_smbios            32768  1 dell_wmi
>     dcdbas                 20480  1 dell_smbios
>     dell_wmi_descriptor    20480  2 dell_wmi,dell_smbios
>     sparse_keymap          12288  1 dell_wmi
>     ledtrig_audio          12288  3 snd_ctl_led,snd_hda_codec_generic,dell_wmi
>     video                  73728  2 dell_wmi,nvidia_modeset
>     wmi                    40960  5 video,dell_wmi,wmi_bmof,dell_smbios,dell_wmi_descriptor
> 

Ah; right that makes sense.  In that case, is dell-laptop even the right 
place for this patch series?  I would think the same policies for the 
platform profile should be able to apply to desktop/workstation.

The v6 of this series would block smbios-thermal-ctl from working on a 
workstation too.

>>>
>>>     Additional, with this patch, follow behavior is found:
>>>    1. For example, the platform profile is quiet.
>>>    2. Reboot the system and change the USTT to performance.
>>>    3. Boot to desktop, the platform profile is "quiet", the USTT will be
>> changed back to "quiet".
>>>    This looks like not a proper user experience. The platform profile should
>> honor the BIOS setting, aka, the platform profile should be switched to
>> "performance".
>>>
>>
>> I agree, this sounds like the initial profile needs to be read from the BIOS
>> settings too.
>>
>> Furthermore I wanted to ask is there also a WMI setting that corresponds to
>> this that dell-wmi-sysman offers?
>   Yes, Mario, you're right. This thermal setting could also be toggled by dell-wmi-sysman.
> But, for the Dell consumer AMD laptops, like Alienware, the BIOS is another variant which is different with the workstation one.
> With this variant BIOS, there is no USTT and also no dell_wmi/dell-wmi-sysman.
> 
>> I'm wondering if both should be probed in case the SMBIOS one goes away one day.
>   Yep, I think this is a good suggestion.
> 

Great! Although something I wonder is if the policy when changed with 
dell-wmi-sysman is immediate or requires a reboot.  A lot of the 
settings in there aren't effective until after a reboot.

If this is one of them then it might not be a good idea to make it work 
for both.