Received-SPF: pass (google.com: domain of linux-kernel+bounces-176598-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <5ac2d604-465f-4d33-9d3a-7cd8e4a41246@amd.com>
Date: Sat, 11 May 2024 10:13:23 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 1/2] platform/x86: dell-smbios: Add helper for checking
 supported commands
To: Lyndon Sanche <lsanche@lyndeno.ca>
Cc: pali@kernel.org, W_Armin@gmx.de, srinivas.pandruvada@linux.intel.com,
 ilpo.jarvinen@linux.intel.com, lkp@intel.com, hdegoede@redhat.com,
 Yijun.Shen@dell.com, Matthew Garrett <mjg59@srcf.ucam.org>,
 Heiner Kallweit <hkallweit1@gmail.com>, Randy Dunlap
 <rdunlap@infradead.org>, Vegard Nossum <vegard.nossum@oracle.com>,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 Dell.Client.Kernel@dell.com
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <20240511023726.7408-3-lsanche@lyndeno.ca>
Content-Language: en-US
From: "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20240511023726.7408-3-lsanche@lyndeno.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ak9yN0tMSCtHcWg4Rk45SmNBZnhQcjIwbTVTT1FHWjNBUlBTY0ZGVHBQTDBy?=
 =?utf-8?B?US8xR3UzTkRCT091ZktpQko1ZjRhOXdKRkppeWYzR2krWXhzYzhwZnhHNlhG?=
 =?utf-8?B?cjhsQmNDYmlDWlQvRHBqanNjZ0dneWhTbnlQU1JpcVltcEo2ZWN6RjMvOTd3?=
 =?utf-8?B?d1o3UDNFaGZXeFoyMzNWVFVnWm0rQlNvd20ya1pUTnpGN3RZdUp2QTRnQXg3?=
 =?utf-8?B?akxNeXkwWFRnNUlteitQVEwyNmpkTWo4OFBkNDVRQktNRjh0c2ozcGNxaUF4?=
 =?utf-8?B?VndsVklSUUNTNW9aUWZJTWREbnJlVTBTUmEvMmlpZTJzRDlhZnRmbmFnUzBU?=
 =?utf-8?B?c29Lb2xZTENlNHk2bXhHWlpVY0xhMmtSM3ZGUTVDZTB6Zjh5aHppZng4Qm9S?=
 =?utf-8?B?VVd0a1VDWFYyTG8wZm1yQ0xSYmRSU01ZaWY1NGVQZ0pXdk1lWVU4c3czamow?=
 =?utf-8?B?Y1RtR2ZOR2hpQ0lZMDkzcFVMTENuMXVQT0R6NjQ1dE5nWU8vQVlOVHJ6OTRK?=
 =?utf-8?B?amFrVmVNaDBqT3FsdGtvVWZLNjV4dnNyWUROb21zQTNmZXU4ZG5aYUlOMyt0?=
 =?utf-8?B?QmpCSExPekxjOXdXMGtJcXVJd1lkWjRiNTlKSC9UdHZtRWMyYVQyOWFEQ3lC?=
 =?utf-8?B?RlNHN2ZxeFhxVVJNemQwWTA5NXdFcEtwdWNIUzVQT0E1VjNiN2dncGpTcHNw?=
 =?utf-8?B?TGpJb3F5enBhSVZrWVpZNFRJVmdzZzdnRXdSWDJjT3g3UlNQODF4Yk80RUcv?=
 =?utf-8?B?SmRyakdVam8yZTVzUm1WREtjN2ZoQThGSC9lbS9acU0vT254WlpNLzRkaGgy?=
 =?utf-8?B?cGJNZCtHOHl6RC9XQitzd1pjWGd2ZWZab3FhYmFENHgrYkM1YjFqRjRXTk8z?=
 =?utf-8?B?N1I4amcrbGtQeEljM0RkaTVjclZSYzNKdDdnQk96ZUxSeFhnbW52YVhzQVFE?=
 =?utf-8?B?NnpkNzdYL0hVMFpDdDJNR0FzTnlLK3ZOcFdaeTJrcTNEVDR6dzgzK1FJWiti?=
 =?utf-8?B?K2ZwVkt6Rm5UNGxBMFR2SktZUnRMZ2RIRFVEL1BoTTlCQ3A2dG8wL0Y5cWdP?=
 =?utf-8?B?ZkRSRTNBUWtLY0RZclhYbHlpS3JwOXl0ZGxHUWNVZEplVkJ3RHZsaC9oVUJD?=
 =?utf-8?B?bWR3anNOcXhoaFVldmdFVlE2azRvNGFxWXM5MWZnMlRacFJGTS9RM0RvRlZj?=
 =?utf-8?B?c1NxSGlnaWJ0cDRXK3U4R05nQXpUdDVNOGRVcm80UVBhNndSc3ZDZTg2UUtn?=
 =?utf-8?B?VmRtVENrTHgwVzNSR1dkOWpiT3V2QTlrR1FPcXRxSzlIdWVxY3ZUcGtkOVcv?=
 =?utf-8?B?dkdaT2RiZlc4UW1iT0FuYVhPRHFuLzlGcklRUll2K2JONVFTQ3QzWWRXNlE3?=
 =?utf-8?B?WWNuR01zeCtpT1JFOWgwTDcyaFFLQnp4NEhJUjZKTTJxZDI0VzBhL2RkNFFV?=
 =?utf-8?B?OHdhSi9YZVJMenQ3OHY1emxqRmZhY2EvSkZKSExtbnZpa3NIV1dhbFo4SXVM?=
 =?utf-8?B?UnU5NnZ5UEJjaVNzOFpTL3VhblVuMUxOOEFmMHExMCtqQUw4dXFRalRFQVhW?=
 =?utf-8?B?cTV5S0hTZGY1elZDaFpJUW9wY0FoNDVMeHl1VklHSThxa2lUdSt0SG5pZHlo?=
 =?utf-8?B?TXNGVXMzdTBMSTRFZ3VuYzNCNzQra09Pa0VJTDhNQkxnZk1VT3NxYjBqTWlN?=
 =?utf-8?B?dGp1VlFoQk5pNHhQdThGbUJnWFoyamNaMWljeitOQ29LclpkUFZHMEI0ekRN?=
 =?utf-8?B?VlZ4SmNFOTVDZUUxMGQzMk9kRnFWR2xwb0JUME5yb2hzSFVWREJLNGh5WUQv?=
 =?utf-8?B?dHoyWDhVVnpZZUx1WHF1eVk3cGUrTzZ6SkFJZVVSbGk3U0VjRWRyVVlqS3BK?=
 =?utf-8?B?bFNOODE2YlIrZjRWVGVLMlMwamliOVpNY0RpaXdzZURSSVFvOWE2a3k5eFhu?=
 =?utf-8?B?ZFNrRC95N3B6cDlISzBkVU1LTzR5TVBqYzdhREhDM0ZTU3NJSnBrUjZaM2pn?=
 =?utf-8?B?VGJVSXBTSzVPTDJpUzZ2L05TQjc5aEtDNWtNZW1Dd2c5Si9paWUyUk1UR3cy?=
 =?utf-8?B?QmVtRHJkaGE5cTU1eEdoNklEbU1OMm1ScTBIUjlUQ3JuSU44ckhLa0RlY09G?=
 =?utf-8?Q?hTBt8GJ8/KiUPJJXZM+nDKkmu?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15d7ecc3-caf2-42a8-ec53-08dc71cce7ec
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2024 15:13:25.9018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oRBK1B7r2u9rierSdKqEgC3ihZefJCSxv2sFP8YvCXykXTC/mYLM8aGv29P3dMrwNDuB768EBznKajKbdjhz6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5706


On 5/10/2024 9:36 PM, Lyndon Sanche wrote:
> Add symbol to check if a specific class of smbios command is supported.
> 
> Signed-off-by: Lyndon Sanche <lsanche@lyndeno.ca>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/platform/x86/dell/dell-smbios-base.c | 6 ++++++
>   drivers/platform/x86/dell/dell-smbios.h      | 1 +
>   2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-smbios-base.c b/drivers/platform/x86/dell/dell-smbios-base.c
> index e61bfaf8b5c4..6ae09d7f76fb 100644
> --- a/drivers/platform/x86/dell/dell-smbios-base.c
> +++ b/drivers/platform/x86/dell/dell-smbios-base.c
> @@ -350,6 +350,12 @@ void dell_laptop_call_notifier(unsigned long action, void *data)
>   }
>   EXPORT_SYMBOL_GPL(dell_laptop_call_notifier);
>   
> +bool dell_laptop_check_supported_cmds(u16 class)
> +{
> +	return da_supported_commands & (1 << class);
> +}
> +EXPORT_SYMBOL_GPL(dell_laptop_check_supported_cmds);
> +
>   static void __init parse_da_table(const struct dmi_header *dm)
>   {
>   	/* Final token is a terminator, so we don't want to copy it */
> diff --git a/drivers/platform/x86/dell/dell-smbios.h b/drivers/platform/x86/dell/dell-smbios.h
> index eb341bf000c6..63116671eada 100644
> --- a/drivers/platform/x86/dell/dell-smbios.h
> +++ b/drivers/platform/x86/dell/dell-smbios.h
> @@ -73,6 +73,7 @@ enum dell_laptop_notifier_actions {
>   int dell_laptop_register_notifier(struct notifier_block *nb);
>   int dell_laptop_unregister_notifier(struct notifier_block *nb);
>   void dell_laptop_call_notifier(unsigned long action, void *data);
> +bool dell_laptop_check_supported_cmds(u16 class);
>   
>   /* for the supported backends */
>   #ifdef CONFIG_DELL_SMBIOS_WMI